coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: cpu/x86/topology: Add module_id to CPU topology
by Frans Hendriks (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Jérémy Compostella. Frans Hendriks has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85577?usp=email ) Change subject: cpu/x86/topology: Add module_id to CPU topology ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85577?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c8a76dce48c0539a3f36015674553a2461dec27 Gerrit-Change-Number: 85577 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 06:52:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: payloads/LinuxBoot: Build x86_64 with host toolchain
by Frans Hendriks (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Christian Walter, Elyes HAOUAS, Felix Singer, Martin L Roth, Maximilian Brune. Frans Hendriks has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83990?usp=email ) Change subject: payloads/LinuxBoot: Build x86_64 with host toolchain ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icaf56d6991d79f629e9ba8c901b441d81921d594 Gerrit-Change-Number: 83990 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes HAOUAS Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes HAOUAS Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 06:50:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD
by Kapil Porwal (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Jérémy Compostella, Paul Menzel, Subrata Banik. Kapil Porwal has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85131?usp=email ) Change subject: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie72e4725cb97b4af7843a43eeaedd687d28b6752 Gerrit-Change-Number: 85131 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 05:26:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/common: Read core scaling factors at runtime support
by Pranava Y N (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Jérémy Compostella. Pranava Y N has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85553?usp=email ) Change subject: soc/intel/common: Read core scaling factors at runtime support ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85553?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icdf47e17cc5a6d042f3c5f90cf811fccd6c1ed9b Gerrit-Change-Number: 85553 Gerrit-PatchSet: 7 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 05:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: cpu/x86/topology: Add module_id to CPU topology
by Pranava Y N (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Jérémy Compostella. Pranava Y N has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85577?usp=email ) Change subject: cpu/x86/topology: Add module_id to CPU topology ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85577?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c8a76dce48c0539a3f36015674553a2461dec27 Gerrit-Change-Number: 85577 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 05:16:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and ...
by Yunlong Jia (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik. Yunlong Jia has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email ) Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85512/comment/7d416794_ea82e769?us… : PS5, Line 10: We cannot add a dedicated DB_HDMI field item, so reuse DB_A_HDMI_LTE : (old name:DB_A) as the HDMI switch. : We cannot modify the TOUCH_PANEL field item according to the screen : model. : Type-C and HDMI use the same interface in hardware， : so turn off the Type-C setting when using HDMI, : And use TOUCH_PANEL_I2C_GENERIC to open another screen model. > List of changes: […] Done https://review.coreboot.org/c/coreboot/+/85512/comment/8a5d4314_4fd46786?us… : PS5, Line 18: field DB_USB 0 1 : option DB_NONE 0 : option DB_C_A 1 : option DB_C_A_LTE 2 : option DB_A_HDMI_LTE 3 : : field TOUCH_PANEL 9 : option TOUCH_PANEL_I2C_HID 0 : option TOUCH_PANEL_I2C_GENERIC 1 > remove Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9 Gerrit-Change-Number: 85512 Gerrit-PatchSet: 6 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jiping He <jiping.he(a)ecs.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 05:13:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and ...
by Yunlong Jia (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik, Yunlong Jia. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kyle Lin, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85512?usp=email to look at the new patch set (#6). Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel ...................................................................... mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel 1. Reuse DB_A (now DB_A_HDMI_LTE) as the HDMI switch. 2. Turn off the Type-C port C1 when using HDMI because both of them use the same interface in hardware. 3. Use TOUCH_PANEL_I2C_GENERIC (formerly TOUCH_PANEL_DISABLE) to support other screen models as we cannot have different fields to support individual touch screen models. BUG=b:365445053 TEST=emerge-nissa coreboot and run in DUT Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9 Signed-off-by: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> --- M src/mainboard/google/brya/variants/gothrax/fw_config.c M src/mainboard/google/brya/variants/gothrax/gpio.c M src/mainboard/google/brya/variants/gothrax/overridetree.cb M src/mainboard/google/brya/variants/gothrax/variant.c 4 files changed, 35 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/85512/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9 Gerrit-Change-Number: 85512 Gerrit-PatchSet: 6 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jiping He <jiping.he(a)ecs.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[M] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and ...
by Kapil Porwal (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik, Yunlong Jia. Kapil Porwal has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email ) Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel ...................................................................... Patch Set 5: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85512/comment/454383f6_a742d904?us… : PS5, Line 10: We cannot add a dedicated DB_HDMI field item, so reuse DB_A_HDMI_LTE : (old name:DB_A) as the HDMI switch. : We cannot modify the TOUCH_PANEL field item according to the screen : model. : Type-C and HDMI use the same interface in hardware， : so turn off the Type-C setting when using HDMI, : And use TOUCH_PANEL_I2C_GENERIC to open another screen model. List of changes: 1. Reuse DB_A (now DB_A_HDMI_LTE) as the HDMI switch. 2. Turn off the Type-C port C1 when using HDMI because both of them use the same interface in hardware. 3. Use TOUCH_PANEL_I2C_GENERIC (formerly TOUCH_PANEL_DISABLE) to support other screen models as we cannot have different fields to support individual touch screen models. https://review.coreboot.org/c/coreboot/+/85512/comment/821e0aef_3ed1c5cf?us… : PS5, Line 18: field DB_USB 0 1 : option DB_NONE 0 : option DB_C_A 1 : option DB_C_A_LTE 2 : option DB_A_HDMI_LTE 3 : : field TOUCH_PANEL 9 : option TOUCH_PANEL_I2C_HID 0 : option TOUCH_PANEL_I2C_GENERIC 1 remove File src/mainboard/google/brya/variants/gothrax/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85512/comment/79bcb9ea_9cd8ea94?us… : PS5, Line 226: 300 This value is very high and will impact s0ix suspend/resume timings. Could you please track it as a bug? -- To view, visit https://review.coreboot.org/c/coreboot/+/85512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9 Gerrit-Change-Number: 85512 Gerrit-PatchSet: 5 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jiping He <jiping.he(a)ecs.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 04:57:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD
by Pranava Y N (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Jérémy Compostella, Kapil Porwal, Paul Menzel, Subrata Banik. Pranava Y N has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85131?usp=email ) Change subject: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie72e4725cb97b4af7843a43eeaedd687d28b6752 Gerrit-Change-Number: 85131 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 04:44:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Suppress unnecessary extra space in device trees
by Pranava Y N (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Jérémy Compostella, Subrata Banik. Pranava Y N has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85661?usp=email ) Change subject: mb/google/fatcat: Suppress unnecessary extra space in device trees ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I546e704fa1c525406edede24cf0b4485276b878e Gerrit-Change-Number: 85661 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 04:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024