coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2521 discussions

[XS] Change in coreboot[main]: Update open-power-signing-utils submodule to upstream master
by Elyes Haouas (Code Review) 03 Nov '24

03 Nov '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84978?usp=email ) Change subject: Update open-power-signing-utils submodule to upstream master ...................................................................... Update open-power-signing-utils submodule to upstream master Updating from commit id 591c8f5: 2020-06-03 08:30:23 -0500 - (Merge pull request #32 from mtvaught-ibm/secure-version) to commit id 9a80ee8: 2024-10-03 08:59:57 -0500 - (Fix hashkeys helptext to list container version 3 (#46)) This brings in 32 new commits: 9a80ee8 Fix hashkeys helptext to list container version 3 (#46) d464fa5 Add mldsa 87 support (#45) 51b6589 Add v3 container support (#43) e4fa7b6 Merge pull request #42 from open-power/UpstreamRepo 54a5ef7 Update for public mlca repo 96db818 Add missing required include c13558b Merge pull request #41 from open-power/AddV2Signing 49fea67 Code updates from review comments 41beb36 Apply clang format to new tool b668132 Add support for v2 signing with mlca_framework 9b71b5f Merge pull request #40 from mtvaught-ibm/use-sf-short 7010647 Use getopt short flags when calling sf_client 0221718 Merge pull request #39 from mtvaught-ibm/add-aix-build 353294a Add support for building create/print/hash binaries on AIX 5af9cc4 Merge pull request #38 from mtvaught-ibm/add-ssh-passwd-env-to-ini 1c2fa21 Allow defining sshkey password environment variable in .ini config file bd9418a Merge pull request #37 from mtvaught-ibm/env-pwd 2b1b78b Merge pull request #36 from mtvaught-ibm/multiple-ini af4a5d5 Add option to provide sf_client the ssh key passphrase through ENV a863ee4 Add support to --sign-project-config for multiple .ini files afb556c Merge pull request #34 from open-power/AddV2_2 f70629f Add support to set fw header ECID for v2 containers a993255 Final fixes for production container signing 110b0a6 Fix crtSignedContainer.sh to pull all SW keys 4bead21 Added support to detect dilithium key files 464c298 Add separate boot/runtime v2 imprint keys e31d495 Rename default HW key files bc8057f Add initial support for Dilithium keys 72cf502 Disable container v2 support for downlevel openssl ea9cbe1 Add support for container version 2 33a3908 Merge pull request #33 from open-power/v0.9-release 0766395 prep for 0.9 release Change-Id: I37b77a72f3990d929dbaa1f1c5c33ec2d4c1cf00 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/open-power-signing-utils 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/84978/1 diff --git a/3rdparty/open-power-signing-utils b/3rdparty/open-power-signing-utils index 591c8f5..9a80ee8 160000 --- a/3rdparty/open-power-signing-utils +++ b/3rdparty/open-power-signing-utils @@ -1 +1 @@ -Subproject commit 591c8f53482243626901e1cc8a4ae321f314040d +Subproject commit 9a80ee84740877dbbe1201436503da725f13c9b4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84978?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37b77a72f3990d929dbaa1f1c5c33ec2d4c1cf00 Gerrit-Change-Number: 84978 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Update intel-sec-tools submodule to upstream main
by Elyes Haouas (Code Review) 03 Nov '24

03 Nov '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84977?usp=email ) Change subject: Update intel-sec-tools submodule to upstream main ...................................................................... Update intel-sec-tools submodule to upstream main Updating from commit id 0031ac7: 2021-06-22 14:22:03 +0200 - (Merge pull request #245 from 9elements/meparser) to commit id 5f38440: 2024-08-15 13:34:36 +0200 - (chore: update workflow) This brings in 323 new commits. Change-Id: I5f0224dff49b800cb41130f12048ae48e2df4107 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/intel-sec-tools 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/84977/1 diff --git a/3rdparty/intel-sec-tools b/3rdparty/intel-sec-tools index 0031ac7..5f38440 160000 --- a/3rdparty/intel-sec-tools +++ b/3rdparty/intel-sec-tools @@ -1 +1 @@ -Subproject commit 0031ac73447baeb197fb2d80e5fba2470716e76d +Subproject commit 5f384405a351d7813e1bfdc34b5ed74ba4540b05 -- To view, visit https://review.coreboot.org/c/coreboot/+/84977?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f0224dff49b800cb41130f12048ae48e2df4107 Gerrit-Change-Number: 84977 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Update cmocka submodule to upstream master
by Elyes Haouas (Code Review) 03 Nov '24

03 Nov '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84976?usp=email ) Change subject: Update cmocka submodule to upstream master ...................................................................... Update cmocka submodule to upstream master Updating from commit id 8be3737: 2024-02-04 11:20:16 +0100 - (cmocka: Fix assert_memory_equal() display) to commit id fa9b644: 2024-07-08 10:55:57 +0200 - (doc: Fix pre-defined macro definition) This brings in 204 new commits. Change-Id: I3da6a77314b00d8a2bf2c6eacae6cbdb1fc6d40e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/cmocka 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/84976/1 diff --git a/3rdparty/cmocka b/3rdparty/cmocka index 8be3737..fa9b644 160000 --- a/3rdparty/cmocka +++ b/3rdparty/cmocka @@ -1 +1 @@ -Subproject commit 8be37372097d1aa5e03b565936db7891b6180e73 +Subproject commit fa9b6449c54f4defbad7e27e35b0ce8d6547d8b4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3da6a77314b00d8a2bf2c6eacae6cbdb1fc6d40e Gerrit-Change-Number: 84976 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Update arm-trusted-firmware submodule to upstream master
by Elyes Haouas (Code Review) 03 Nov '24

03 Nov '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84975?usp=email ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id 8fb91783f: 2024-08-23 14:45:12 +0200 - (Merge "fix(intel): add in missing ECC register" into integration) to commit id dddded141: 2024-11-01 14:29:20 +0100 - (Merge changes from topic "xlnx_fix_plat_boolc_fn_ret" into integration) This brings in 379 new commits. Change-Id: I39213de9697e3edc9489ca5309c6a662b3e380ec Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/arm-trusted-firmware 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/84975/1 diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 8fb9178..dddded1 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 8fb91783ffa96343dd8ebad9773d7c2055ea4496 +Subproject commit dddded141458fe1ff8fcbf8f3080dbf20953e7a4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84975?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39213de9697e3edc9489ca5309c6a662b3e380ec Gerrit-Change-Number: 84975 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: commonlib/fsp_relocate.c: Use enum cb_err instead of int
by Elyes Haouas (Code Review) 03 Nov '24

03 Nov '24

Attention is currently required from: Elyes Haouas. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84912?usp=email ) Change subject: commonlib/fsp_relocate.c: Use enum cb_err instead of int ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a9cda6148566bca326cb0258611664fb2ca0ee7 Gerrit-Change-Number: 84912 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 03 Nov 2024 08:14:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: commonlib/device_tree: Use enum cb_err instead of int
by Elyes Haouas (Code Review) 03 Nov '24

03 Nov '24

Attention is currently required from: Elyes Haouas, Julius Werner. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84911?usp=email ) Change subject: commonlib/device_tree: Use enum cb_err instead of int ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf938c24d067c9d15faf45b6072e150f0aedfe08 Gerrit-Change-Number: 84911 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 03 Nov 2024 08:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO
by Sukumar Ghorai (Code Review) 03 Nov '24

03 Nov '24

Attention is currently required from: Pranava Y N. Sukumar Ghorai has posted comments on this change by Sukumar Ghorai. ( https://review.coreboot.org/c/coreboot/+/84957?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84957/comment/78d0a999_1ae0dca6?us… : PS5, Line 9: This patch configures the ESPI_SOC_ALERT_L GPIO pad on fatcat as NC to enable S0ix low power entry. > please use line break at < 72 char Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb80a56177105c0281d05fe1f5daa87e6f7e291f Gerrit-Change-Number: 84957 Gerrit-PatchSet: 6 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Sun, 03 Nov 2024 07:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO
by Sukumar Ghorai (Code Review) 03 Nov '24

03 Nov '24

Attention is currently required from: Pranava Y N, Sukumar Ghorai. Hello Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84957?usp=email to look at the new patch set (#6). Change subject: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO ...................................................................... mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO This patch configures the ESPI_SOC_ALERT_L GPIO pad on fatcat as NC to enable S0ix low power entry. TEST=Build fatcat and check the platform boots without an issue. Change-Id: Icb80a56177105c0281d05fe1f5daa87e6f7e291f Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/google/fatcat/variants/fatcat/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/84957/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/84957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb80a56177105c0281d05fe1f5daa87e6f7e291f Gerrit-Change-Number: 84957 Gerrit-PatchSet: 6 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO
by Subrata Banik (Code Review) 03 Nov '24

03 Nov '24

Attention is currently required from: Pranava Y N, Sukumar Ghorai. Subrata Banik has posted comments on this change by Sukumar Ghorai. ( https://review.coreboot.org/c/coreboot/+/84957?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84957/comment/7c153363_9f6bb3ad?us… : PS5, Line 9: This patch configures the ESPI_SOC_ALERT_L GPIO pad on fatcat as NC to enable S0ix low power entry. please use line break at < 72 char -- To view, visit https://review.coreboot.org/c/coreboot/+/84957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb80a56177105c0281d05fe1f5daa87e6f7e291f Gerrit-Change-Number: 84957 Gerrit-PatchSet: 5 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Sun, 03 Nov 2024 07:22:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO
by Sukumar Ghorai (Code Review) 03 Nov '24

03 Nov '24

Attention is currently required from: Pranava Y N. Sukumar Ghorai has posted comments on this change by Sukumar Ghorai. ( https://review.coreboot.org/c/coreboot/+/84957?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84957/comment/eb0156ec_dfbe48ed?us… : PS4, Line 7: mb/google/fatcat: configure espi alarm gpio > mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb80a56177105c0281d05fe1f5daa87e6f7e291f Gerrit-Change-Number: 84957 Gerrit-PatchSet: 5 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Sun, 03 Nov 2024 07:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024