Attention is currently required from: Derek Huang, Shou-Chieh Hsu.
Hello Derek Huang, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#8).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 8
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Attention is currently required from: Derek Huang, Shou-Chieh Hsu.
Hello Derek Huang, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Attention is currently required from: Derek Huang, Shou-Chieh Hsu.
Hello Derek Huang, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xbw, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Robert Chen has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Nov 2024 07:17:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82532?usp=email )
Change subject: coreboot-jenkins-node/Dockerfile: Update very old pkgs
......................................................................
Patch Set 3:
(1 comment)
File util/docker/coreboot-jenkins-node/Dockerfile:
https://review.coreboot.org/c/coreboot/+/82532/comment/42fee922_e34ed082?us… :
PS3, Line 77: pip3 install --upgrade --no-cache-dir pip && \
: pip3 install --no-cache-dir \
: setuptools==58.2.0 \
: jinja2==3.1.3 \
: myst-parser===2.0.0 \
: sphinx===7.2.6 \
: sphinxcontrib-ditaa===1.0.2 \
: sphinx_autobuild===2024.2.4 \
: sphinx_rtd_theme===2.0.0 \
It is intended this way since
1) It's ran within a venv environment and thus separated from system packages
2) this things require testing before an update is done.
There is no change needed here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82532?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad0640901e8351de2b90bf733d390bb9e7e31a52
Gerrit-Change-Number: 82532
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 04 Nov 2024 03:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email )
(
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: mb/google/dedede/var/awasuki: Tune I2C touchpad for freq and TH
......................................................................
mb/google/dedede/var/awasuki: Tune I2C touchpad for freq and TH
1. Modify the I2C frequency of the touchpad between 380 Khz and
400 Khz to meet the spec.
2. Increase clk the time of high (TH) to greater than 600ns.
Before:
I2C0 - 420KHz
TH - 557ns
After:
I2C0 - 398Khz
TH - 630ns
BUG=b:351968527
TEST=Check that the wave form meets the spec.
Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d
Signed-off-by: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84898
Reviewed-by: Eric Lai <ericllai(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/awasuki/overridetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Paul Menzel: Looks good to me, but someone else must approve
Eric Lai: Looks good to me, approved
build bot (Jenkins): Verified
Weimin Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/awasuki/overridetree.cb b/src/mainboard/google/dedede/variants/awasuki/overridetree.cb
index 6a7df2f..cc7eba83 100644
--- a/src/mainboard/google/dedede/variants/awasuki/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/awasuki/overridetree.cb
@@ -30,6 +30,12 @@
},
.i2c[0] = {
.speed = I2C_SPEED_FAST,
+ .speed_config[0] = {
+ .speed = I2C_SPEED_FAST,
+ .scl_lcnt = 178,
+ .scl_hcnt = 92,
+ .sda_hold = 40,
+ }
},
.i2c[2] = {
.speed = I2C_SPEED_FAST,
--
To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d
Gerrit-Change-Number: 84898
Gerrit-PatchSet: 11
Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>