Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Robert Chen, Shou-Chieh Hsu.
Hello Derek Huang, Karthik Ramasubramanian, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#10).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return. Drawper LTE board version was set after 0x9, but there are
more board added after that. Specific Drawper board version as 0xa, 0xb and 0xf.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 10
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Robert Chen, Shou-Chieh Hsu.
Hello Derek Huang, Karthik Ramasubramanian, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#9).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return. Drawper LTE board was set after 0x9, but there are more board
version added after that. Specific Drawper board version as 0xa, 0xb
and 0xf.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 9
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Robert Chen, Shou-Chieh Hsu.
Paul Menzel has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/d53ffbb6_f2a70dfd?us… :
PS8, Line 7: Fix devicetree_update
Something more specific would be nice.
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/84953/comment/56292731_8aa1cb72?us… :
PS8, Line 14:
Unrelated.
https://review.coreboot.org/c/coreboot/+/84953/comment/1a6b5ded_09aa909c?us… :
PS8, Line 36: if (board_version > 0xb)
: ext_vr_update();
Before it was run for `board_version < 9`. Is the change in behavior wanted?
https://review.coreboot.org/c/coreboot/+/84953/comment/7917ccc4_0a1701d2?us… :
PS8, Line 38: /* Remove power IC after board version 0xc */
What about 0xf? Should it be mentioned in the comment?
https://review.coreboot.org/c/coreboot/+/84953/comment/53047ae1_535d1884?us… :
PS8, Line 38: /* Remove power IC after board version 0xc */
: if (board_version != 0xa &&
: board_version != 0xb &&
: board_version != 0xf)
: update_lte_device_drawcia();
: /* board version 0xa, 0xb , 0xf is for drawper unit */
This is not mentioned in the commit message. Could you elaborate?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 8
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 04 Nov 2024 08:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Derek Huang, Shou-Chieh Hsu.
Hello Derek Huang, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#8).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 8
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Attention is currently required from: Derek Huang, Shou-Chieh Hsu.
Hello Derek Huang, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Attention is currently required from: Derek Huang, Shou-Chieh Hsu.
Hello Derek Huang, Shou-Chieh Hsu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xb, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
mb/google/dedede/var/drawcia: Fix devicetree_update
ext_vr_update should be run after board version 0xbw, but skipped by
return.
BUG=b:376828839
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage and test on DUTs.
Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/84953/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Robert Chen has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Nov 2024 07:17:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No