Kevin Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79887?usp=email )
Change subject: mb/google/dedede/var/beadrix: Generate SPD ID for supported memory part
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a6925395b52dc7aa5c0f93b8820099369db4dbf
Gerrit-Change-Number: 79887
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 23 Jan 2024 09:11:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ashish Kumar Mishra, Bora Guvendik, Saurabh Mishra, Wonkyu Kim.
Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79900?usp=email )
Change subject: soc/intel/common: Add lunarlake device IDs
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Adding CPU id is missed. […]
Done. Thankyou.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79900?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id31d567287b9921d60909b1eb617c7cfaf6672c9
Gerrit-Change-Number: 79900
Gerrit-PatchSet: 3
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 09:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Lance Zhao, Patrick Rudolph, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80169?usp=email )
Change subject: device: Add inline method to identify PATH_ROOT
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/80169/comment/cef7b2bc_0a2498eb :
PS1, Line 166: extern DEVTREE_CONST struct device dev_root;
> I don't see how the compiler could optimize something. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80169/comment/493eb098_83e57dac :
PS1, Line 467: dev->bus->dev == dev
Would it make sense to document this on line 87 of main.c in sconfig?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59
Gerrit-Change-Number: 80169
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 09:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Appukuttan V K, Bora Guvendik.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79899?usp=email )
Change subject: soc/intel: Add Lunar Lake device IDs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79899?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0aae6fd7aa8ba3a6a794f8af5ecf3967509b704
Gerrit-Change-Number: 79899
Gerrit-PatchSet: 2
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 09:00:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Appukuttan V K, Ashish Kumar Mishra, Bora Guvendik, Saurabh Mishra.
Hello Ashish Kumar Mishra, Bora Guvendik, Saurabh Mishra, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79900?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Ashish Kumar Mishra, Code-Review+1 by Saurabh Mishra, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/common: Add lunarlake device IDs
......................................................................
soc/intel/common: Add lunarlake device IDs
Added Lunar Lake device IDs the device specific functions
Reference:
Lunar Lake External Design Specification Volume 1 (734362)
Change-Id: Id31d567287b9921d60909b1eb617c7cfaf6672c9
Signed-off-by: Appukuttan V K <appukuttan.vk(a)intel.com>
---
M src/drivers/intel/ish/ish.c
M src/soc/intel/common/block/cpu/mp_init.c
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/dsp/dsp.c
M src/soc/intel/common/block/fast_spi/fast_spi.c
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/hda/hda.c
M src/soc/intel/common/block/i2c/i2c.c
M src/soc/intel/common/block/ipu/ipu.c
M src/soc/intel/common/block/lpc/lpc.c
M src/soc/intel/common/block/p2sb/p2sb.c
M src/soc/intel/common/block/pcie/pcie.c
M src/soc/intel/common/block/pmc/pmc.c
M src/soc/intel/common/block/smbus/smbus.c
M src/soc/intel/common/block/spi/spi.c
M src/soc/intel/common/block/sram/sram.c
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/common/block/usb4/usb4.c
M src/soc/intel/common/block/usb4/xhci.c
M src/soc/intel/common/block/xhci/xhci.c
21 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/79900/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79900?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id31d567287b9921d60909b1eb617c7cfaf6672c9
Gerrit-Change-Number: 79900
Gerrit-PatchSet: 3
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Tim Wawrzynczak.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80169?usp=email )
Change subject: device: Add inline method to identify PATH_ROOT
......................................................................
Patch Set 1:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/80169/comment/a035595f_396ebf1b :
PS1, Line 166: extern DEVTREE_CONST struct device dev_root;
> Would comparing pointers with this not be a better idea? I suppose the compiler might even be able t […]
I don't see how the compiler could optimize something. I'd expect is_root_device() to be never called directly on the root device itself as this is rather pointless check. For all other devices it shouldn't matter if the pointer or the actual type is read and compared.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59
Gerrit-Change-Number: 80169
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Patrick Rudolph, Shuo Liu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email )
Change subject: device/device_util: Add method to retrieve the domain
......................................................................
Patch Set 2:
(1 comment)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/80090/comment/56dabf50_2e9fa8a0 :
PS1, Line 267: while (dev->bus) {
> Done in CB:80169
Checking if it points to dev_root would also work.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80090?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748
Gerrit-Change-Number: 80090
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:48:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Lance Zhao, Patrick Rudolph, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80169?usp=email )
Change subject: device: Add inline method to identify PATH_ROOT
......................................................................
Patch Set 1:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/80169/comment/27e8e15b_7caaca6f :
PS1, Line 166: extern DEVTREE_CONST struct device dev_root;
Would comparing pointers with this not be a better idea? I suppose the compiler might even be able to optimize out some usecases that way?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59
Gerrit-Change-Number: 80169
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Appukuttan V K, Bora Guvendik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79900?usp=email )
Change subject: soc/intel/common: Add lunarlake device IDs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Adding CPU id is missed.
Could you add CPU ids in soc/intel/common/block/mp_init.c?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79900?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id31d567287b9921d60909b1eb617c7cfaf6672c9
Gerrit-Change-Number: 79900
Gerrit-PatchSet: 2
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Appukuttan V K, Bora Guvendik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79900?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: soc/intel/common: Add lunarlake device IDs
......................................................................
Patch Set 2: -Code-Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79900?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id31d567287b9921d60909b1eb617c7cfaf6672c9
Gerrit-Change-Number: 79900
Gerrit-PatchSet: 2
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:33:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment