Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80175?usp=email )
Change subject: mb/google/drallion: Use name 'LCD0' for internal panel output
......................................................................
mb/google/drallion: Use name 'LCD0' for internal panel output
The GMA driver generates the brightness controls expecting the name LCD0,
so we need to use it here as well so that the DSDT and SSDT parts match.
TEST=build/boot Win11 on google/drallion, verify brightness controls are
functional.
Change-Id: I6fbdd0c5606ec8f2c497e85bf46d388957f15fa5
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/drallion/variants/drallion/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/80175/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
index 950dab9..9fe0a69 100644
--- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb
+++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
@@ -223,7 +223,7 @@
register "gfx" = "GMA_DEFAULT_PANEL(0)"
chip drivers/gfx/generic
register "device_count" = "1"
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Address is set following the ACPI spec section A.3.2
# for an internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
--
To view, visit https://review.coreboot.org/c/coreboot/+/80175?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fbdd0c5606ec8f2c497e85bf46d388957f15fa5
Gerrit-Change-Number: 80175
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80174?usp=email )
Change subject: mb/google/brya/var/*: Use name 'LCD0' for internal panel output
......................................................................
mb/google/brya/var/*: Use name 'LCD0' for internal panel output
The GMA driver generates the brightness controls expecting the name LCD0,
so we need to use it here as well so that the DSDT and SSDT parts match.
TEST=build/boot Win11 on google/brya (redrix), verify brightness controls are
functional.
Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
M src/mainboard/google/brya/variants/banshee/overridetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/crota/overridetree.cb
M src/mainboard/google/brya/variants/dochi/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/marasov/overridetree.cb
M src/mainboard/google/brya/variants/mithrax/overridetree.cb
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
M src/mainboard/google/brya/variants/osiris/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/skolas/overridetree.cb
M src/mainboard/google/brya/variants/skolas4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
M src/mainboard/google/brya/variants/taniks/overridetree.cb
M src/mainboard/google/brya/variants/vell/overridetree.cb
M src/mainboard/google/brya/variants/volmar/overridetree.cb
25 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/80174/1
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb
index 1961e09..352a7d1 100644
--- a/src/mainboard/google/brya/variants/anahera/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb
@@ -89,7 +89,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -117,7 +117,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
index c7cce88..6973854 100644
--- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
@@ -71,7 +71,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -99,7 +99,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
index ca9c655..456bb2f 100644
--- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
@@ -199,7 +199,7 @@
chip drivers/gfx/generic
register "device_count" = "4"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/banshee/overridetree.cb b/src/mainboard/google/brya/variants/banshee/overridetree.cb
index 38c4528..6f66bce 100644
--- a/src/mainboard/google/brya/variants/banshee/overridetree.cb
+++ b/src/mainboard/google/brya/variants/banshee/overridetree.cb
@@ -98,7 +98,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb
index a4a0ae5..876e874 100644
--- a/src/mainboard/google/brya/variants/brya0/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb
@@ -122,7 +122,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb
index 8b671e1..69f78c1 100644
--- a/src/mainboard/google/brya/variants/crota/overridetree.cb
+++ b/src/mainboard/google/brya/variants/crota/overridetree.cb
@@ -111,7 +111,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/dochi/overridetree.cb b/src/mainboard/google/brya/variants/dochi/overridetree.cb
index 880b7bc..461a7ad 100644
--- a/src/mainboard/google/brya/variants/dochi/overridetree.cb
+++ b/src/mainboard/google/brya/variants/dochi/overridetree.cb
@@ -91,7 +91,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
index 74f2114..28e0974 100644
--- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb
+++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
@@ -97,7 +97,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb
index 0de70e5..ed8027d 100644
--- a/src/mainboard/google/brya/variants/gimble/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb
@@ -78,7 +78,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
index 6351248..881c1a1 100644
--- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
@@ -43,7 +43,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb
index cbce022..aeb8ef2 100644
--- a/src/mainboard/google/brya/variants/kano/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kano/overridetree.cb
@@ -100,7 +100,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb
index 64ca6a7..5a266dd 100644
--- a/src/mainboard/google/brya/variants/marasov/overridetree.cb
+++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb
@@ -145,7 +145,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/mithrax/overridetree.cb b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
index 6df9b60..55026ae 100644
--- a/src/mainboard/google/brya/variants/mithrax/overridetree.cb
+++ b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
@@ -95,7 +95,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
index 4a3d368..0ca36a7 100644
--- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb
+++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
@@ -130,7 +130,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb
index 0c21a61..72981cf 100644
--- a/src/mainboard/google/brya/variants/osiris/overridetree.cb
+++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb
@@ -74,7 +74,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb
index d815587..7dde42f 100644
--- a/src/mainboard/google/brya/variants/primus/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus/overridetree.cb
@@ -86,7 +86,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index f8502aa..1fe1682 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -104,7 +104,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -132,7 +132,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
index 6e00215..b68dec2 100644
--- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
@@ -85,7 +85,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -113,7 +113,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb
index 3f17008..e3879bc 100644
--- a/src/mainboard/google/brya/variants/skolas/overridetree.cb
+++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb
@@ -121,7 +121,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
index 326c675..7826ea8 100644
--- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
@@ -116,7 +116,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb
index 27584cd..d6ffb7f 100644
--- a/src/mainboard/google/brya/variants/taeko/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb
@@ -141,7 +141,7 @@
chip drivers/gfx/generic
register "device_count" = "3"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
index 22b3ca7..753e7ba 100644
--- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
@@ -122,7 +122,7 @@
chip drivers/gfx/generic
register "device_count" = "3"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb
index 1e0101a..a2d9512 100644
--- a/src/mainboard/google/brya/variants/taniks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb
@@ -118,7 +118,7 @@
chip drivers/gfx/generic
register "device_count" = "3"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb
index 6956312..459f782 100644
--- a/src/mainboard/google/brya/variants/vell/overridetree.cb
+++ b/src/mainboard/google/brya/variants/vell/overridetree.cb
@@ -97,7 +97,7 @@
chip drivers/gfx/generic
register "device_count" = "5"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/volmar/overridetree.cb b/src/mainboard/google/brya/variants/volmar/overridetree.cb
index 1de6626..ef2da0a 100644
--- a/src/mainboard/google/brya/variants/volmar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/volmar/overridetree.cb
@@ -92,7 +92,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
--
To view, visit https://review.coreboot.org/c/coreboot/+/80174?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Gerrit-Change-Number: 80174
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newchange
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80061?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: drivers/generic/gfx: Generate Intel ACPI backlight controls for LCD device
......................................................................
drivers/generic/gfx: Generate Intel ACPI backlight controls for LCD device
Normally this would be done by the Intel GMA driver, but we can't have
two copies of the _DOD method, so generate the LCD backlight controls
here to allow use of this driver instead of the default GMA panel
defintion.
TEST=build/boot Win11 on google/byra (redrix), ensure ACPI brightness
controls functional.
Change-Id: Ic8fbaf7550405f8c6f36012c8efadb8c36b968c2
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/drivers/gfx/generic/generic.c
1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/80061/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80061?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fbaf7550405f8c6f36012c8efadb8c36b968c2
Gerrit-Change-Number: 80061
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80062?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
mb/google/brya/var/*: Ensure LCD device has a valid address
Some variants added the generic gfx driver with an LCD device without
specifying the address, which is required for the backlight controls
to be functional under Windows. Add the address value where missing.
Address value used (0x80010400) is same as on other Brya variants which
did properly set it, and is taken from the ACPI 6.5 spec section B.4.2,
_DOD (display output device enumeration), table B-2:
- bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits
15-0
- bit 16 = platform firmware can detect the device
- bit 10 = display type is internal/integrated flat panel (aka LCD)
TEST=build/boot Win11 on google/brya (osiris), verify ACPI backlight
controls functional.
Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
M src/mainboard/google/brya/variants/banshee/overridetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/crota/overridetree.cb
M src/mainboard/google/brya/variants/dochi/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/marasov/overridetree.cb
M src/mainboard/google/brya/variants/mithrax/overridetree.cb
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
M src/mainboard/google/brya/variants/osiris/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/skolas/overridetree.cb
M src/mainboard/google/brya/variants/skolas4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
M src/mainboard/google/brya/variants/taniks/overridetree.cb
M src/mainboard/google/brya/variants/vell/overridetree.cb
M src/mainboard/google/brya/variants/volmar/overridetree.cb
25 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/80062/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80060?usp=email )
Change subject: soc/intel/common/gfx: Only generate a single SSDT entry for the GPU
......................................................................
Abandoned
will handle at board level
--
To view, visit https://review.coreboot.org/c/coreboot/+/80060?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If04d1df102c50b561911d7f842ad37b2dd3c6857
Gerrit-Change-Number: 80060
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Singer, Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80167?usp=email )
Change subject: soc/intel/cannonlake: Report correct latencies for C states
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
> I don't know, but it is what we write into the registers […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie01a53d6f06bc02a53d95e390e16e9963f4c65ee
Gerrit-Change-Number: 80167
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 23 Jan 2024 14:24:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80168?usp=email )
Change subject: superio/ite/env_ctrl: Allow to override the fan PWM clock
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/80168/comment/5401a6a0_2e6bd010 :
PS1, Line 134: conf->fan_pwm_clock & 1
Missing parentheses.
File src/superio/ite/common/env_ctrl_chip.h:
https://review.coreboot.org/c/coreboot/+/80168/comment/e80a20f5_b17233b3 :
PS1, Line 72: /* bit 0 is used to mark non-default values */
What I did so leaving it unset in the dt results in the default. That's
worth mentioning in the commit message, otherwise the patch looks a bit
confusing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80168?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5c43aec792195df835d1c39c9c25233899ba1a85
Gerrit-Change-Number: 80168
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Tue, 23 Jan 2024 13:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Matt DeVillier.
Nico Huber has uploaded a new patch set (#2) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/80167?usp=email )
Change subject: soc/intel/cannonlake: Report correct latencies for C states
......................................................................
soc/intel/cannonlake: Report correct latencies for C states
The C_STATE_LATENCY_FROM_LAT_REG() macro uses values that we also
write into the respective MSRs in configure_c_states(). Match the
indices to those used there.
Change-Id: Ie01a53d6f06bc02a53d95e390e16e9963f4c65ee
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/soc/intel/cannonlake/acpi.c
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/80167/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie01a53d6f06bc02a53d95e390e16e9963f4c65ee
Gerrit-Change-Number: 80167
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80167?usp=email )
Change subject: soc/intel/cannonlake: Report correct latencies for C states
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> what's the source for the corrected values?
I don't know, but it is what we write into the registers
(cannonlake/cpu.c:configure_c_states()). Funny thing: the
comments there provide better names for the indices. I
have no idea why we do this weird dance with these odd
macros... I'll update the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie01a53d6f06bc02a53d95e390e16e9963f4c65ee
Gerrit-Change-Number: 80167
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 12:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment