coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[S] Change in coreboot[main]: ec/dell/mec5035: Add command to control radio state
by Felix Held (Code Review) 24 Jan '24

24 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email ) Change subject: ec/dell/mec5035: Add command to control radio state ...................................................................... ec/dell/mec5035: Add command to control radio state This was determined by sniffing the LPC bus while moving the hardware wireless switch between the enabled and disabled positions on the Latitude E6400. The vendor BIOS provides options to change which radios the switch controls, which was used to determine the mapping between each radio device and the command argument values. Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77534 Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M src/ec/dell/mec5035/mec5035.c M src/ec/dell/mec5035/mec5035.h 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/ec/dell/mec5035/mec5035.c b/src/ec/dell/mec5035/mec5035.c index 8da11e5..41b8dca 100644 --- a/src/ec/dell/mec5035/mec5035.c +++ b/src/ec/dell/mec5035/mec5035.c @@ -84,6 +84,15 @@ return buf[0]; } +void mec5035_control_radio(enum ec_radio_dev dev, enum ec_radio_state state) +{ + /* From LPC traces and userspace testing with other values, + the second byte has to be 2 for an unknown reason. */ + u8 buf[RADIO_CTRL_NUM_ARGS] = {(u8)dev, 2, (u8)state}; + write_mailbox_regs(buf, 2, RADIO_CTRL_NUM_ARGS); + ec_command(CMD_RADIO_CTRL); +} + void mec5035_early_init(void) { /* If this isn't sent the EC shuts down the system after about 15 diff --git a/src/ec/dell/mec5035/mec5035.h b/src/ec/dell/mec5035/mec5035.h index e7a05b6..fa15a9d 100644 --- a/src/ec/dell/mec5035/mec5035.h +++ b/src/ec/dell/mec5035/mec5035.h @@ -16,8 +16,22 @@ #define CMD_CPU_OK 0xc2 +#define CMD_RADIO_CTRL 0x2b +#define RADIO_CTRL_NUM_ARGS 3 +enum ec_radio_dev { + RADIO_WLAN = 0, + RADIO_WWAN, + RADIO_BT +}; + +enum ec_radio_state { + RADIO_OFF = 0, + RADIO_ON +}; + u8 mec5035_mouse_touchpad(u8 setting); void mec5035_cpu_ok(void); void mec5035_early_init(void); +void mec5035_control_radio(enum ec_radio_dev device, enum ec_radio_state state); #endif /* _EC_DELL_MEC5035_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/77534?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b Gerrit-Change-Number: 77534 Gerrit-PatchSet: 11 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: soc/amd/genoa_poc: rely less on boot state hooks
by Marshall Dawson (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79985?usp=email ) Change subject: soc/amd/genoa_poc: rely less on boot state hooks ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79985?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic752635da5eaa9e333cfb927836f0d260d2ac049 Gerrit-Change-Number: 79985 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 20:39:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vc/amd/opensil/genoa_poc: move configure_mpio call to setup_opensil
by Marshall Dawson (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80148?usp=email ) Change subject: vc/amd/opensil/genoa_poc: move configure_mpio call to setup_opensil ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80148/comment/279292f2_3d270391 : PS1, Line 13: call nit: called File src/vendorcode/amd/opensil/genoa_poc/opensil.h: https://review.coreboot.org/c/coreboot/+/80148/comment/00d227d1_1dc60b83 : PS1, Line 14: configure_mpio Does this eventually get moved somewhere common? -- To view, visit https://review.coreboot.org/c/coreboot/+/80148?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If37077c879e266763fd2748a1a8d71c63c94729b Gerrit-Change-Number: 80148 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 20:39:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: rename mpio_config to configure_mpio
by Marshall Dawson (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80147?usp=email ) Change subject: vc/amd/opensil/genoa_poc/mpio: rename mpio_config to configure_mpio ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4b1aa6e964cbbb4affb89cacd33af8b24871bb6 Gerrit-Change-Number: 80147 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 20:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: TEST only
by Ravishankar Sarawadi (Code Review) 23 Jan '24

23 Jan '24

Ravishankar Sarawadi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80151?usp=email ) Change subject: TEST only ...................................................................... Abandoned NA -- To view, visit https://review.coreboot.org/c/coreboot/+/80151?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia60f66ed37d959ae62903123edf0c3e1e29496fd Gerrit-Change-Number: 80151 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: TEST only
by Ravishankar Sarawadi (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Ravishankar Sarawadi. Hello Ravishankar Sarawadi, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/80151?usp=email to review the following change. Change subject: TEST only ...................................................................... TEST only Change-Id: Ia60f66ed37d959ae62903123edf0c3e1e29496fd Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> --- M src/mainboard/google/rex/variants/rex0/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/80151/1 diff --git a/src/mainboard/google/rex/variants/rex0/gpio.c b/src/mainboard/google/rex/variants/rex0/gpio.c index 184c4d2..799d0b4 100644 --- a/src/mainboard/google/rex/variants/rex0/gpio.c +++ b/src/mainboard/google/rex/variants/rex0/gpio.c @@ -98,7 +98,7 @@ /* GPP_B21 : [] ==> SOC_I2C_MISC_SCL */ PAD_CFG_NF_LOCK(GPP_B21, NONE, NF2, LOCK_CONFIG), /* GPP_B22 : [] ==> USB4_RT_FORCE_PWR */ - PAD_CFG_GPO(GPP_B22, 0, DEEP), + PAD_CFG_GPO(GPP_B22, 1, DEEP), /* GPP_B23 : [] ==> WWAN_CONFIG0 */ PAD_CFG_GPI_LOCK(GPP_B23, NONE, LOCK_CONFIG), -- To view, visit https://review.coreboot.org/c/coreboot/+/80151?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia60f66ed37d959ae62903123edf0c3e1e29496fd Gerrit-Change-Number: 80151 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: drivers/uart/pl011: Enhance struct documentation
by Maximilian Brune (Code Review) 23 Jan '24

23 Jan '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80180?usp=email ) Change subject: drivers/uart/pl011: Enhance struct documentation ...................................................................... drivers/uart/pl011: Enhance struct documentation Source: PrimeCell UART (PL011) Technical Reference Manual Revision: r1p5 Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I58409b23e3790a052d3bc0ecf6a6bede15b4d76f --- M src/drivers/uart/pl011.h 1 file changed, 25 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/80180/1 diff --git a/src/drivers/uart/pl011.h b/src/drivers/uart/pl011.h index 1f5f0f7..4b6393d 100644 --- a/src/drivers/uart/pl011.h +++ b/src/drivers/uart/pl011.h @@ -7,31 +7,31 @@ /* PL011 r1p5 registers */ struct pl011_uart { - u32 dr; - u32 rsr_ecr; - u8 rsvd1[0x10]; - u32 fr; - u8 rsvd2[0x4]; - u32 ilpr; - u32 ibrd; - u32 fbrd; - u32 lcr_h; - u32 cr; - u32 ifls; - u32 imsc; - u32 ris; - u32 mis; - u32 icr; - u32 dmacr; - u8 rsvd3[0xf94]; - u32 periphid0; - u32 periphid1; - u32 periphid2; - u32 periphid3; - u32 cellid0; - u32 cellid1; - u32 cellid2; - u32 cellid3; + u32 dr; // offset: 0x0 Data Register + u32 rsr_ecr; // offset: 0x4 Receive Status Register / Error Clear Register + u8 rsvd1[0x10]; // offset: 0x8 Reserved + u32 fr; // offset: 0x18 Flag Register + u8 rsvd2[0x4]; // offset: 0x1C Reserved + u32 ilpr; // offset: 0x20 Low-Power Counter Register + u32 ibrd; // offset: 0x24 Integer Baud Rate Register + u32 fbrd; // offset: 0x28 Fractional Baud Rate Register + u32 lcr_h; // offset: 0x2C Line Control Register + u32 cr; // offset: 0x30 Control Register + u32 ifls; // offset: 0x34 Interrupt FIFO Level Select Register + u32 imsc; // offset: 0x38 Interrupt Mask Set/Clear Register + u32 ris; // offset: 0x3C Raw Interrupt Status Register + u32 mis; // offset: 0x40 Masked Interrupt status Register + u32 icr; // offset: 0x44 Interrupt Clear Register + u32 dmacr; // offset: 0x48 DMA Control Register + u8 rsvd3[0xf94]; // offset: 0x4C Reserved + u32 periphid0; // offset: 0xFE0 UART PeriphID0 Register + u32 periphid1; // offset: 0xFE4 UART PeriphID1 Register + u32 periphid2; // offset: 0xFE8 UART PeriphID2 Register + u32 periphid3; // offset: 0xFEC UART PeriphID3 Register + u32 cellid0; // offset: 0xFF0 UART CellID0 Register + u32 cellid1; // offset: 0xFF4 UART CellID1 Register + u32 cellid2; // offset: 0xFF8 UART CellID2 Register + u32 cellid3; // offset: 0xFFC UART CellID3 Register }; check_member(pl011_uart, cellid3, 0xffc); -- To view, visit https://review.coreboot.org/c/coreboot/+/80180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I58409b23e3790a052d3bc0ecf6a6bede15b4d76f Gerrit-Change-Number: 80180 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[main]: soc/intel/xeon_sp: Drop 1st Gen Xeon-SP
by Marc Jones (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jérémy Compostella, Patrick Rudolph, Tim Chu. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80172?usp=email ) Change subject: soc/intel/xeon_sp: Drop 1st Gen Xeon-SP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80172?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I12b092f00386cb71fac02d8d0b10375d3241abb3 Gerrit-Change-Number: 80172 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 23 Jan 2024 17:06:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/ocp: Drop tiogapass
by Marc Jones (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Morgan Jang, Patrick Rudolph, Shuo Liu. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80171?usp=email ) Change subject: mb/ocp: Drop tiogapass ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80171?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I838b9ea3955d31ea393494c2e726845fe234ef3a Gerrit-Change-Number: 80171 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Tue, 23 Jan 2024 17:06:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/rex: Set TCC to 100°C
by Peter Ou (Code Review) 23 Jan '24

23 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun, yunhao wang. Peter Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79992?usp=email ) Change subject: mb/google/rex/var/rex: Set TCC to 100°C ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9012984016ab3213102214025d6d8dc07c5d8974 Gerrit-Change-Number: 79992 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yunhao wang <wangyunhao(a)huaqin.corp-partner.google.com> Gerrit-Attention: yunhao wang <wangyunhao(a)huaqin.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 23 Jan 2024 16:14:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024