Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80221?usp=email )
Change subject: soc/amd/*/acpi: use common soc_acpi_write_tables prototype
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80221?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9aa215f2b4ba58f43fed2c751d989f1719e0a17
Gerrit-Change-Number: 80221
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 26 Jan 2024 20:30:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Matt DeVillier, Nico Huber.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80190?usp=email )
Change subject: soc/amd/stoney: Match ACPI with resource allocation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80190?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32d08ffd5bbd856b17f7ca2775c5923957d92c85
Gerrit-Change-Number: 80190
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 26 Jan 2024 20:17:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80125?usp=email )
Change subject: src, util: Clean up makefile.inc in text, help & comments
......................................................................
src, util: Clean up makefile.inc in text, help & comments
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80125
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/Kconfig
M src/mainboard/cavium/cn8100_sff_evb/board.fmd
M src/mainboard/google/glados/variants/asuka/variant.c
M src/mainboard/google/nyan_big/bct/Makefile.mk
M src/mainboard/google/nyan_blaze/bct/Makefile.mk
M src/mainboard/intel/strago/Kconfig
M src/mainboard/opencellular/elgon/board.fmd
M src/mainboard/opencellular/elgon/vboot.fmd
M src/mainboard/protectli/vault_bsw/Kconfig
M src/mainboard/siemens/mc_apl1/Makefile.mk
M src/sbom/Makefile.mk
M util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
M util/scripts/rm_unused_code
13 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Felix Singer: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig
index 21c50c5..2bcc3ce 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1492,7 +1492,7 @@
This variable allows SoC/mainboard to supply in a custom linker file
if required. This determines the linker file used for all the stages
(bootblock, romstage, verstage, ramstage, postcar) in
- src/arch/${ARCH}/Makefile.inc.
+ src/arch/${ARCH}/Makefile.mk.
###############################################################################
# Set default values for symbols created before mainboards. This allows the
diff --git a/src/mainboard/cavium/cn8100_sff_evb/board.fmd b/src/mainboard/cavium/cn8100_sff_evb/board.fmd
index 34f3161..011d070 100644
--- a/src/mainboard/cavium/cn8100_sff_evb/board.fmd
+++ b/src/mainboard/cavium/cn8100_sff_evb/board.fmd
@@ -6,7 +6,7 @@
FMAP@0x0 0x1000
# bootblock includes trusted/non-trusted CLIB, CSIB,
# and BL1FWs packaged in
- # src/soc/cavium/common/Makefile.inc.
+ # src/soc/cavium/common/Makefile.mk.
BOOTBLOCK@0x10000 0x70000
COREBOOT(CBFS)@0x80000 0x77c000
}
diff --git a/src/mainboard/google/glados/variants/asuka/variant.c b/src/mainboard/google/glados/variants/asuka/variant.c
index 68392fe..2dca9b0 100644
--- a/src/mainboard/google/glados/variants/asuka/variant.c
+++ b/src/mainboard/google/glados/variants/asuka/variant.c
@@ -38,6 +38,6 @@
int is_dual_channel(const int spd_index)
{
- /* Per Makefile.inc, dual channel indices 1,3,5 */
+ /* Per Makefile.mk, dual channel indices 1,3,5 */
return (spd_index & 0x1);
}
diff --git a/src/mainboard/google/nyan_big/bct/Makefile.mk b/src/mainboard/google/nyan_big/bct/Makefile.mk
index f83c932..9f65647 100644
--- a/src/mainboard/google/nyan_big/bct/Makefile.mk
+++ b/src/mainboard/google/nyan_big/bct/Makefile.mk
@@ -5,5 +5,5 @@
bct-cfg-y += odmdata.cfg
# Note when SDRAM config (sdram-*.cfg) files are changed, we have to regenerate
-# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.inc for more
+# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.mk for more
# information.
diff --git a/src/mainboard/google/nyan_blaze/bct/Makefile.mk b/src/mainboard/google/nyan_blaze/bct/Makefile.mk
index 02f32a59..86fcfc4 100644
--- a/src/mainboard/google/nyan_blaze/bct/Makefile.mk
+++ b/src/mainboard/google/nyan_blaze/bct/Makefile.mk
@@ -5,5 +5,5 @@
bct-cfg-y += odmdata.cfg
# Note when SDRAM config (sdram-*.cfg) files are changed, we have to regenerate
-# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.inc for more
+# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.mk for more
# information.
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index 5cd7880..ce56cc6 100644
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -35,7 +35,7 @@
default "8086,22b0"
help
The VGA_BIOS_ID for the C0 version of the video BIOS is hardcoded
- in soc/intel/braswell/Makefile.inc as 8086,22b1
+ in soc/intel/braswell/Makefile.mk as 8086,22b1
config CBFS_SIZE
default 0x200000
diff --git a/src/mainboard/opencellular/elgon/board.fmd b/src/mainboard/opencellular/elgon/board.fmd
index 784f3b0..222490c 100644
--- a/src/mainboard/opencellular/elgon/board.fmd
+++ b/src/mainboard/opencellular/elgon/board.fmd
@@ -6,7 +6,7 @@
FMAP@0x0 0x1000
# bootblock includes trusted/non-trusted CLIB, CSIB,
# and BL1FWs packaged in
- # src/soc/cavium/common/Makefile.inc.
+ # src/soc/cavium/common/Makefile.mk.
BOOTBLOCK@0x10000 0x70000
COREBOOT(CBFS)@0x80000 0xf7c000
}
diff --git a/src/mainboard/opencellular/elgon/vboot.fmd b/src/mainboard/opencellular/elgon/vboot.fmd
index 0d6af2d..77ef10d 100644
--- a/src/mainboard/opencellular/elgon/vboot.fmd
+++ b/src/mainboard/opencellular/elgon/vboot.fmd
@@ -8,7 +8,7 @@
RO_FRID@0x1000 0x100
# bootblock includes trusted/non-trusted CLIB, CSIB,
# and BL1FWs packaged in
- # src/soc/cavium/common/Makefile.inc.
+ # src/soc/cavium/common/Makefile.mk.
BOOTBLOCK@0x10000 0x70000
COREBOOT(CBFS)@0x80000 0x2fc000
GBB@0x37c000 0x80000
diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig
index e169392..63fc710 100644
--- a/src/mainboard/protectli/vault_bsw/Kconfig
+++ b/src/mainboard/protectli/vault_bsw/Kconfig
@@ -57,7 +57,7 @@
default "8086,22b0"
help
The VGA_BIOS_ID for the C0 version of the video bios is hardcoded
- in soc/intel/braswell/Makefile.inc as 8086,22b1
+ in soc/intel/braswell/Makefile.mk as 8086,22b1
endif #RUN_FSP_GOP
diff --git a/src/mainboard/siemens/mc_apl1/Makefile.mk b/src/mainboard/siemens/mc_apl1/Makefile.mk
index e179201..37b6c74 100644
--- a/src/mainboard/siemens/mc_apl1/Makefile.mk
+++ b/src/mainboard/siemens/mc_apl1/Makefile.mk
@@ -4,7 +4,7 @@
# The inclusion of romstage.c is not necessary here.
# It is put down only to the better understanding.
-# The file is already included over src/arch/x86/Makefile.inc.
+# The file is already included over src/arch/x86/Makefile.mk.
romstage-y += romstage.c
ramstage-y += mainboard.c
diff --git a/src/sbom/Makefile.mk b/src/sbom/Makefile.mk
index 7783f09..4e3adc2 100644
--- a/src/sbom/Makefile.mk
+++ b/src/sbom/Makefile.mk
@@ -65,7 +65,7 @@
vboot-pkgconfig-files = $(obj)/external/vboot_reference-bootblock/vboot_host.pc $(obj)/external/vboot_reference-romstage/vboot_host.pc $(obj)/external/vboot_reference-ramstage/vboot_host.pc $(obj)/external/vboot_reference-postcar/vboot_host.pc
swid-files-$(CONFIG_SBOM_VBOOT) += $(vboot-pkgconfig-files)
-$(vboot-pkgconfig-files): $(VBOOT_LIB_bootblock) $(VBOOT_LIB_romstage) $(VBOOT_LIB_ramstage) $(VBOOT_LIB_postcar) # src/security/vboot/Makefile.inc
+$(vboot-pkgconfig-files): $(VBOOT_LIB_bootblock) $(VBOOT_LIB_romstage) $(VBOOT_LIB_ramstage) $(VBOOT_LIB_postcar) # src/security/vboot/Makefile.mk
ifeq ($(CONFIG_SBOM_COMPILER),y)
compiler-toolchain = $(CC_bootblock) $(CC_romstage) $(CC_ramstage) $(CC_postcar) $(CC_verstage) $(LD_bootblock) $(LD_romstage) $(LD_ramstage) $(LD_postcar) $(LD_verstage) $(AS_bootblock) $(AS_romstage) $(AS_ramstage) $(AS_postcar) $(AS_verstage)
diff --git a/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch b/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
index 688b387..b476bc1 100644
--- a/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
+++ b/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
@@ -8,7 +8,7 @@
makes automatic inclusion of all boards a tedious task
and prevents us from implementing "drop in" boards.
-In our Makefile.inc files we already include mainboard
+In our Makefile.mk files we already include mainboard
directories per wildcard, so let's add the infrastructure
to do the same with Kconfig.
@@ -28,7 +28,7 @@
+++ kconfig/lexer.l
@@ -8,6 +8,7 @@
%{
-
+
#include <assert.h>
+#include <glob.h>
#include <limits.h>
@@ -37,7 +37,7 @@
@@ -439,6 +440,32 @@ void zconf_nextfile(const char *name)
current_file = file;
}
-
+
+void zconf_nextfiles(const char *wildcard)
+{
+ glob_t g;
@@ -78,7 +78,7 @@
+void zconf_nextfiles(const char *name);
int zconf_lineno(void);
const char *zconf_curname(void);
-
+
Index: kconfig/parser.y
===================================================================
--- kconfig.orig/parser.y
@@ -91,4 +91,4 @@
+ zconf_nextfiles($2);
free($2);
};
-
+
diff --git a/util/scripts/rm_unused_code b/util/scripts/rm_unused_code
index 53c0b65..d4b42b6 100755
--- a/util/scripts/rm_unused_code
+++ b/util/scripts/rm_unused_code
@@ -259,7 +259,7 @@
remove_unused() {
local dir
# Most files can be removed simply by looking at the time, but
- # all Kconfig and Makefile.inc files in the entire tree are accessed
+ # all Kconfig and Makefiles in the entire tree are accessed
# whether they're used or not.
remove_kconfigs
--
To view, visit https://review.coreboot.org/c/coreboot/+/80125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
Gerrit-Change-Number: 80125
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Christian Walter, Felix Singer, Martin L Roth, Michał Żygowski, Patrick Rudolph, Piotr Król, Werner Zeh.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80125?usp=email )
Change subject: src, util: Clean up makefile.inc in text, help & comments
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
Gerrit-Change-Number: 80125
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 20:15:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Felix Singer, Martin L Roth, Michał Żygowski, Patrick Rudolph, Piotr Król, Werner Zeh.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80125?usp=email )
Change subject: src, util: Clean up makefile.inc in text, help & comments
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> I don't think it changes behavior. I ran make ncurses to confirm. Still works.
thanks for verifying
--
To view, visit https://review.coreboot.org/c/coreboot/+/80125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
Gerrit-Change-Number: 80125
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 20:14:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79950?usp=email )
Change subject: payloads/Kconfig: Make flat-binary configurable
......................................................................
payloads/Kconfig: Make flat-binary configurable
This adds the ability to add a flat-binary using menuconfig.
Test: boot hifive-unmatched mainboard with the following config:
CONFIG_PAYLOAD_NONE=n
CONFIG_PAYLOAD_ELF=y
CONFIG_PAYLOAD_FILE="~/repos/linux-riscv/arch/riscv/boot/Image"
CONFIG_PAYLOAD_IS_FLAT_BINARY=y
CONFIG_PAYLOAD_OPTIONS="-l 0x82000000 -e 0x82000000"
CONFIG_COMPRESSED_PAYLOAD_LZMA=y
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I48c6b53a0c9f5b173c89f1a294a0c37fa1a58f31
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79950
Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M payloads/Kconfig
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Lean Sheng Tan: Looks good to me, approved
diff --git a/payloads/Kconfig b/payloads/Kconfig
index 2a2773a..9304629 100644
--- a/payloads/Kconfig
+++ b/payloads/Kconfig
@@ -80,13 +80,14 @@
endchoice
config PAYLOAD_OPTIONS
- string
+ string "Additional cbfstool options"
default ""
help
Additional cbfstool options for the payload
config PAYLOAD_IS_FLAT_BINARY
- def_bool n
+ bool "Payload is a flat binary"
+ default n
help
Add the payload to cbfs as a flat binary type instead of as an
elf payload
--
To view, visit https://review.coreboot.org/c/coreboot/+/79950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I48c6b53a0c9f5b173c89f1a294a0c37fa1a58f31
Gerrit-Change-Number: 79950
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80226?usp=email )
Change subject: malloc/memalign: Return NULL if the request is too large
......................................................................
malloc/memalign: Return NULL if the request is too large
It's what this function family is defined to do, we currently don't
usually run into the case (see: not too many die() instances going
around), it's more useful to try to recover, and the JPEG parser can run
into it if the work buffer size exceeds the remaining heap, whereas its
sole user (the bootsplash code) knows what to do when seeing a NULL.
tl;dr: That code path isn't usually taken. Right now it crashes. With
this patch it _might_ survive. There is a use-case for doing it like
that now.
Change-Id: I262fbad7daae0ca3aab583fda00665a2592deaa8
Signed-off-by: Patrick Georgi <patrick(a)coreboot.org>
---
M src/lib/malloc.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/80226/1
diff --git a/src/lib/malloc.c b/src/lib/malloc.c
index 052a53e..3029806 100644
--- a/src/lib/malloc.c
+++ b/src/lib/malloc.c
@@ -44,7 +44,10 @@
p, free_mem_ptr);
printk(BIOS_ERR, "but free_mem_end_ptr is %p\n",
free_mem_end_ptr);
- die("Error! %s: Out of memory (free_mem_ptr >= free_mem_end_ptr)", __func__);
+ printk(BIOS_ERR, "Error! %s: Out of memory "
+ "(free_mem_ptr >= free_mem_end_ptr)",
+ __func__);
+ return NULL;
}
MALLOCDBG("%s %p\n", __func__, p);
--
To view, visit https://review.coreboot.org/c/coreboot/+/80226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I262fbad7daae0ca3aab583fda00665a2592deaa8
Gerrit-Change-Number: 80226
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Chen, Gang C, Fred Reitberger, Jason Glenesk, Jincheng Li, Jérémy Compostella, Martin L Roth, Matt DeVillier, Nico Huber.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78328?usp=email )
Change subject: device/device.h: Drop multiple links
......................................................................
Patch Set 17: Code-Review+1
(1 comment)
Patchset:
PS13:
> > the first test was with edk2 payload; using linux + seabios resulted in a more helpful error; ther […]
tested patchset 17 and it now works as intended :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/78328?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iab6fe269faef46ae77ed1ea425440cf5c7dbd49b
Gerrit-Change-Number: 78328
Gerrit-PatchSet: 17
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 19:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Patrick Rudolph, Shuo Liu, Tim Chu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80210?usp=email )
Change subject: device: Add a helper function to add a downstream bus
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
> looks good to me, but i want to run a test on hardware before giving a +2
ubuntu still boots on mandolin
--
To view, visit https://review.coreboot.org/c/coreboot/+/80210?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic898189b92997b93304fcbf47c73e2bb5ec09023
Gerrit-Change-Number: 80210
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 18:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment