Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Patrick Rudolph, Shuo Liu, Tim Chu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80210?usp=email )
Change subject: device: Add a helper function to add a downstream bus
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
looks good to me, but i want to run a test on hardware before giving a +2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80210?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic898189b92997b93304fcbf47c73e2bb5ec09023
Gerrit-Change-Number: 80210
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80141?usp=email )
Change subject: mb/google/puff: Drop devicetree entries identical to chipset.cb
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80141/comment/526e96f7_d6853974 :
PS1, Line 7: Baseboard devicetree clean up #1
> Maybe something like: […]
Done
File src/mainboard/google/puff/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80141/comment/cac31065_7599031f :
PS1, Line 321: device ref p2sb on end
> AFAIK P2SB is hidden by the FSP, that's why we set it in chipset. […]
since it's not a strict deduplication, will do in a follow-on patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80141?usp=email )
Change subject: mb/google/puff: Drop devicetree entries identical to chipset.cb
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/google/puff/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80141/comment/1ce4c327_dd5770c1 :
PS1, Line 321: device ref p2sb on end
> AFAIK P2SB is hidden by the FSP, that's why we set it in chipset. […]
not a strict deduplication, let's do it in a separate patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80141?usp=email
to look at the new patch set (#2).
Change subject: mb/google/puff: Drop devicetree entries identical to chipset.cb
......................................................................
mb/google/puff: Drop devicetree entries identical to chipset.cb
Now that puff uses chipset devicetree references, remove all references
whose value is identical to the chipset devicetree default, since
they are pointless clutter.
TEST=tested with rest of patch train
Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/puff/variants/baseboard/devicetree.cb
1 file changed, 21 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/80141/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newpatchset
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80142?usp=email )
Change subject: mb/google/puff: Delegate I2C device configuration to overridetree
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80142/comment/ed352af2_70bc8627 :
PS1, Line 7: Baseboard devicetree clean up #2
> Maybe: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80142?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9c67a8e05923a080e31d04721ecae4c810e82e8
Gerrit-Change-Number: 80142
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80142?usp=email
to look at the new patch set (#2).
Change subject: mb/google/puff: Delegate I2C device configuration to overridetree
......................................................................
mb/google/puff: Delegate I2C device configuration to overridetree
Don't enable the i2c controllers, since the variants will enable the
ones they need individually in their overrridetrees.
Disable gspi1 since all variants disable it in their overridetrees.
TEST=tested with rest of patch train
Change-Id: Ia9c67a8e05923a080e31d04721ecae4c810e82e8
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/puff/variants/baseboard/devicetree.cb
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/80142/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80142?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9c67a8e05923a080e31d04721ecae4c810e82e8
Gerrit-Change-Number: 80142
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80142?usp=email )
Change subject: mb/google/puff: Baseboard devicetree clean up #2
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80142/comment/31b3adf9_783af6a0 :
PS1, Line 7: Baseboard devicetree clean up #2
Maybe:
Delegate I2C device configuration to overridetree
--
To view, visit https://review.coreboot.org/c/coreboot/+/80142?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9c67a8e05923a080e31d04721ecae4c810e82e8
Gerrit-Change-Number: 80142
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:20:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80141?usp=email )
Change subject: mb/google/puff: Baseboard devicetree clean up #1
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80141/comment/e134d435_126919f5 :
PS1, Line 7: Baseboard devicetree clean up #1
Maybe something like:
Drop dt entries that are equivalent to chipset.cb
--
To view, visit https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80141?usp=email )
Change subject: mb/google/puff: Baseboard devicetree clean up #1
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:14:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80141?usp=email )
Change subject: mb/google/puff: Baseboard devicetree clean up #1
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/puff/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80141/comment/01c1877f_29b8b266 :
PS1, Line 321: device ref p2sb on end
AFAIK P2SB is hidden by the FSP, that's why we set it in chipset.cb
--
To view, visit https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment