coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[M] Change in coreboot[main]: Choose Correct FW splash screen at runtime
by Subrata Banik (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen, Subrata Banik. Subrata Banik has uploaded a new patch set (#8) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: Choose Correct FW splash screen at runtime ...................................................................... Choose Correct FW splash screen at runtime This CL uses the factory config that is retrieved by the TPM in order to determine if the device is a chromebook or a chromebook plus device at runtime. From this it will dynamically choose the correct FW splash screen to display at boot time. This CL also introduces three new Kconfigs: CHROMEOS_FW_SPLASH_SCREEN CB_LOGO_PATH CB_PLUS_LOGO_PATH which allow users to enable the fw splash screen feature in the vendorcode. Previously, we were using the BMP_LOGO Kconfig in drivers/intel/fsp2_0, but we didn't want the top level Kconfigs to be located inside the architecture specific files. BUG=b:317880956 BRANCH=None TEST=emerge-rex coreboot chromeos-bootimage verify that FW splash screen appears Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/drivers/intel/fsp2_0/Makefile.inc M src/include/bootsplash.h M src/lib/Kconfig M src/lib/bmp_logo.c M src/vendorcode/google/chromeos/Kconfig M src/vendorcode/google/chromeos/Makefile.inc A src/vendorcode/google/chromeos/splash.c 7 files changed, 68 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/79775/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Gerrit-Change-Number: 79775 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/brox: Fix error in DDR DQS config
by Subrata Banik (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Nick Vaccaro, Shelley Chen. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79843?usp=email ) Change subject: mb/google/brox: Fix error in DDR DQS config ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > need minor correction at commit msg Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I21f50e2f5b4fae09725c1c7532636ed1cc1a9043 Gerrit-Change-Number: 79843 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 10:40:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/mtl: Override the `SOC_PHYSICAL_ADDRESS_WIDTH` as integer
by Jakub Czapiga (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Mike Banon, Subrata Banik, Tarun. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79842?usp=email ) Change subject: soc/intel/mtl: Override the `SOC_PHYSICAL_ADDRESS_WIDTH` as integer ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib5bdfdb8c2689803c9d3c2bfd353609edae91ab3 Gerrit-Change-Number: 79842 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 10:24:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/intel/mtlrvp: define a new config for Chrome EC
by Deepti Deshatty (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Felix Singer, Kapil Porwal, Krishna P Bhat D, Paul Menzel, Subrata Banik, Vijay P Hiremath. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email ) Change subject: mb/intel/mtlrvp: define a new config for Chrome EC ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: Can someone please approve the changes. -- To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Gerrit-Change-Number: 79211 Gerrit-PatchSet: 10 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 10:21:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/mediatek: Add common implmentation to configure display
by Yu-Ping Wu (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email ) Change subject: soc/mediatek: Add common implmentation to configure display ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/common/display.c: https://review.coreboot.org/c/coreboot/+/79776/comment/20cba7f8_4bbaabed : PS1, Line 42: if (panel->get_edid && panel->get_edid(panel) < 0) > > And s can also be removed from panel. […] I think we just need a local variable to store panel_serializable_data. ``` struct edid edid; if (DISP_PATH_EDP) { ... } else { panel_serializable_data mipi_data = {0}; if (panel->get_edid) { panel->get_edid(panel, &edid); // Fills edid } else { get_mipi_panel_from_cbfs(&mipi_data); edid = mipi_data.edid; // Or use pointer } mtk_dsi_init(..., mipi_data->init); } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/79776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Gerrit-Change-Number: 79776 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:59:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/mediatek: Add common implmentation to configure display
by Yu-Ping Wu (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email ) Change subject: soc/mediatek: Add common implmentation to configure display ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/geralt/panel.h: https://review.coreboot.org/c/coreboot/+/79776/comment/8aecc54f_6736e923 : PS1, Line 23: struct panel_description *get_active_panel(void); > If so, do you suggest passing `struct panel_description panl` to `mtk_display_init` (configure_displ […] That's a good question. I admit I didn't think of that. For now, I have no strong opinion, so I'm fine with your existing patchset. It's up to you (if the declaration is kept here, then I think we'll need to pass `panel` to `mtk_display_init()`). -- To view, visit https://review.coreboot.org/c/coreboot/+/79776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Gerrit-Change-Number: 79776 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:52:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/mediatek: Add common implmentation to configure display
by Yidi Lin (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email ) Change subject: soc/mediatek: Add common implmentation to configure display ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/common/display.c: https://review.coreboot.org/c/coreboot/+/79776/comment/21ebe970_335086bc : PS1, Line 42: if (panel->get_edid && panel->get_edid(panel) < 0) > And s can also be removed from panel. I think we still need `s` for `mtk_dsi_init()`. In MIPI panel cases, `s->init` is retrieved from CBFS. In eDP bridge cases, `s->init` is initialized as NULL. `mtk_dsi_init()` will call `mipi_panel_parse_init_commands()` depending on the value of `s->init`. -- To view, visit https://review.coreboot.org/c/coreboot/+/79776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Gerrit-Change-Number: 79776 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:51:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Resolve GPI/GPIO dysphoria
by Arthur Heymans (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Alexander Couzens, Brandon McDonnell. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67919?usp=email ) Change subject: Resolve GPI/GPIO dysphoria ...................................................................... Patch Set 6: Code-Review-1 (2 comments) Patchset: PS6: GPIO is often how this is referred to in the datasheet. File src/southbridge/intel/ibexpeak/pch.h: https://review.coreboot.org/c/coreboot/+/67919/comment/efc2e96f_c97a09ae : PS6, Line 112: GPIO_ROUT This is actually how the registers is called in datasheet. -- To view, visit https://review.coreboot.org/c/coreboot/+/67919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I00fc9e3bfbba5b849d21651b08368fa897ccb1fb Gerrit-Change-Number: 67919 Gerrit-PatchSet: 6 Gerrit-Owner: Brandon McDonnell <bamteck(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Brandon McDonnell <bamteck(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/ibm/sbp1: Set FSP loglevel
by Arthur Heymans (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Naresh Solanki, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79791?usp=email ) Change subject: mb/ibm/sbp1: Set FSP loglevel ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79791?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia97dbda30f657f0b1568364d712eaea8d134b3b0 Gerrit-Change-Number: 79791 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:38:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Fix error in DDR DQS config
by Ivy Jian (Code Review) 08 Jan '24

08 Jan '24

Attention is currently required from: Nick Vaccaro, Shelley Chen. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79843?usp=email ) Change subject: mb/google/brox: Fix error in DDR DQS config ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I21f50e2f5b4fae09725c1c7532636ed1cc1a9043 Gerrit-Change-Number: 79843 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024