Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Eric Lai, Felix Singer, Kapil Porwal, Krishna P Bhat D, Paul Menzel, Vijay P Hiremath.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email )
Change subject: mb/intel/mtlrvp: streamline Chrome EC configs
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f
Gerrit-Change-Number: 79211
Gerrit-PatchSet: 11
Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 11:47:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Eric Lai, Krishna P Bhat D, Subrata Banik, Vijay P Hiremath.
Hello Balaji Manigandan, Deepti Deshatty, Eric Lai, Krishna P Bhat D, Subrata Banik, Vijay P Hiremath, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79824?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/intel/mtlrvp: define a new config for Chrome EC
......................................................................
mb/intel/mtlrvp: define a new config for Chrome EC
Introduce new config MTL_CHROME_EC_SHARED_SPI, tailored for
Chrome ECs utilizing an external shared SPI flash.
BUG=b:289783489
TEST=emerge-rex coreboot chromeos-bootimage is successful
Cq-Depend: chrome-internal:6691498
Cq-Depend: chrome-internal:6741356
Change-Id: I462c34c5adaefa37c652de293152243c58bad7c5
Signed-off-by: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com>
---
M src/mainboard/intel/mtlrvp/Kconfig
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/79824/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79824?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I462c34c5adaefa37c652de293152243c58bad7c5
Gerrit-Change-Number: 79824
Gerrit-PatchSet: 2
Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Eric Lai, Felix Singer, Kapil Porwal, Krishna P Bhat D, Paul Menzel, Vijay P Hiremath.
Hello Balaji Manigandan, Deepti Deshatty, Eric Lai, Kapil Porwal, Krishna P Bhat D, Subrata Banik, Vijay P Hiremath, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79211?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Code-Review+1 by Eric Lai, Verified+1 by build bot (Jenkins)
Change subject: mb/intel/mtlrvp: streamline Chrome EC configs
......................................................................
mb/intel/mtlrvp: streamline Chrome EC configs
Chrome EC configuration options that are common among
various boards have been consolidated under the
"BOARD_EXT_EC_SPECIFIC_OPTIONS" config.
BUG=b:289783489
TEST=emerge-rex coreboot chromeos-bootimage is successful
Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f
Signed-off-by: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com>
---
M src/mainboard/intel/mtlrvp/Kconfig
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/79211/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f
Gerrit-Change-Number: 79211
Gerrit-PatchSet: 11
Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ruihai Zhou.
cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79844?usp=email )
Change subject: drivers/mipi: Add support for IVO_T109NW41 panel
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79844?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id740e3a21f72bbcd6e5c2b56b31ac90f4990d475
Gerrit-Change-Number: 79844
Gerrit-PatchSet: 1
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 11:22:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79845?usp=email )
Change subject: mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79845?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dc2228d39bb8bb048d1f37727c96b0ad621e912
Gerrit-Change-Number: 79845
Gerrit-PatchSet: 1
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 10:55:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79844?usp=email )
Change subject: drivers/mipi: Add support for IVO_T109NW41 panel
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79844?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id740e3a21f72bbcd6e5c2b56b31ac90f4990d475
Gerrit-Change-Number: 79844
Gerrit-PatchSet: 1
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 10:55:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )
Change subject: Choose Correct FW splash screen at runtime
......................................................................
Patch Set 8:
(7 comments)
File src/include/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/79775/comment/599ac1f6_7321750a :
PS7, Line 19: const char *get_bmp_file(void);
> nit: some help text is required to let user know that any user can override this implementation if t […]
Acknowledged
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/79775/comment/b7ca8915_814719c9 :
PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
> > The HAVE_CUSTOM_BMP_LOGO config should be automatically selected by the CHROMEOS_FW_SPLASH_SCREEN […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/79775/comment/8368c44e_a5b6211a :
PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
> > The HAVE_CUSTOM_BMP_LOGO config should be automatically selected by the CHROMEOS_FW_SPLASH_SCREEN […]
Acknowledged
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79775/comment/e1a3ddf8_87de0571 :
PS7, Line 156: ramstage-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += bmp_logo.c
> do we really need this? […]
Acknowledged
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/79775/comment/b115f3f2_1831c0a3 :
PS7, Line 88: Display the ChromeOS splash screen in the firmware.
> nit: Choose this option to let boot firmware to render the OEM splash screen. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/79775/comment/d17d4ea8_c4f0b4c1 :
PS7, Line 91: CB
> nit: should we say "Chromebook" or "ChromeOS" ?
Acknowledged
https://review.coreboot.org/c/coreboot/+/79775/comment/31cf783a_ff401ec2 :
PS7, Line 96: CB
> nit: Chromebook ?
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960
Gerrit-Change-Number: 79775
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 10:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen, Subrata Banik.
Subrata Banik has uploaded a new patch set (#8) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Subrata Banik, Verified+1 by build bot (Jenkins)
Change subject: Choose Correct FW splash screen at runtime
......................................................................
Choose Correct FW splash screen at runtime
This CL uses the factory config that is retrieved by the TPM in order
to determine if the device is a chromebook or a chromebook plus device
at runtime. From this it will dynamically choose the correct FW
splash screen to display at boot time.
This CL also introduces three new Kconfigs:
CHROMEOS_FW_SPLASH_SCREEN
CB_LOGO_PATH
CB_PLUS_LOGO_PATH
which allow users to enable the fw splash screen feature in the
vendorcode. Previously, we were using the BMP_LOGO Kconfig in
drivers/intel/fsp2_0, but we didn't want the top level Kconfigs to be
located inside the architecture specific files.
BUG=b:317880956
BRANCH=None
TEST=emerge-rex coreboot chromeos-bootimage
verify that FW splash screen appears
Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960
Signed-off-by: Shelley Chen <shchen(a)google.com>
---
M src/drivers/intel/fsp2_0/Makefile.inc
M src/include/bootsplash.h
M src/lib/Kconfig
M src/lib/bmp_logo.c
M src/vendorcode/google/chromeos/Kconfig
M src/vendorcode/google/chromeos/Makefile.inc
A src/vendorcode/google/chromeos/splash.c
7 files changed, 68 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/79775/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960
Gerrit-Change-Number: 79775
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-MessageType: newpatchset