coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[M] Change in coreboot[main]: soc/intel: Unify the definition of TCO registers
by Marek Maślanka (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Sean Rhodes. Hello Sean Rhodes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80005?usp=email to look at the new patch set (#2). Change subject: soc/intel: Unify the definition of TCO registers ...................................................................... soc/intel: Unify the definition of TCO registers Move TCO registers definition to a separate file and use it consistently. BUG=b:314260167 TEST=none Change-Id: Id64a635d106cea879ab08aa7beca101de14b1ee6 Signed-off-by: Marek Maslanka <mmaslanka(a)google.com> --- M src/soc/intel/apollolake/include/soc/smbus.h M src/soc/intel/common/pch/include/intelpch/smbus.h A src/soc/intel/common/pch/include/intelpch/tco.h M src/soc/intel/denverton_ns/include/soc/pmc.h M src/soc/intel/xeon_sp/include/soc/smbus.h 5 files changed, 52 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80005/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80005?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id64a635d106cea879ab08aa7beca101de14b1ee6 Gerrit-Change-Number: 80005 Gerrit-PatchSet: 2 Gerrit-Owner: Marek Maślanka <mmaslanka(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/mediatek: Add EARLY_MMU_INIT kconfig option
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79990?usp=email ) Change subject: soc/mediatek: Add EARLY_MMU_INIT kconfig option ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Gerrit-Change-Number: 79990 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 10:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/rex: Set TCC to 100°C
by Sumeet R Pawnikar (Code Review) 16 Jan '24

16 Jan '24

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79992?usp=email ) Change subject: mb/google/rex/var/rex: Set TCC to 100°C ...................................................................... mb/google/rex/var/rex: Set TCC to 100°C Set tcc_offset value to 10 in devicetree for Thermal Control Circuit (TCC) activation feature for rex. BUG=b:270664854 TEST=Build, boot and test on rex with value under sysfs /sys/bus/pci/devices/0000:00:04.0/tcc_offset_degree_celsius Change-Id: I9012984016ab3213102214025d6d8dc07c5d8974 Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/79992/1 diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb index 9f86840..58c1719 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb @@ -45,6 +45,9 @@ # DPTF enable register "dptf_enable" = "1" + # Setting TCC of 100C = Tj max (110) - TCC_Offset (10) + register "tcc_offset" = "10" + # Enable CNVi BT register "cnvi_bt_core" = "true" -- To view, visit https://review.coreboot.org/c/coreboot/+/79992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9012984016ab3213102214025d6d8dc07c5d8974 Gerrit-Change-Number: 79992 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: soc/mediatek: Add EARLY_MMU_INIT kconfig option
by Yidi Lin (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79990?usp=email ) Change subject: soc/mediatek: Add EARLY_MMU_INIT kconfig option ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79990/comment/ea45fc73_6814186e : PS3, Line 7: EARLY_INIT_MMU > `EARLY_MMU_INIT` […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Gerrit-Change-Number: 79990 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 10:05:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/mediatek: Add EARLY_MMU_INIT kconfig option
by Yidi Lin (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79990?usp=email to look at the new patch set (#4). Change subject: soc/mediatek: Add EARLY_MMU_INIT kconfig option ...................................................................... soc/mediatek: Add EARLY_MMU_INIT kconfig option Accessing RAM before mmu initialized is time consuming. During mmu initialization, `mmu_init()` and `mmu_config_range()` write logs to the console buffer and contribue the extra boot time. This patch adds a kconfig option to move `mtk_mmu_init()` to `bootblock_soc_early_init()`. When `EARLY_MMU_INIT` is enabled, mmu is initialized before `console_init()` ready. So `mmu_init()` and `mmu_config_range()` won't write logs to the console buffer and save the boot time. It saves about 65ms on Geralt with EARLY_MMU_INIT enabled. Before: 0:1st timestamp 239,841 (0) 11:start of bootblock 239,920 (79) 12:end of bootblock 323,191 (83,271) After: 0:1st timestamp 239,804 (0) 11:start of bootblock 239,884 (80) 12:end of bootblock 258,846 (18,962) BUG=b:320381143 TEST=check timestamps in cbmem Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/Kconfig A src/soc/mediatek/common/bootblock.c M src/soc/mediatek/common/mmu_operations.c M src/soc/mediatek/mt8188/Makefile.inc 4 files changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/79990/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Gerrit-Change-Number: 79990 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Enable EARLY_MMU_INIT
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79991?usp=email ) Change subject: soc/mediatek/mt8188: Enable EARLY_MMU_INIT ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I74191ab8cbefa08b7e296312645ea40b46fabf77 Gerrit-Change-Number: 79991 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 10:01:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/mediatek: Add EARLY_INIT_MMU kconfig option
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79990?usp=email ) Change subject: soc/mediatek: Add EARLY_INIT_MMU kconfig option ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79990/comment/818726aa_aca186cb : PS3, Line 7: EARLY_INIT_MMU `EARLY_MMU_INIT` Also other 2 occurrences below. -- To view, visit https://review.coreboot.org/c/coreboot/+/79990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Gerrit-Change-Number: 79990 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 10:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move back the ttb_buffer section
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Yi Chou. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79800?usp=email ) Change subject: libpayload: Move back the ttb_buffer section ...................................................................... Patch Set 6: (3 comments) File payloads/libpayload/arch/arm64/mmu.c: https://review.coreboot.org/c/coreboot/+/79800/comment/ae36ae44_99b49435 : PS6, Line 45: ChormeOS's typo https://review.coreboot.org/c/coreboot/+/79800/comment/6abc0516_335e9964 : PS6, Line 46: to please `please do` https://review.coreboot.org/c/coreboot/+/79800/comment/55270c49_ac605f82 : PS6, Line 47: * Please contact: jwerner(a)chromium.org or yich(a)chromium.org */ Sorry, my review comes a bit late, but why don't we change this to `__attribute__((__section__(".bss.ttb_buffer")))`, which I think should also work without `-fdata-sections`? Also, the explicit section name allows people to rename the variable without breaking what we are doing (unless there's another new variable named `ttb_buffer`). -- To view, visit https://review.coreboot.org/c/coreboot/+/79800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb08878dd4be01d9ed3f96933f774dd6296f76e Gerrit-Change-Number: 79800 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 09:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/mediatek: Add EARLY_INIT_MMU kconfig option
by Yidi Lin (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79990?usp=email ) Change subject: soc/mediatek: Add EARLY_INIT_MMU kconfig option ...................................................................... Patch Set 3: (3 comments) File src/soc/mediatek/common/Kconfig: https://review.coreboot.org/c/coreboot/+/79990/comment/11678f00_ff20e757 : PS1, Line 94: EARLY_INIT_MMU > How about `EARLY_MMU_INIT`? Done https://review.coreboot.org/c/coreboot/+/79990/comment/b67c25c1_5aa3b561 : PS1, Line 98: When this opiton is enabled, `mtk_mmu_init()` will be done in > > `'opiton' may be misspelled - perhaps 'option'?` […] Done File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79990/comment/0e009b9f_d078b226 : PS1, Line 13: bootblock-$(CONFIG_EARLY_INIT_MMU) += ../common/bootblock.c > This reads a bit weird to me, as common/bootblock.c may not be directly related to `mtk_mmu_init`. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Gerrit-Change-Number: 79990 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 09:56:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Enable EARLY_MMU_INIT
by Yidi Lin (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79991?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Yu-Ping Wu Change subject: soc/mediatek/mt8188: Enable EARLY_MMU_INIT ...................................................................... soc/mediatek/mt8188: Enable EARLY_MMU_INIT The boot time is improved by 65ms. (762ms -> 697ms) BUG=b:320381143 TEST=check timestamps in cbmem Change-Id: I74191ab8cbefa08b7e296312645ea40b46fabf77 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/mt8188/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/79991/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I74191ab8cbefa08b7e296312645ea40b46fabf77 Gerrit-Change-Number: 79991 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024