Attention is currently required from: Jamie Chen, Kyle Lin, Nick Vaccaro, Paul Menzel, Yunlong Jia.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79220?usp=email )
Change subject: mb/google/nissa/var/gothrax: Tune eMMC DLL values
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79220/comment/dabcd6df_bad5d980 :
PS3, Line 9: and
> with a
Done
https://review.coreboot.org/c/coreboot/+/79220/comment/50b2c758_c659c04d :
PS3, Line 13: success
> successful
Done
https://review.coreboot.org/c/coreboot/+/79220/comment/bcc68b39_7296312c :
PS3, Line 14: - Collecting every eMMC that use for the project
> Sorry, I do not understand this.
Done
https://review.coreboot.org/c/coreboot/+/79220/comment/482d16af_d0798633 :
PS3, Line 15: a fine tune
> fine tuned
Done
https://review.coreboot.org/c/coreboot/+/79220/comment/3b6bbec2_d718988f :
PS3, Line 16:
> What do the new values do?
New values are to cover new eMMC components requested by ODM.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36cc9948e3d5dee46385e584baad141a249be79
Gerrit-Change-Number: 79220
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 16 Jan 2024 03:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Jamie Chen, Kyle Lin, Nick Vaccaro, Simon Yang, Yunlong Jia.
Hello Eric Lai, Kyle Lin, Nick Vaccaro, Subrata Banik, Yunlong Jia, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79220?usp=email
to look at the new patch set (#5).
Change subject: mb/google/nissa/var/gothrax: Tune eMMC DLL values
......................................................................
mb/google/nissa/var/gothrax: Tune eMMC DLL values
Gothrax cannot boot into OS with a kernel loading failure.
Update eMMC DLL values to improve initialization reliability
How to get these values:
- Sending different speed TX/RX command/data signal to eMMC and check
the response is successful or not.
- Collecting above results from each eMMC model that project used.
- Analysing logs to provide a fine tuned DLL values.
BUG=b:310701323
TEST=Cold reboot stress test over 2500 cycles
Change-Id: Ie36cc9948e3d5dee46385e584baad141a249be79
Signed-off-by: Simon Yang <simon1.yang(a)intel.com>
---
M src/mainboard/google/brya/variants/gothrax/overridetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/79220/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/79220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36cc9948e3d5dee46385e584baad141a249be79
Gerrit-Change-Number: 79220
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jamie Chen, Kyle Lin, Nick Vaccaro, Simon Yang, Yunlong Jia.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79220?usp=email )
Change subject: mb/google/nissa/var/gothrax: Tune eMMC DLL values
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36cc9948e3d5dee46385e584baad141a249be79
Gerrit-Change-Number: 79220
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Comment-Date: Tue, 16 Jan 2024 02:49:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dtrain Hsu, Eric Lai, Kenny Pan, Nick Vaccaro, Paul Menzel, Rex Chou, Shou-Chieh Hsu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79978?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify ELAN touchscreen enable delay from 1ms to 6ms
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id57ab04e61d9e95c962f2c564d3a7e2e7ed6b992
Gerrit-Change-Number: 79978
Gerrit-PatchSet: 3
Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kenny Pan <kennypan(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Tue, 16 Jan 2024 02:48:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Ian Feng, Kenny Pan, Nick Vaccaro, Rex Chou, Shou-Chieh Hsu, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79890?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify thermal table and add fan performance control
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I would advice to do things in incremental cls so, it is easy to review the code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79890?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15fa4b8f7c7088ff56da6493659ae45572913b5a
Gerrit-Change-Number: 79890
Gerrit-PatchSet: 5
Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kenny Pan <kennypan(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Tue, 16 Jan 2024 02:47:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jamie Chen, Kyle Lin, Nick Vaccaro, Simon Yang, Subrata Banik, Yunlong Jia.
Hello Eric Lai, Kyle Lin, Nick Vaccaro, Subrata Banik, Yunlong Jia, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79220?usp=email
to look at the new patch set (#4).
Change subject: mb/google/nissa/var/gothrax: Tune eMMC DLL values
......................................................................
mb/google/nissa/var/gothrax: Tune eMMC DLL values
Gothrax cannot boot into OS with a kernel loading failure.
Update eMMC DLL values to improve initialization reliability
- Sending different speed TX/RX command/data signal to eMMC and check
the response is successful or not.
- Collecting every eMMC that use for the project
- Based on above result to provide a fine tuned DLL values
BUG=b:310701323
TEST=Cold reboot stress test over 2500 cycles
Change-Id: Ie36cc9948e3d5dee46385e584baad141a249be79
Signed-off-by: Simon Yang <simon1.yang(a)intel.com>
---
M src/mainboard/google/brya/variants/gothrax/overridetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/79220/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/79220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36cc9948e3d5dee46385e584baad141a249be79
Gerrit-Change-Number: 79220
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dtrain Hsu, Eric Lai, Kenny Pan, Nick Vaccaro, Paul Menzel, Rex Chou, Shou-Chieh Hsu, Subrata Banik.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79978?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify ELAN touchscreen enable delay from 1ms to 6ms
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id57ab04e61d9e95c962f2c564d3a7e2e7ed6b992
Gerrit-Change-Number: 79978
Gerrit-PatchSet: 3
Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kenny Pan <kennypan(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Tue, 16 Jan 2024 01:59:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment