coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[S] Change in coreboot[main]: mb/google/brox: Switch EC INT and WAKE GPIOs
by Eric Lai (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Shelley Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79886?usp=email ) Change subject: mb/google/brox: Switch EC INT and WAKE GPIOs ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Please also verify the EC event too. check the eventlist for wake /ac plug/unplug / power key / KB. -- To view, visit https://review.coreboot.org/c/coreboot/+/79886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02057aeb5d82218dbbe4c939d4feb87a4d3da678 Gerrit-Change-Number: 79886 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 02:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brox: Move storage devices to overridetree
by Eric Lai (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Shelley Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79995?usp=email ) Change subject: mb/google/brox: Move storage devices to overridetree ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79995?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I18d096040c293abfd4cd0b1bb5f50ba6dcc2e183 Gerrit-Change-Number: 79995 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 01:58:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brox: Set up FW_CONFIG
by Eric Lai (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Nick Vaccaro, Paul Menzel, Shelley Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79854?usp=email ) Change subject: mb/google/brox: Set up FW_CONFIG ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Patchset: PS8: Wait Nick to check. -- To view, visit https://review.coreboot.org/c/coreboot/+/79854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf43003b7e8210eee9016d779839d7048c15825f Gerrit-Change-Number: 79854 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 01:57:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update vboot submodule to upstream main
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80006?usp=email ) Change subject: Update vboot submodule to upstream main ...................................................................... Update vboot submodule to upstream main Updating from commit id 32402941: 2024-01-08 19:53:43 +0000 - (treewide: Put the static keyword at the beginning of declarations) to commit id 3d37d2aa: 2024-01-15 06:21:04 +0000 - (Makefile: Support FIRMWARE_ARCH=mock for firmware unit tests) This brings in 2 new commits: 3d37d2aa Makefile: Support FIRMWARE_ARCH=mock for firmware unit tests ffe3fb20 make_keyblock: Add support for omitting extension Change-Id: I30425f0c50caf24800661568da8f72f6b4418d9c Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80006 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved diff --git a/3rdparty/vboot b/3rdparty/vboot index 3240294..3d37d2a 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 32402941c0afdb5bf50d6e3c11548ecb1ac80544 +Subproject commit 3d37d2aafe1f941c532def2a1fbbb58c8dd84182 -- To view, visit https://review.coreboot.org/c/coreboot/+/80006?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30425f0c50caf24800661568da8f72f6b4418d9c Gerrit-Change-Number: 80006 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: libpayload/vboot/Makefile.inc: Pass FIRMWARE_ARCH=mock if LP_ARCH_MOCK
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Julius Werner, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79956?usp=email ) Change subject: libpayload/vboot/Makefile.inc: Pass FIRMWARE_ARCH=mock if LP_ARCH_MOCK ...................................................................... Patch Set 3: (1 comment) File payloads/libpayload/vboot/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79956/comment/85853255_06760600 : PS2, Line 22: VBOOT_FIRMWARE_ARCH := mock > nit: would be a bit easier to just say `VBOOT_FIRMWARE_ARCH-y := mock` here? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79956?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ead7f2f93eac5f5c3887074423fb9aa50a489c0 Gerrit-Change-Number: 79956 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 01:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload/vboot/Makefile.inc: Pass FIRMWARE_ARCH=mock if LP_ARCH_MOCK
by Yu-Ping Wu (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Julius Werner, Yidi Lin, Yu-Ping Wu. Hello Julius Werner, Yidi Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79956?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Code-Review+2 by Yidi Lin, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: libpayload/vboot/Makefile.inc: Pass FIRMWARE_ARCH=mock if LP_ARCH_MOCK ...................................................................... libpayload/vboot/Makefile.inc: Pass FIRMWARE_ARCH=mock if LP_ARCH_MOCK If CONFIG_LP_ARCH_MOCK, pass FIRMWARE_ARCH=mock when building vboot fwlib, so that vboot's Makefile will append the correct flags to CFLAGS. BUG=none TEST=(depthcharge) make unit-tests -j BRANCH=none Cq-Depend: chromium:5182247 Change-Id: I9ead7f2f93eac5f5c3887074423fb9aa50a489c0 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M payloads/libpayload/vboot/Makefile.inc 1 file changed, 11 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/79956/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79956?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ead7f2f93eac5f5c3887074423fb9aa50a489c0 Gerrit-Change-Number: 79956 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
by Derek Huang (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Paul Menzel. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 01:42:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Anson Tseng, Derek Huang, Karthik Ramasubramanian, Paul Menzel. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79930/comment/e60a52d2_33946e9b : PS8, Line 9: marasov > marasov? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 01:40:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Paul Menzel. Hello Anson Tseng, Derek Huang, Karthik Ramasubramanian, Shou-Chieh Hsu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79930?usp=email to look at the new patch set (#9). Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting ...................................................................... mb/google/dedede/var/pirika: Add initial fw_config configuration setting 1. Describe the FW_CONFIG probe for the settings for Palutena. - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW 2. In contrast to the AW Wi-Fi module, the Intel Wi-Fi module needs to load a SAR table in dedede platform. 3. For Palutena project, the SKU ID segment of Palutena is set for "0x350000~0x35FFFF". BUG=b:319792428 BRANCH=firmware-dedede-13606.B TEST=build pass Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb M src/mainboard/google/dedede/variants/pirika/variant.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79930/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
by Derek Huang (Code Review) 16 Jan '24

16 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Paul Menzel. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79930/comment/2ce7a820_28e0598e : PS8, Line 9: marasov marasov? -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 01:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024