Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier.
Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76166?usp=email )
Change subject: soc/amd/phoenix/Kconfig: Select VBOOT_X86_SHA256_ACCELERATION
......................................................................
soc/amd/phoenix/Kconfig: Select VBOOT_X86_SHA256_ACCELERATION
Phoenix is an x86 soc that supports sha256 instructions.
TEST=boot birman to chromeos
Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com>
Change-Id: Id228399ba02708b97110d524ce12c2626588762d
---
M src/soc/amd/phoenix/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/76166/1
diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig
index eb1ec56..c6ab21f 100644
--- a/src/soc/amd/phoenix/Kconfig
+++ b/src/soc/amd/phoenix/Kconfig
@@ -88,6 +88,7 @@
select USE_FSP_NOTIFY_PHASE_READY_TO_BOOT
select USE_FSP_NOTIFY_PHASE_END_OF_FIRMWARE
select VBOOT_DEFINE_WIDEVINE_COUNTERS if VBOOT_STARTS_BEFORE_BOOTBLOCK
+ select VBOOT_X86_SHA256_ACCELERATION if VBOOT
select X86_AMD_FIXED_MTRRS
select X86_INIT_NEED_1_SIPI
help
--
To view, visit https://review.coreboot.org/c/coreboot/+/76166?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id228399ba02708b97110d524ce12c2626588762d
Gerrit-Change-Number: 76166
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email )
Change subject: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76070/comment/29879cca_2950f179 :
PS1, Line 161: if (ENV_X86)
> > I'm fine with this, but one might consider moving this and the COMMON_MADT conditionals below over […]
We already have arch_fill_fadt(), I think it has worked out pretty well so perhaps introduce arch_fill_madt() ?
One thing to consider; from somewhere ARM builds needs to pickup cpu_lapic_addr() prototype. I know it's in cpu/cpu.h now but with the discussion here, it soudns like arch/cpu.h or cpu/x86/lapic.h would be more correct. And even XAPIC aka LAPIC MMIO is slowly disappearing, making this entry obsolete.
I think it gets troublesome if we add clearly arch-specific function prototypes to arch-agnostic headers like what I consider <cpu/cpu.h> is. Also, I believe we do not want to unconditionally include from both <arch/x86/> and <arch/arm> in a single file.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335
Gerrit-Change-Number: 76070
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 29 Jun 2023 18:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Nico Huber, Tim Wawrzynczak.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76179?usp=email )
Change subject: acpi.c: Fill in >4G FADT entries correctly
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
build error:
src/acpi/acpi.c: In function 'acpi_create_fadt':
src/acpi/acpi.c:1733:61: error: right shift count >= width of type [-Werror=shift-count-overflow]
1733 | fadt->x_firmware_ctl_h = (uint32_t)((uintptr_t)facs >> 32);
| ^~
src/acpi/acpi.c:1738:53: error: right shift count >= width of type [-Werror=shift-count-overflow]
1738 | fadt->x_dsdt_h = (uint32_t)((uintptr_t)dsdt >> 32);
--
To view, visit https://review.coreboot.org/c/coreboot/+/76179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84ab0068e8409a5e525ddc781347087680d80640
Gerrit-Change-Number: 76179
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Jun 2023 18:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment