coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: payloads/external/depthcharge: Update stable version
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75134?usp=email ) Change subject: payloads/external/depthcharge: Update stable version ...................................................................... payloads/external/depthcharge: Update stable version The stable version was over 5 years old. Update it to the current main branch. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ic9cbe5e3dad9f2ff06e1fa8f0582d4c8b3e81a22 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75134 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M payloads/external/depthcharge/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/payloads/external/depthcharge/Makefile b/payloads/external/depthcharge/Makefile index 687e9f0..e3e2303 100644 --- a/payloads/external/depthcharge/Makefile +++ b/payloads/external/depthcharge/Makefile @@ -1,5 +1,5 @@ -# Wed Apr 25, 2018 -STABLE_COMMIT_ID=902681db13c170fc2d028f7391a9e9a5f69082a3 +# 2023-05-10 +STABLE_COMMIT_ID=c48613a71c1ee29295b184c51fe5dadf71b543c4 project_name=depthcharge project_dir=$(CURDIR)/depthcharge -- To view, visit https://review.coreboot.org/c/coreboot/+/75134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cbe5e3dad9f2ff06e1fa8f0582d4c8b3e81a22 Gerrit-Change-Number: 75134 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: payloads/external/depthcharge: Update stable version
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Martin L Roth. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75134?usp=email ) Change subject: payloads/external/depthcharge: Update stable version ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cbe5e3dad9f2ff06e1fa8f0582d4c8b3e81a22 Gerrit-Change-Number: 75134 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:43:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: soc/mediatek/mt8183: Force reduce DRAM speed for debug[DONOT MERGE]
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/blobs/+/40284?usp=email ) Change subject: soc/mediatek/mt8183: Force reduce DRAM speed for debug[DONOT MERGE] ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/blobs/+/40284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I008361b0799215f227c3f78d222b58c04ab8c806 Gerrit-Change-Number: 40284 Gerrit-PatchSet: 1 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Duan huayang <huayang.duan(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: soc|vc/amd/phoenix: Prepare for PSP verstage
by Martin Roth (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jon Murphy, Karthik Ramasubramanian, Matt DeVillier, Raul Rangel, Tim Van Patten. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75584?usp=email ) Change subject: soc|vc/amd/phoenix: Prepare for PSP verstage ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It looks like there is a lot of overlap with mendocino. […] It'd be great to refactor what we can into common code. There definitely can be differences, but those can still be contained in the SoC. Created b:286514273 -- To view, visit https://review.coreboot.org/c/coreboot/+/75584?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6fbb1f835ac2ad6ff47f843321e1bd380af7ce33 Gerrit-Change-Number: 75584 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:10:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Add PSP verstage callbacks
by Martin Roth (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Raul Rangel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75585?usp=email ) Change subject: mb/google/myst: Add PSP verstage callbacks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc800e8bb27cc4c3fbccc2ab9f51138a7c4b03a6 Gerrit-Change-Number: 75585 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc|vc/amd/phoenix: Prepare for PSP verstage
by Martin Roth (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jon Murphy, Karthik Ramasubramanian, Matt DeVillier, Raul Rangel, Tim Van Patten. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75584?usp=email ) Change subject: soc|vc/amd/phoenix: Prepare for PSP verstage ...................................................................... Patch Set 1: (2 comments) File src/soc/amd/phoenix/psp_verstage/Makefile.inc: https://review.coreboot.org/c/coreboot/+/75584/comment/3b91c1af_4f62ee48 : PS1, Line 3: ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y) > `src/soc/amd/mendocino/psp_verstage/Makefile.inc` is slightly different than this. […] vboot_separate_verstage can also run on the x86, and we don't want this included there. VBOOT_STARTS_BEFORE_BOOTBLOCK really means PSP_verstage, it was just requested not to call it PSP_verstage in Kconfig when the feature was introduced. File src/vendorcode/amd/fsp/phoenix/include/bl_uapp/bl_errorcodes_public.h: https://review.coreboot.org/c/coreboot/+/75584/comment/6edd2161_2c64cc5d : PS1, Line 1: * Use the version in vendorcode/amd/fsp/common/bl_uapp instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/75584?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6fbb1f835ac2ad6ff47f843321e1bd380af7ce33 Gerrit-Change-Number: 75584 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:02:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: Documentation: fix link to Driver Devicetree Entries page
by Marshall Dawson (Code Review) 09 Jun '23

09 Jun '23

Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75695?usp=email ) Change subject: Documentation: fix link to Driver Devicetree Entries page ...................................................................... Documentation: fix link to Driver Devicetree Entries page Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Change-Id: I08057576c23cef0343816c3b14c48db77b8dc416 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75695 Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M Documentation/getting_started/devicetree.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved Fred Reitberger: Looks good to me, approved Matt DeVillier: Looks good to me, approved Martin Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Documentation/getting_started/devicetree.md b/Documentation/getting_started/devicetree.md index 824c512..2585846 100644 --- a/Documentation/getting_started/devicetree.md +++ b/Documentation/getting_started/devicetree.md @@ -79,7 +79,7 @@ ## Device drivers Platform independent device drivers are hooked up via entries in a devicetree. -See [Driver Devicetree Entries](drivers/dt_entries.md) for more info. +See [Driver Devicetree Entries](../drivers/dt_entries.md) for more info. ## Notes -- To view, visit https://review.coreboot.org/c/coreboot/+/75695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08057576c23cef0343816c3b14c48db77b8dc416 Gerrit-Change-Number: 75695 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in blobs[main]: soc/mediatek/mt8183: Force reduce DRAM speed for debug[DONOT MERGE]
by Yidi Lin (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, huayang duan. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/40284?usp=email ) Change subject: soc/mediatek/mt8183: Force reduce DRAM speed for debug[DONOT MERGE] ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Please abandon, if it’s not needed anymore. I don't have permission to abandon this patch. Hung-Te and Paul, could you help abandon it ? -- To view, visit https://review.coreboot.org/c/blobs/+/40284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I008361b0799215f227c3f78d222b58c04ab8c806 Gerrit-Change-Number: 40284 Gerrit-PatchSet: 1 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Duan huayang <huayang.duan(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: huayang duan <huayangduan(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 14:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Add pen detect support
by Martin Roth (Code Review) 09 Jun '23

09 Jun '23

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75696?usp=email ) Change subject: mb/google/myst: Add pen detect support ...................................................................... mb/google/myst: Add pen detect support Add pen detect support on the SOC pen detect GPIO. BUG=b:286296762 TEST=Verify pen detect works on Myst Change-Id: I922d643a83c5cd8ea0ab9fe6733f7aa05d935802 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75696 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Tim Van Patten <timvp(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/myst/Kconfig M src/mainboard/google/myst/variants/myst/overridetree.cb 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Tim Van Patten: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/myst/Kconfig b/src/mainboard/google/myst/Kconfig index a35596c..bfa4d03 100644 --- a/src/mainboard/google/myst/Kconfig +++ b/src/mainboard/google/myst/Kconfig @@ -10,6 +10,7 @@ select AMD_SOC_CONSOLE_UART select BOARD_ROMSIZE_KB_16384 select DISABLE_KEYBOARD_RESET_PIN + select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select DRIVERS_WIFI_GENERIC diff --git a/src/mainboard/google/myst/variants/myst/overridetree.cb b/src/mainboard/google/myst/variants/myst/overridetree.cb index d230e50..05db7ee 100644 --- a/src/mainboard/google/myst/variants/myst/overridetree.cb +++ b/src/mainboard/google/myst/variants/myst/overridetree.cb @@ -64,6 +64,18 @@ register "hid_desc_reg_offset" = "0x01" device i2c 0x10 on end end + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPIO_7)" + register "key.dev_name" = ""EJCT"" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + register "key.debounce_interval" = "100" + register "key.wakeup_route" = "WAKEUP_ROUTE_GPIO_IRQ" + device generic 0 on end + end end # I2C1 device ref i2c_3 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/c/coreboot/+/75696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I922d643a83c5cd8ea0ab9fe6733f7aa05d935802 Gerrit-Change-Number: 75696 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: acpi: Add struct for SPCR table
by Lean Sheng Tan (Code Review) 09 Jun '23

09 Jun '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75684?usp=email ) Change subject: acpi: Add struct for SPCR table ...................................................................... acpi: Add struct for SPCR table Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I46d5caa0af95ec27fd49b0cf8fa704d656c89e7e Reviewed-on: https://review.coreboot.org/c/coreboot/+/75684 Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/include/acpi/acpi.h 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Kyösti Mälkki: Looks good to me, approved build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 78a6005..548b4c3 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1298,6 +1298,36 @@ acpi_einj_action_table_t action_table[ACTION_COUNT]; } __packed acpi_einj_t; +/* SPCR (Serial Port Console Redirection Table) */ +typedef struct acpi_spcr { + acpi_header_t header; + uint8_t interface_type; + uint8_t reserved[3]; + acpi_addr_t base_address; + uint8_t interrupt_type; + uint8_t irq; + uint32_t global_system_interrupt; + uint8_t configured_baudrate; + uint8_t parity; + uint8_t stop_bits; + uint8_t flow_control; + uint8_t terminal_type; + uint8_t language; + uint16_t pci_did; + uint16_t pci_vid; + uint8_t pci_bus; + uint8_t pci_dev; + uint8_t pci_fun; + uint32_t pci_flags; + uint8_t pci_segment; + uint32_t uart_clock; + uint32_t precise_baud_rate; + uint16_t namespace_string_length; + uint16_t namespace_string_offset; + char namespacestring[]; +} __packed acpi_spcr_t; +_Static_assert(sizeof(acpi_spcr_t) == 88, "acpi_spcr_t must have an 88 byte size\n"); + uintptr_t get_coreboot_rsdp(void); void acpi_create_einj(acpi_einj_t *einj, uintptr_t addr, u8 actions); -- To view, visit https://review.coreboot.org/c/coreboot/+/75684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46d5caa0af95ec27fd49b0cf8fa704d656c89e7e Gerrit-Change-Number: 75684 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023