coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: mb/google/myst: Update PCIE_RST_L drive
by Jon Murphy (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Eric Lai, Jon Murphy. Hello Eric Lai, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75700?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: mb/google/myst: Update PCIE_RST_L drive ...................................................................... mb/google/myst: Update PCIE_RST_L drive PCIE_RST_L is attached to a pull down, change the init to pull none. BUG=None TEST=Boot to OS Change-Id: I3f7a548a33eb18327139f033d7c0d6a1843f1639 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M src/mainboard/google/myst/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75700/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/75700?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f7a548a33eb18327139f033d7c0d6a1843f1639 Gerrit-Change-Number: 75700 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/mtl: Enable Fast Vmode on MTL
by Subrata Banik (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Hannah Williams, Jay Patel, Jérémy Compostella, Kapil Porwal, Tarun Tuli, Wonkyu Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75566?usp=email ) Change subject: soc/intel/mtl: Enable Fast Vmode on MTL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: please uprev the partial header first to land this cl -- To view, visit https://review.coreboot.org/c/coreboot/+/75566?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05dccac56c504523f9327babe0c6fbeff488ec2 Gerrit-Change-Number: 75566 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 18:20:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/rex0: Enable Fast Vmode for rex0
by Subrata Banik (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Jay Patel, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75567?usp=email ) Change subject: mb/google/rex/rex0: Enable Fast Vmode for rex0 ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: as per fsp upd description, if icclimit is set to 0 then reactive protection feature remains disable. ``` A value of 0 corresponds to feature disabled (no reactive protection). This value represents the current threshold where the VR would initiate reactive protection if Fast Vmode is enabled. ``` we need to perform icclimit override as well as below VccCORE 72 VccSA 35 File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/75567/comment/08792ee5_c61a3a48 : PS1, Line 58: cep_enable how is this different from enable_fast_vmode ? https://review.coreboot.org/c/coreboot/+/75567/comment/40d034e9_ed2cc128 : PS1, Line 60: register "enable_fast_vmode[VR_DOMAIN_GT]" = "1" : register "cep_enable[VR_DOMAIN_GT]" = "1" as per 640982 doc, gt doesn't support fast mode vr -- To view, visit https://review.coreboot.org/c/coreboot/+/75567?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a0a80f7023be470799ddc2fa1e45b7e1271360c Gerrit-Change-Number: 75567 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 18:20:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/brya/var/hades: Abort power on if any rails fail to come up
by Tarun Tuli (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Eran Mitrani, Eric Lai. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75534?usp=email ) Change subject: mb/google/brya/var/hades: Abort power on if any rails fail to come up ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/75534?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0865e6bdb5db1815ad5509306637308e98c15d7 Gerrit-Change-Number: 75534 Gerrit-PatchSet: 3 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 18:12:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/rex0: Enable Fast Vmode for rex0
by Jay Patel (Code Review) 09 Jun '23

09 Jun '23

Jay Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75567?usp=email ) Change subject: mb/google/rex/rex0: Enable Fast Vmode for rex0 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/75567?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a0a80f7023be470799ddc2fa1e45b7e1271360c Gerrit-Change-Number: 75567 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Jun 2023 18:09:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/mtl: Enable Fast Vmode on MTL
by Jay Patel (Code Review) 09 Jun '23

09 Jun '23

Jay Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75566?usp=email ) Change subject: soc/intel/mtl: Enable Fast Vmode on MTL ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/75566?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05dccac56c504523f9327babe0c6fbeff488ec2 Gerrit-Change-Number: 75566 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Jun 2023 18:06:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: (not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023...
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71065?usp=email ) Change subject: (not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023.04" ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Would be good to merge, can you test it? -- To view, visit https://review.coreboot.org/c/coreboot/+/71065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24 Gerrit-Change-Number: 71065 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:57:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads: Add target to download depthcharge source
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Felix Singer, Fred Reitberger, Martin L Roth. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74480?usp=email ) Change subject: payloads: Add target to download depthcharge source ...................................................................... Patch Set 1: (1 comment) File payloads/external/Makefile.inc: https://review.coreboot.org/c/coreboot/+/74480/comment/2b3fe9bf_2be4cb9f : PS1, Line 144: download-depthcharge: : $(MAKE) -C payloads/external/depthcharge download_tag \ : MFLAGS= MAKEFLAGS= \ : DEPTHCHARGE_MASTER=$(CONFIG_DEPTHCHARGE_MASTER) \ : DEPTHCHARGE_STABLE=$(CONFIG_DEPTHCHARGE_STABLE) \ : DEPTHCHARGE_REVISION=$(CONFIG_DEPTHCHARGE_REVISION) \ : DEPTHCHARGE_REVISION_ID=$(CONFIG_DEPTHCHARGE_REVISION_ID) can this be moved to the depthcharge makefile? -- To view, visit https://review.coreboot.org/c/coreboot/+/74480?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60bf04bbadccc1a0692958b17e2b66b7ad47a396 Gerrit-Change-Number: 74480 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: payloads/edk2: Hook up PCIe Resizable BARs flag
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74926?usp=email ) Change subject: payloads/edk2: Hook up PCIe Resizable BARs flag ...................................................................... payloads/edk2: Hook up PCIe Resizable BARs flag Hook up edk2 build flag PcdPcieResizableBarSupport to coreboot Kconfig CONFIG_PCIEXP_SUPPORT_RESIZABLE_BARS. Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I5cc12d32c5e132b9f99ec650377d7683377c2a9c Reviewed-on: https://review.coreboot.org/c/coreboot/+/74926 Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Benjamin Doron <benjamin.doron00(a)gmail.com> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/Makefile.inc M payloads/external/edk2/Makefile 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved Benjamin Doron: Looks good to me, approved Sean Rhodes: Looks good to me, approved build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index b88356f..30d82a9 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -184,6 +184,7 @@ CONFIG_EDK2_SD_MMC_TIMEOUT=$(CONFIG_EDK2_SD_MMC_TIMEOUT) \ CONFIG_ECAM_MMCONF_BASE_ADDRESS=$(CONFIG_ECAM_MMCONF_BASE_ADDRESS) \ CONFIG_ECAM_MMCONF_LENGTH=$(CONFIG_ECAM_MMCONF_LENGTH) \ + CONFIG_PCIEXP_SUPPORT_RESIZABLE_BARS=$(CONFIG_PCIEXP_SUPPORT_RESIZABLE_BARS) \ CONFIG_CPU_XTAL_HZ=$(CONFIG_CPU_XTAL_HZ) \ CONFIG_SMMSTORE_V2=$(CONFIG_SMMSTORE_v2) \ CONFIG_EDK2_SECURE_BOOT_SUPPORT=$(CONFIG_EDK2_SECURE_BOOT_SUPPORT) \ diff --git a/payloads/external/edk2/Makefile b/payloads/external/edk2/Makefile index c8d9c9f..ce99ba4 100644 --- a/payloads/external/edk2/Makefile +++ b/payloads/external/edk2/Makefile @@ -115,6 +115,10 @@ ifeq ($(CONFIG_EDK2_SECURE_BOOT_SUPPORT), y) BUILD_STR += -D SECURE_BOOT_ENABLE=TRUE endif +# PCIEXP_SUPPORT_RESIZABLE_BARS = FALSE +ifeq ($(CONFIG_PCIEXP_SUPPORT_RESIZABLE_BARS), y) +BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport=TRUE +endif # # EDKII has the below PCDs that are relevant to coreboot: -- To view, visit https://review.coreboot.org/c/coreboot/+/74926?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cc12d32c5e132b9f99ec650377d7683377c2a9c Gerrit-Change-Number: 74926 Gerrit-PatchSet: 3 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: payloads/edk2: Hook up PCIe Resizable BARs flag
by Stefan Reinauer (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Nico Huber, Sean Rhodes. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74926?usp=email ) Change subject: payloads/edk2: Hook up PCIe Resizable BARs flag ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > Thanks for all the details. I still couldn't imagine any reasonable explanation […] I think this is a reasonable option to be passed through. -- To view, visit https://review.coreboot.org/c/coreboot/+/74926?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cc12d32c5e132b9f99ec650377d7683377c2a9c Gerrit-Change-Number: 74926 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023