coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: Fix tsc_freq_mhz() on some platforms
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49232?usp=email ) Change subject: Fix tsc_freq_mhz() on some platforms ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/49232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic42a057945a48d8bf0641d1418160906cd15a991 Gerrit-Change-Number: 49232 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: Fix tsc_freq_mhz() on some platforms
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Furquan Shaikh, Patrick Rudolph. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49232?usp=email ) Change subject: Fix tsc_freq_mhz() on some platforms ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: What's missing here? -- To view, visit https://review.coreboot.org/c/coreboot/+/49232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic42a057945a48d8bf0641d1418160906cd15a991 Gerrit-Change-Number: 49232 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 10 Jun 2023 00:55:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: util/inteltool: Fix building with musl libc
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50412?usp=email ) Change subject: util/inteltool: Fix building with musl libc ...................................................................... util/inteltool: Fix building with musl libc 1. Make sure __always_inline is defined. 2. To test if we're on Linux, check presence of __linux__ instead of __GLIBC__. Change-Id: I2ccfc4d2ef4c60877e24508f9926b533cffec0ed Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50412 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M util/inteltool/inteltool.h 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 41a9957..986a03c 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -4,6 +4,9 @@ #ifndef INTELTOOL_H #define INTELTOOL_H 1 +#if defined(__linux__) +#include <linux/stddef.h> +#endif #include <arch/mmio.h> #include <commonlib/helpers.h> @@ -17,6 +20,7 @@ #define __DARWIN__ #include <DirectHW/DirectHW.h> #endif + #ifdef __NetBSD__ #include <pciutils/pci.h> #else -- To view, visit https://review.coreboot.org/c/coreboot/+/50412?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ccfc4d2ef4c60877e24508f9926b533cffec0ed Gerrit-Change-Number: 50412 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: util/inteltool: Fix building with musl libc
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Evgeny Zinoviev. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50412?usp=email ) Change subject: util/inteltool: Fix building with musl libc ...................................................................... Patch Set 1: (1 comment) File util/inteltool/inteltool.h: https://review.coreboot.org/c/coreboot/+/50412/comment/028b9a2f_c6c54ca8 : PS1, Line 7: #if defined(__linux__) : #include <linux/stddef.h> : #endif > ``` […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/50412?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ccfc4d2ef4c60877e24508f9926b533cffec0ed Gerrit-Change-Number: 50412 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Sat, 10 Jun 2023 00:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: util/inteltool: Fix building with musl libc
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Evgeny Zinoviev. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50412?usp=email ) Change subject: util/inteltool: Fix building with musl libc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50412?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ccfc4d2ef4c60877e24508f9926b533cffec0ed Gerrit-Change-Number: 50412 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Sat, 10 Jun 2023 00:52:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Add console deinit API, use in SMM handler
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56386?usp=email ) Change subject: Add console deinit API, use in SMM handler ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/56386?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5e51f385f83cb998c244ca1d1ffc10339d3a714 Gerrit-Change-Number: 56386 Gerrit-PatchSet: 11 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Peter Tsung Ho Wu <tsung(a)amazon.com> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: util/inteltool: suggest booting with iomem=relaxed
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63999?usp=email ) Change subject: util/inteltool: suggest booting with iomem=relaxed ...................................................................... util/inteltool: suggest booting with iomem=relaxed Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> Change-Id: Ib80efd7d1ba516cb0ae4bdb86f95877855195ce0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63999 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/inteltool/rootcmplx.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/util/inteltool/rootcmplx.c b/util/inteltool/rootcmplx.c index eee6899..c9703e2 100644 --- a/util/inteltool/rootcmplx.c +++ b/util/inteltool/rootcmplx.c @@ -135,6 +135,7 @@ if (rcba == NULL) { perror("Error mapping RCBA"); + printf("Try booting with iomem=relaxed.\n"); exit(1); } -- To view, visit https://review.coreboot.org/c/coreboot/+/63999?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib80efd7d1ba516cb0ae4bdb86f95877855195ce0 Gerrit-Change-Number: 63999 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: util/inteltool: suggest booting with iomem=relaxed
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Peter Lemenkov. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63999?usp=email ) Change subject: util/inteltool: suggest booting with iomem=relaxed ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63999?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib80efd7d1ba516cb0ae4bdb86f95877855195ce0 Gerrit-Change-Number: 63999 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 00:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add an option to use EDK2 Universal Payload
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/65934?usp=email ) Change subject: payloads/edk2: Add an option to use EDK2 Universal Payload ...................................................................... payloads/edk2: Add an option to use EDK2 Universal Payload This add's an option to use EDK2's Universal Payload instead of the standard UefiPayloadPkg. Universal Payload requires a ShimLayer, to build the required HOBs and pass them to Universal Payload. The ShimLayer is built to encompass UniveralPayload, so only one ELF binary is added to coreboot. Universal Payload is based on Intel's USF specification: https://universalscalablefirmware.github.io/documentation/ This has been added with the repository pointing to https://github.com/starlabsltd. The required ShimLayer patches will be merged into edk2 master once corresponding coreboot patches are merged. This is because the EDK2 engineers believe it is an impossible task to patch coreboot to build and use Universal Payload. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65934 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig 2 files changed, 32 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 30d82a9..85e01b9 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -161,6 +161,7 @@ CONFIG_EDK2_REPOSITORY=$(CONFIG_EDK2_REPOSITORY) \ CONFIG_EDK2_TAG_OR_REV=$(CONFIG_EDK2_TAG_OR_REV) \ CONFIG_EDK2_UEFIPAYLOAD=$(CONFIG_EDK2_UEFIPAYLOAD) \ + CONFIG_EDK2_UNIVERSAL_PAYLOAD=$(CONFIG_EDK2_UNIVERSAL_PAYLOAD) \ CONFIG_EDK2_REPO_OFFICIAL=$(CONFIG_EDK2_REPO_OFFICIAL) \ CONFIG_EDK2_REPO_MRCHROMEBOX=$(CONFIG_EDK2_REPO_MRCHROMEBOX) \ CONFIG_EDK2_REPO_CUSTOM=$(CONFIG_EDK2_REPO_CUSTOM) \ @@ -205,6 +206,7 @@ CONFIG_EDK2_REPOSITORY=$(CONFIG_EDK2_REPOSITORY) \ CONFIG_EDK2_TAG_OR_REV=$(CONFIG_EDK2_TAG_OR_REV) \ CONFIG_EDK2_UEFIPAYLOAD=$(CONFIG_EDK2_UEFIPAYLOAD) \ + CONFIG_EDK2_UNIVERSAL_PAYLOAD=$(CONFIG_EDK2_UNIVERSAL_PAYLOAD) \ CONFIG_EDK2_REPO_OFFICIAL=$(CONFIG_EDK2_REPO_OFFICIAL) \ CONFIG_EDK2_REPO_MRCHROMEBOX=$(CONFIG_EDK2_REPO_MRCHROMEBOX) \ CONFIG_EDK2_REPO_CUSTOM=$(CONFIG_EDK2_REPO_CUSTOM) \ diff --git a/payloads/external/edk2/Kconfig b/payloads/external/edk2/Kconfig index 6dca097..1057c43 100644 --- a/payloads/external/edk2/Kconfig +++ b/payloads/external/edk2/Kconfig @@ -3,15 +3,42 @@ config PAYLOAD_FILE string "edk2 binary" default "$(obj)/UEFIPAYLOAD.fd" if EDK2_UEFIPAYLOAD + default "$(obj)/ShimmedUniversalPayload.elf" if EDK2_UNIVERSAL_PAYLOAD help The result of a UefiPayloadPkg build +choice + prompt "EDK II build type" + default EDK2_UEFIPAYLOAD + help + Select the build type for edk2. UniversalPayload is recommended, as it is + replacing UefiPayloadPkg. Whilst in the transition phase between the two, + both options exist. + config EDK2_UEFIPAYLOAD bool "Build UefiPayloadPkg" - default y help Build the standard UefiPayloadPkg +config EDK2_UNIVERSAL_PAYLOAD + bool "Build Universal Payload" + help + Select this option if you want to build a coreboot image + with EDK2s Universal Payload. If you don't know what this is + about, just leave it enabled. + + Universal Payload should ideally only be built from upstream EDK2, + https://github.com/tianocore/edk2, as this is regularly build tested + and it encourages patches to be merged upstream. + + Whilst the required patches are being merged, this is pointed to + Star Labs GitHub repository which contains these patches and is based + on a known working commit. + + See https://universalscalablefirmware.github.io/documentation/ for more information. + +endchoice + choice prompt "Tianocore's EDK II payload" default EDK2_REPO_MRCHROMEBOX @@ -44,6 +71,7 @@ config EDK2_REPOSITORY string "URL to git repository for edk2" + default "https://github.com/starlabsltd/edk2" if EDK2_UNIVERSAL_PAYLOAD default "https://github.com/mrchromebox/edk2" if EDK2_REPO_MRCHROMEBOX default "https://github.com/tianocore/edk2" if EDK2_REPO_OFFICIAL default "" if EDK2_REPO_CUSTOM @@ -54,6 +82,7 @@ config EDK2_TAG_OR_REV string "Insert a commit's SHA-1 or a branch name" default "origin/uefipayload_202304" if EDK2_REPO_MRCHROMEBOX + default "origin/universalpayload" if EDK2_UNIVERSAL_PAYLOAD default "origin/master" if EDK2_REPO_OFFICIAL default "" if EDK2_REPO_CUSTOM help -- To view, visit https://review.coreboot.org/c/coreboot/+/65934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 Gerrit-Change-Number: 65934 Gerrit-PatchSet: 51 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: payloads/edk2: Add an option to use EDK2 Universal Payload
by Stefan Reinauer (Code Review) 10 Jun '23

10 Jun '23

Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Rudolph, Sean Rhodes. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65934?usp=email ) Change subject: payloads/edk2: Add an option to use EDK2 Universal Payload ...................................................................... Patch Set 50: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/65934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 Gerrit-Change-Number: 65934 Gerrit-PatchSet: 50 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sat, 10 Jun 2023 00:16:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023