coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: Disable storage devices based on fw_config
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Derek Huang, Felix Held, Henry Sun, Mark Hsieh, Reka Norman, Sam McNally, Shou-Chieh Hsu, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75743?usp=email ) Change subject: mb/google/nissa/var/joxer: Disable storage devices based on fw_config ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75743/comment/df159f30_f01d25be : PS1, Line 11: this (it : disables all probed devices when fw_config is unprovisioned). Please add the period after *this* and another before the ). File src/mainboard/google/brya/variants/joxer/Makefile.inc: https://review.coreboot.org/c/coreboot/+/75743/comment/3d8b60b6_f42aa926 : PS1, Line 3: bootblock-y += variant.c Please mention the removal in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/75743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6920d88dfec86676ff6733146f748e06d4085c49 Gerrit-Change-Number: 75743 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 13:37:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
by Jan Samek (Code Review) 09 Jun '23

09 Jun '23

Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433?usp=email ) Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) ...................................................................... Patch Set 17: (1 comment) File src/drivers/i2c/pi608gp/pi608gp.c: https://review.coreboot.org/c/coreboot/+/74433/comment/6bbb19d7_29746bb5 : PS17, Line 59: if (allowed[i].lvl == level_mv.lvl && allowed[i].lvl_10 == level_mv.lvl_10) > Doesn't look like it (to me it would look like C++ behavior): […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74433?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Gerrit-Change-Number: 74433 Gerrit-PatchSet: 17 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 13:33:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/joxer: Disable storage devices based on fw_config
by Mark Hsieh (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Derek Huang, Felix Held, Henry Sun, Reka Norman, Sam McNally, Shou-Chieh Hsu. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75743?usp=email ) Change subject: mb/google/nissa/var/joxer: Disable storage devices based on fw_config ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/75743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6920d88dfec86676ff6733146f748e06d4085c49 Gerrit-Change-Number: 75743 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 13:30:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: soc/mediatek/mt8183: Force reduce DRAM speed for debug[DONOT MERGE]
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Hung-Te Lin, Yidi Lin, huayang duan. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/40284?usp=email ) Change subject: soc/mediatek/mt8183: Force reduce DRAM speed for debug[DONOT MERGE] ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please abandon, if it’s not needed anymore. -- To view, visit https://review.coreboot.org/c/blobs/+/40284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I008361b0799215f227c3f78d222b58c04ab8c806 Gerrit-Change-Number: 40284 Gerrit-PatchSet: 1 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Duan huayang <huayang.duan(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: huayang duan <huayangduan(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 13:11:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/spr-sp: Remove HWP related settings
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Tim Chu, Ziang Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75741?usp=email ) Change subject: soc/intel/spr-sp: Remove HWP related settings ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75741/comment/cba4159c_f50f8036 : PS1, Line 2: wanghao11 Please use your full name and not the user name: $ git config --global user.name "Wang Hao" # if correct $ git commit --amend --author="Wang Hao <wanghao11(a)inspur.com>" -s https://review.coreboot.org/c/coreboot/+/75741/comment/ab260a93_7a6e4059 : PS1, Line 11: coreboot tries to be as much as independent from FSP as possible. What is the downside of doing this in coreboot (possible again)? https://review.coreboot.org/c/coreboot/+/75741/comment/1e65aec5_8917ea0b : PS1, Line 13: wanghao11 Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/75741?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4ff63cbff0dffb4cd65fdfa814eda85964130ee Gerrit-Change-Number: 75741 Gerrit-PatchSet: 1 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 11:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Yiwei Tang, Ziang Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75739?usp=email ) Change subject: drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init ...................................................................... Patch Set 2: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75739/comment/04f9afb9_08303387 : PS2, Line 9: our test Please elaborate, how you tested things. https://review.coreboot.org/c/coreboot/+/75739/comment/719683d9_db8cf507 : PS2, Line 9: fails How exactly? https://review.coreboot.org/c/coreboot/+/75739/comment/e000da48_d510b039 : PS2, Line 10: this retry mechanism Please elaborate. How many tries, and why did you choose this heuristic? https://review.coreboot.org/c/coreboot/+/75739/comment/a74cea63_b9fdc21a : PS2, Line 13: Signed-off-by: wanghao11 <wanghao11(a)inspur.com> Please use the full name. Patchset: PS2: Please elaborate much more in the commit message. File src/drivers/ipmi/ipmi_kcs_ops.c: https://review.coreboot.org/c/coreboot/+/75739/comment/2fbab825_5fe6b35f : PS2, Line 124: if (!wait_ms(IPMI_GET_DID_RETRY_MS, !ipmi_get_device_id(dev, &rsp))) { : printk(BIOS_ERR, "IPMI: BMC does not respond to get device id even " : "after %d ms.\n", IPMI_GET_DID_RETRY_MS); : dev->enabled = 0; : return; : } Isn’t this code trying to do exactly the same, and shouldn’t you need to just increase IPMI_GET_DID_RETRY_MS? https://review.coreboot.org/c/coreboot/+/75739/comment/db1d10b4_28108846 : PS2, Line 139: mdelay(1000); That’s too much of a delay for coreboot. -- To view, visit https://review.coreboot.org/c/coreboot/+/75739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b2b15170c3ac9785b6e1cc7f93738f7badc7435 Gerrit-Change-Number: 75739 Gerrit-PatchSet: 2 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yiwei Tang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Yiwei Tang Gerrit-Comment-Date: Fri, 09 Jun 2023 11:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/xeon_sp: Fix HEST table length
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, Jeff Li, Johnny Lin, Tim Chu, Yiwei Tang, Ziang Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75738?usp=email ) Change subject: soc/intel/xeon_sp: Fix HEST table length ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75738/comment/faf924a8_7103a1e6 : PS1, Line 11: Please document, how you found the error and how you tested it. -- To view, visit https://review.coreboot.org/c/coreboot/+/75738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db Gerrit-Change-Number: 75738 Gerrit-PatchSet: 1 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yiwei Tang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yiwei Tang Gerrit-Attention: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 11:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/xeon_sp/spr: Fix memory max capacity per processor
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Singer, Patrick Rudolph, Tim Chu, Ziang Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75740?usp=email ) Change subject: soc/intel/xeon_sp/spr: Fix memory max capacity per processor ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75740/comment/e1752ec5_3d11bdf9 : PS1, Line 2: wanghao11 Please use your full name and not the user name: $ git config --global user.name "Wang Hao" # if correct $ git commit --amend --author="Wang Hao <wanghao11(a)inspur.com>" -s https://review.coreboot.org/c/coreboot/+/75740/comment/b34026d4_95f36a43 : PS1, Line 10: Was there a user visible problem? If yes, please describe it, and also document how you tested your fix. https://review.coreboot.org/c/coreboot/+/75740/comment/eb551238_11af8265 : PS1, Line 12: Signed-off-by: wanghao11 <wanghao11(a)inspur.com> Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/75740?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb892d3b148291b35808d634d63b58b90d456767 Gerrit-Change-Number: 75740 Gerrit-PatchSet: 1 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 11:49:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[NoOp] Change in blobs[main]: cpu/intel: update model 306ax microcode from 0x20 to 0x21
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Martin Kepplinger. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/32166?usp=email ) Change subject: cpu/intel: update model 306ax microcode from 0x20 to 0x21 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Any idea, if this is fixed now? -- To view, visit https://review.coreboot.org/c/blobs/+/32166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I4513e06019d833262bc7e3afb38c88f145eb5525 Gerrit-Change-Number: 32166 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin Kepplinger <martink(a)posteo.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 11:03:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/xeon_sp: Fix HEST table length
by Nico Huber (Code Review) 09 Jun '23

09 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, Jeff Li, Johnny Lin, Paul Menzel, Tim Chu, Yiwei Tang, Ziang Wang. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75738?usp=email ) Change subject: soc/intel/xeon_sp: Fix HEST table length ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: The change looks correct and the surrounding code should work. I have serious doubts, though, that it would pass ubsan. -- To view, visit https://review.coreboot.org/c/coreboot/+/75738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db Gerrit-Change-Number: 75738 Gerrit-PatchSet: 1 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yiwei Tang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yiwei Tang Gerrit-Attention: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 10:35:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023