Hello Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58421?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: ChromeOS: Move CRHW device object
......................................................................
ChromeOS: Move CRHW device object
In ACPI spec all Device Objects should be located
under \_SB. So \CRHW was not allowed.
The allocation is no longer GNVS but was renamed
to CNVS and it is not globally available for ASL.
Change-Id: I449d0206fbaee94cea99f745cf297ad293e8306c
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/vendorcode/google/chromeos/acpi/chromeos.asl
D src/vendorcode/google/chromeos/acpi/gnvs.asl
M src/vendorcode/google/chromeos/acpi/ramoops.asl
M src/vendorcode/google/chromeos/gnvs.c
4 files changed, 108 insertions(+), 112 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/58421/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/58421?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I449d0206fbaee94cea99f745cf297ad293e8306c
Gerrit-Change-Number: 58421
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Rui Zhou, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75832?usp=email )
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
@Subrata, probably we should change TBT to 1..4 not 0..3 to match the TCSS usb?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 12:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Rui Zhou, Subrata Banik, Tarun Tuli.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75832?usp=email )
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75832/comment/696e6525_36dd2938 :
PS1, Line 245: device ref tbt_pcie_rp1 on end
: device ref tbt_pcie_rp3 on end
> no,rp0 missed modify,screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 11:56:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Rui Zhou, Subrata Banik, Tarun Tuli.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75832?usp=email )
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75832/comment/fc37bb7a_f852ffa7 :
PS1, Line 245: device ref tbt_pcie_rp1 on end
: device ref tbt_pcie_rp3 on end
> i thought screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3 […]
no,rp0 missed modify,screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 11:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli.
Rui Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75832?usp=email )
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75832/comment/275a4de7_d20e9c0d :
PS1, Line 245: device ref tbt_pcie_rp1 on end
: device ref tbt_pcie_rp3 on end
> i thought screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3 […]
No,rp0 missed modify,screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 11:54:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli.
Hello Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75832?usp=email
to look at the new patch set (#6).
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
rp0/rp2 change to rp1/rp3 for TCP1 and TCP3
BUG=b:286187816
BRANCH=none
TEST=emerge-rex coreboot and verify TBT works.
Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/75832/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli.
Hello Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75832?usp=email
to look at the new patch set (#5).
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
rp0/rp2 change to rp1/rp3 for TCP1 and TCP3
BUG=b:286187816
BRANCH=none
TEST=emerge-rex coreboot and verify TBT works.
Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/75832/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 5
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli.
Hello Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75832?usp=email
to look at the new patch set (#4).
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
rp0/rp2 change to both rp1/rp3 for TCP1 and TCP3
BUG=b:286187816
BRANCH=none
TEST=emerge-rex coreboot and verify TBT works.
Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/75832/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 4
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli.
Hello Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75832?usp=email
to look at the new patch set (#3).
Change subject: mb/google/rex/var/screebo: both rp0 and rp2 change to both rp1 and rp3
......................................................................
mb/google/rex/var/screebo: both rp0 and rp2 change to both rp1 and rp3
both rp0 and rp2 change to both rp1 and rp3 for TCP1 and TCP3
BUG=b:286187816
BRANCH=none
TEST=emerge-rex coreboot and verify TBT works.
Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/75832/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 3
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset