coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tuning SX9324 register for pujjoteen5
by Paul Menzel (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Derek Huang, Leo Chou, Shou-Chieh Hsu, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75900?usp=email ) Change subject: mb/google/nissa/var/pujjo: Tuning SX9324 register for pujjoteen5 ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75900/comment/f7977fbe_8a7a3773 : PS4, Line 7: Tuning Imperative mood: Tune https://review.coreboot.org/c/coreboot/+/75900/comment/8d27bd71_aaf93f7a : PS4, Line 10: P-sensor vendor Who is that? https://review.coreboot.org/c/coreboot/+/75900/comment/2aa74197_c54b2ba2 : PS4, Line 13: TEST=i2cdump -y -f 13 0x28 on Pujjoteen5 What is the output? https://review.coreboot.org/c/coreboot/+/75900/comment/318f4fe5_89e1cd76 : PS4, Line 14: What user visible change is visible? -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 4 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 07:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: vc/intel/edk2: Remove edk2-stable202111 support
by Sridhar Siricilla (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Ronak Kanabar, Subrata Banik. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75817?usp=email ) Change subject: vc/intel/edk2: Remove edk2-stable202111 support ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: UDK_202111_VERSION is going to be stale after EDK2-stable202202 is in. -- To view, visit https://review.coreboot.org/c/coreboot/+/75817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide1864e0a42a4c0a81c3c94b1b1254f8fad062af Gerrit-Change-Number: 75817 Gerrit-PatchSet: 3 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: ec/google/chromeec: Use mux_conn to get the right USB port
by Subrata Banik (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Eric Lai, Kapil Porwal, Tarun Tuli, Tim Wawrzynczak. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75824?usp=email ) Change subject: ec/google/chromeec: Use mux_conn to get the right USB port ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75824?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I058c6cc0fea6758bfaafdd163b5da2c7f75daf8a Gerrit-Change-Number: 75824 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 05:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts
by 9elements QA (Code Review) 17 Jun '23

17 Jun '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email ) Change subject: mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/169374 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/169372 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/169371 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/169370 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/169369 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/169368 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/169367 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/169366 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/169365 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/169364 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/169363 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/169362 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/169361 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/169360 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/169359 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/169358 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70 Gerrit-Change-Number: 75834 Gerrit-PatchSet: 4 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 03:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tuning SX9324 register for pujjoteen5
by Leo Chou (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Derek Huang, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Shou-Chieh Hsu, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75900?usp=email to look at the new patch set (#4). Change subject: mb/google/nissa/var/pujjo: Tuning SX9324 register for pujjoteen5 ...................................................................... mb/google/nissa/var/pujjo: Tuning SX9324 register for pujjoteen5 Update SX9324 register settings based on tuning value from P-sensor vendor. BUG=b:27951075 TEST=i2cdump -y -f 13 0x28 on Pujjoteen5 Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75900/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 4 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5
by Leo Chou (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Derek Huang, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Shou-Chieh Hsu, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75900?usp=email to look at the new patch set (#3). Change subject: mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5 ...................................................................... mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5 Update SX9324 register settings based on tuning value from P-sensor vendor. BUG=b:27951075 TEST=i2cdump -y -f 13 0x28 on Pujjoteen5 Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75900/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 3 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5
by Leo Chou (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Derek Huang, Shou-Chieh Hsu, Tarun Tuli. Leo Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75900?usp=email ) Change subject: mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5 ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 2 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 03:07:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5
by Leo Chou (Code Review) 17 Jun '23

17 Jun '23

Leo Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75900?usp=email ) Change subject: mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5 ...................................................................... mb/google/nissa/var/pujjo: Tunning SX9324 register for pujjoteen5 Update SX9324 register settings based on tunning value from P-sensor vendor. BUG=b:27951075 TEST=i2cdump -y -f 13 0x28 on Pujjoteen5 Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75900/1 diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb index 9a822d6..4ff0e56 100644 --- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb @@ -460,6 +460,80 @@ probe LTE LTE_PRESENT end end + chip drivers/i2c/sx9324 + register "desc" = ""SAR Proximity Sensor"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_H19_IRQ)" + register "speed" = "I2C_SPEED_FAST" + register "uid" = "1" + register "reg_gnrl_ctrl0" = "0x16" + register "reg_gnrl_ctrl1" = "0x25" + register "reg_afe_ctrl0" = "0x20" + register "reg_afe_ctrl1" = "0x10" + register "reg_afe_ctrl2" = "0x00" + register "reg_afe_ctrl3" = "0x00" + register "reg_afe_ctrl4" = "0x47" + register "reg_afe_ctrl5" = "0x00" + register "reg_afe_ctrl6" = "0x00" + register "reg_afe_ctrl7" = "0x47" + register "reg_afe_ctrl8" = "0x12" + register "reg_afe_ctrl9" = "0x08" + register "reg_afe_ph0" = "0x3d" + register "reg_afe_ph1" = "0x3f" + register "reg_afe_ph2" = "0x37" + register "reg_afe_ph3" = "0x3f" + register "reg_prox_ctrl0" = "0x09" + register "reg_prox_ctrl1" = "0x13" + register "reg_prox_ctrl2" = "0x20" + register "reg_prox_ctrl3" = "0x60" + register "reg_prox_ctrl4" = "0x0c" + register "reg_prox_ctrl5" = "0x00" + register "reg_prox_ctrl6" = "0x20" + register "reg_prox_ctrl7" = "0x20" + register "reg_adv_ctrl0" = "0x00" + register "reg_adv_ctrl1" = "0x00" + register "reg_adv_ctrl2" = "0x00" + register "reg_adv_ctrl3" = "0x00" + register "reg_adv_ctrl4" = "0x00" + register "reg_adv_ctrl5" = "0x05" + register "reg_adv_ctrl6" = "0x00" + register "reg_adv_ctrl7" = "0x00" + register "reg_adv_ctrl8" = "0x00" + register "reg_adv_ctrl9" = "0x00" + register "reg_adv_ctrl10" = "0x00" + register "reg_adv_ctrl11" = "0x00" + register "reg_adv_ctrl12" = "0x00" + register "reg_adv_ctrl13" = "0x00" + register "reg_adv_ctrl14" = "0x80" + register "reg_adv_ctrl15" = "0x0c" + register "reg_adv_ctrl16" = "0x04" + register "reg_adv_ctrl17" = "0xff" + register "reg_adv_ctrl18" = "0x35" + register "reg_adv_ctrl19" = "0x00" + register "reg_adv_ctrl20" = "0x00" + register "reg_irq_msk" = "0x60" + register "reg_irq_cfg0" = "0x00" + register "reg_irq_cfg1" = "0x80" + register "reg_irq_cfg2" = "0x00" + + register "ph0_pin" = "{1, 3, 3}" + register "ph1_pin" = "{3, 3, 3}" + register "ph2_pin" = "{3, 1, 3}" + register "ph3_pin" = "{3, 3, 3}" + register "ph01_resolution" = "1024" + register "ph23_resolution" = "1024" + register "startup_sensor" = "1" + register "ph01_proxraw_strength" = "3" + register "ph23_proxraw_strength" = "3" + register "avg_pos_strength" = "256" + register "cs_idle_sleep" = ""gnd"" + register "int_comp_resistor" = ""lowest"" + register "input_precharge_resistor_ohms" = "4000" + register "input_analog_gain" = "1" + device i2c 28 on + probe WWAN_5G WWAN_5G_PRESENT + end + end + end device ref i2c3 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 1 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: docs/flashmap: Document available flashmap flags
by Eric Lai (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Hung-Te Lin. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75850?usp=email ) Change subject: docs/flashmap: Document available flashmap flags ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75850/comment/eca45b94_def730ea : PS1, Line 10: https://review.coreboot.org/c/coreboot/+/31766. please use commit hash format. -- To view, visit https://review.coreboot.org/c/coreboot/+/75850?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iada0fcb0ada1573acfbb51b5f6bf723fb8b68ba8 Gerrit-Change-Number: 75850 Gerrit-PatchSet: 1 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Sat, 17 Jun 2023 02:45:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lib/fw_config: Make fw_config_is_provisioned() always available
by Eric Lai (Code Review) 17 Jun '23

17 Jun '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75835?usp=email ) Change subject: lib/fw_config: Make fw_config_is_provisioned() always available ...................................................................... lib/fw_config: Make fw_config_is_provisioned() always available Move fw_config_is_provisioned() implementation to header file and make it static inline. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I2ea21b19339cd93ba78dbe25213cbfb40e012937 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75835 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/include/fw_config.h M src/lib/fw_config.c 2 files changed, 10 insertions(+), 11 deletions(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, but someone else must approve diff --git a/src/include/fw_config.h b/src/include/fw_config.h index 9f5e4b8..1e1652e 100644 --- a/src/include/fw_config.h +++ b/src/include/fw_config.h @@ -49,6 +49,16 @@ */ uint64_t fw_config_get(void); +/** + * fw_config_is_provisioned() - Determine if FW_CONFIG has been provisioned. + * Return %true if FW_CONFIG has been provisioned, %false otherwise. + */ +static inline bool fw_config_is_provisioned(void) +{ + return fw_config_get() != UNDEFINED_FW_CONFIG; +} + + #if CONFIG(FW_CONFIG) /** @@ -77,12 +87,6 @@ void fw_config_for_each_found(void (*cb)(const struct fw_config *config, void *arg), void *arg); /** - * fw_config_is_provisioned() - Determine if FW_CONFIG has been provisioned. - * Return %true if FW_CONFIG has been provisioned, %false otherwise. - */ -bool fw_config_is_provisioned(void); - -/** * fw_config_get_found() - Return a pointer to the fw_config struct for a given field. * @field_mask: A field mask from static.h, e.g., FW_CONFIG_FIELD_FEATURE_MASK * diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index e1fbe74..268be07 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -95,11 +95,6 @@ return false; } -bool fw_config_is_provisioned(void) -{ - return fw_config_get() != UNDEFINED_FW_CONFIG; -} - bool fw_config_probe_dev(const struct device *dev, const struct fw_config **matching_probe) { const struct fw_config *probe; -- To view, visit https://review.coreboot.org/c/coreboot/+/75835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ea21b19339cd93ba78dbe25213cbfb40e012937 Gerrit-Change-Number: 75835 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023