coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: acpi: Add SPCR table
by Lean Sheng Tan (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Lance Zhao, Nico Huber, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email ) Change subject: acpi: Add SPCR table ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64e624c17a27b9215a8ba83bd6cbb2c0a7aa1dfc Gerrit-Change-Number: 75685 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 17 Jun 2023 13:15:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: acpi/acpi.c: Fix printing all ACPI tables
by Lean Sheng Tan (Code Review) 17 Jun '23

17 Jun '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75860?usp=email ) Change subject: acpi/acpi.c: Fix printing all ACPI tables ...................................................................... acpi/acpi.c: Fix printing all ACPI tables Loop over tables in xsdt instead of maintaining a list of local variables to loop over. Some tables were not generated directly in the write_acpi_tables function, like IVRS or SRAT. Now those tables are printed too and the code is simpler. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ie0a6e2b6e2b72b5c8f59e730bea9b51007b507b6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75860 Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Marvin Drees <marvin.drees(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/acpi/acpi.c 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Marvin Drees: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved Felix Held: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index aa1cd1c..78135d7 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -2136,12 +2136,8 @@ if (CONFIG(DEBUG_ACPICA_COMPATIBLE)) { printk(BIOS_DEBUG, "Printing ACPI tables in ACPICA compatible format\n"); - void *acpi_tables[] = { rsdt, xsdt, fadt, facs, slic, ssdt, dsdt, - mcfg, tcpa, tpm2, madt, lpit, bert }; - for (size_t i = 0; i < ARRAY_SIZE(acpi_tables); i++) { - if (acpi_tables[i] == NULL) - continue; - acpidump_print(acpi_tables[i]); + for (size_t i = 0; xsdt->entry[i] != 0; i++) { + acpidump_print((void *)(uintptr_t)xsdt->entry[i]); } printk(BIOS_DEBUG, "Done printing ACPI tables in ACPICA compatible format\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/75860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0a6e2b6e2b72b5c8f59e730bea9b51007b507b6 Gerrit-Change-Number: 75860 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: Makefile.inc: Compress DSDT file
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Martin L Roth, Subrata Banik. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75905?usp=email ) Change subject: Makefile.inc: Compress DSDT file ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: This might squize a ms or so of the boottime depending on the speed of the bootmedium ;-) -- To view, visit https://review.coreboot.org/c/coreboot/+/75905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f555b1761c7ef4943d8de447ab299684403214b Gerrit-Change-Number: 75905 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 12:54:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: UNTESTED acpi: Load DSDT directly into target location
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Hello Lance Zhao, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75904?usp=email to look at the new patch set (#3). Change subject: UNTESTED acpi: Load DSDT directly into target location ...................................................................... UNTESTED acpi: Load DSDT directly into target location Instead of first mapping DSDT and then copying it into the target location, load it straight away. This changes DSDT injections to be appended to DSDT file instead of prepended. TOTEST: This is likely ok? Test on chromeos platform. This makes compressing DSDT possible on platforms where cbfs_map only does return a pointer to a memory mapped medium. On platforms that are not doing memory mapping this avoid copying DSDT twice in memory (first cbfs_map, second memcpy to current). TESTED work on Foxconn G41M. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb --- M src/acpi/acpi.c 1 file changed, 43 insertions(+), 48 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/75904/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/75904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb Gerrit-Change-Number: 75904 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: UNTESTED acpi: Load DSDT directly into target location
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Hello Lance Zhao, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75904?usp=email to look at the new patch set (#2). Change subject: UNTESTED acpi: Load DSDT directly into target location ...................................................................... UNTESTED acpi: Load DSDT directly into target location Instead of first mapping DSDT and then copying it into the target location, load it straight away. This changes DSDT injections to be appended to DSDT file instead of prepended. TOTEST: This is likely ok? Test on chromeos platform. This makes compressing DSDT possible on platforms where cbfs_map only does return a pointer to a memory mapped medium. TESTED work on Foxconn G41M. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb --- M src/acpi/acpi.c 1 file changed, 43 insertions(+), 48 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/75904/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb Gerrit-Change-Number: 75904 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: Makefile.inc: Compress DSDT file
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Martin L Roth. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75905?usp=email ) Change subject: Makefile.inc: Compress DSDT file ...................................................................... Makefile.inc: Compress DSDT file Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I3f555b1761c7ef4943d8de447ab299684403214b --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/75905/1 diff --git a/Makefile.inc b/Makefile.inc index b35ec86..f1e0c99 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -281,7 +281,7 @@ define asl_template $(CONFIG_CBFS_PREFIX)/$(1).aml-file = $(obj)/$(1).aml $(CONFIG_CBFS_PREFIX)/$(1).aml-type = raw -$(CONFIG_CBFS_PREFIX)/$(1).aml-compression = none +$(CONFIG_CBFS_PREFIX)/$(1).aml-compression = LZMA ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA),y) $(CONFIG_CBFS_PREFIX)/$(1).aml-align = 64 endif -- To view, visit https://review.coreboot.org/c/coreboot/+/75905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f555b1761c7ef4943d8de447ab299684403214b Gerrit-Change-Number: 75905 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: UNTESTED acpi: Load DSDT directly into target location
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75904?usp=email ) Change subject: UNTESTED acpi: Load DSDT directly into target location ...................................................................... UNTESTED acpi: Load DSDT directly into target location Instead of first mapping DSDT and then copying it into the target location, load it straight away. This changes DSDT injections to be appended to DSDT file instead of prepended. TOTEST: is this ok? Test on chromeos platform. This makes compressing DSDT possible on platforms where cbfs_map only does return a pointer to a memory mapped medium. TESTED work on Foxconn G41M. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb --- M src/acpi/acpi.c 1 file changed, 43 insertions(+), 48 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/75904/1 diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index d8988ea..04f100f 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1864,7 +1864,7 @@ acpi_facs_t *facs = NULL; acpi_header_t *slic_file, *slic = NULL; acpi_header_t *ssdt = NULL; - acpi_header_t *dsdt_file, *dsdt = NULL; + acpi_header_t *dsdt = NULL; acpi_mcfg_t *mcfg = NULL; acpi_tcpa_t *tcpa = NULL; acpi_tpm2_t *tpm2 = NULL; @@ -1873,7 +1873,7 @@ acpi_bert_t *bert = NULL; struct device *dev; unsigned long fw; - size_t slic_size, dsdt_size; + size_t slic_size; char oem_id[6], oem_table_id[8]; current = start; @@ -1928,20 +1928,6 @@ return fw; } - dsdt_file = cbfs_map(CONFIG_CBFS_PREFIX "/dsdt.aml", &dsdt_size); - if (!dsdt_file) { - printk(BIOS_ERR, "No DSDT file, skipping ACPI tables\n"); - return start; - } - - if (dsdt_file->length > dsdt_size - || dsdt_file->length < sizeof(acpi_header_t) - || memcmp(dsdt_file->signature, "DSDT", 4) != 0) { - printk(BIOS_ERR, "Invalid DSDT file, skipping ACPI tables\n"); - cbfs_unmap(dsdt_file); - return start; - } - slic_file = cbfs_map(CONFIG_CBFS_PREFIX "/slic", &slic_size); if (slic_file && (slic_file->length > slic_size @@ -1990,33 +1976,50 @@ printk(BIOS_DEBUG, "ACPI: * DSDT\n"); dsdt = (acpi_header_t *)current; - memcpy(dsdt, dsdt_file, sizeof(acpi_header_t)); - if (dsdt->length >= sizeof(acpi_header_t)) { - current += sizeof(acpi_header_t); - acpigen_set_current((char *)current); - - if (CONFIG(ACPI_SOC_NVS)) - acpi_fill_gnvs(); - if (CONFIG(CHROMEOS_NVS)) - acpi_fill_cnvs(); - - for (dev = all_devices; dev; dev = dev->next) - if (dev->ops && dev->ops->acpi_inject_dsdt) - dev->ops->acpi_inject_dsdt(dev); - current = (unsigned long)acpigen_get_current(); - memcpy((char *)current, - (char *)dsdt_file + sizeof(acpi_header_t), - dsdt->length - sizeof(acpi_header_t)); - current += dsdt->length - sizeof(acpi_header_t); - - /* (Re)calculate length and checksum. */ - dsdt->length = current - (unsigned long)dsdt; - dsdt->checksum = 0; - dsdt->checksum = acpi_checksum((void *)dsdt, dsdt->length); +#define DSDT_SIZE_LIM (256 * KiB) + if (cbfs_get_size(CONFIG_CBFS_PREFIX "/dsdt.aml") > DSDT_SIZE_LIM) { + printk(BIOS_ERR, "DSDT file too large, increase DSDT_SIZE_LIM, skipping ACPI tables\n"); + /* clear all table memory */ + memset((void *)start, 0, current - start); + return start; } - current = acpi_align_current(current); + + const size_t dsdt_size = cbfs_load(CONFIG_CBFS_PREFIX "/dsdt.aml", dsdt, DSDT_SIZE_LIM); + if (dsdt_size == 0) { + printk(BIOS_ERR, "No DSDT file or unable to load, skipping ACPI tables\n"); + /* clear all table memory */ + memset((void *)start, 0, current - start); + return start; + } + + if (dsdt->length < sizeof(acpi_header_t) + || memcmp(dsdt->signature, "DSDT", 4) != 0) { + printk(BIOS_ERR, "Invalid DSDT file, skipping ACPI tables\n"); + /* clear all table memory */ + memset((void *)start, 0, current - start); + return start; + } + + current += dsdt->length; + + acpigen_set_current((char *)current); + + if (CONFIG(ACPI_SOC_NVS)) + acpi_fill_gnvs(); + if (CONFIG(CHROMEOS_NVS)) + acpi_fill_cnvs(); + + for (dev = all_devices; dev; dev = dev->next) + if (dev->ops && dev->ops->acpi_inject_dsdt) + dev->ops->acpi_inject_dsdt(dev); + + /* (Re)calculate length and checksum. */ + current = (unsigned long)acpigen_get_current(); + dsdt->length = current - (unsigned long)dsdt; + dsdt->checksum = 0; + dsdt->checksum = acpi_checksum((void *)dsdt, dsdt->length); printk(BIOS_DEBUG, "ACPI: * FADT\n"); fadt = (acpi_fadt_t *)current; @@ -2036,14 +2039,6 @@ cbfs_unmap(slic_file); } - /* - * cbfs_unmap() uses mem_pool_free() which works correctly only - * if freeing is done in reverse order than memory allocation. - * This is why unmapping of dsdt_file must be done after - * unmapping slic file. - */ - cbfs_unmap(dsdt_file); - printk(BIOS_DEBUG, "ACPI: * SSDT\n"); ssdt = (acpi_header_t *)current; acpi_create_ssdt_generator(ssdt, ACPI_TABLE_CREATOR); -- To view, visit https://review.coreboot.org/c/coreboot/+/75904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb Gerrit-Change-Number: 75904 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: acpi/acpi.c: Return function argument when bailing out
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75903?usp=email ) Change subject: acpi/acpi.c: Return function argument when bailing out ...................................................................... acpi/acpi.c: Return function argument when bailing out Returning a constant value makes the function easier to read and think about. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ifdf7acec38a7c958aac2cf1f3bbf16c27fa90b8c --- M src/acpi/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/75903/1 diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 9b4dafa..d8988ea 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1931,7 +1931,7 @@ dsdt_file = cbfs_map(CONFIG_CBFS_PREFIX "/dsdt.aml", &dsdt_size); if (!dsdt_file) { printk(BIOS_ERR, "No DSDT file, skipping ACPI tables\n"); - return current; + return start; } if (dsdt_file->length > dsdt_size @@ -1939,7 +1939,7 @@ || memcmp(dsdt_file->signature, "DSDT", 4) != 0) { printk(BIOS_ERR, "Invalid DSDT file, skipping ACPI tables\n"); cbfs_unmap(dsdt_file); - return current; + return start; } slic_file = cbfs_map(CONFIG_CBFS_PREFIX "/slic", &slic_size); -- To view, visit https://review.coreboot.org/c/coreboot/+/75903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdf7acec38a7c958aac2cf1f3bbf16c27fa90b8c Gerrit-Change-Number: 75903 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: acpi/acpi.c: Change signature of write_acpi_tables
by Arthur Heymans (Code Review) 17 Jun '23

17 Jun '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75902?usp=email ) Change subject: acpi/acpi.c: Change signature of write_acpi_tables ...................................................................... acpi/acpi.c: Change signature of write_acpi_tables The argument is copied into current and is never modified. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I3084e43ccbe9749bc726af3120decfe8b52e1709 --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/75902/1 diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index aa1cd1c..9b4dafa 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1854,7 +1854,7 @@ printk(BIOS_SPEW, "\n"); } -unsigned long write_acpi_tables(unsigned long start) +unsigned long write_acpi_tables(const unsigned long start) { unsigned long current; acpi_rsdp_t *rsdp; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 09e1211..d3f209a 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1335,7 +1335,7 @@ /* These are implemented by the target port or north/southbridge. */ void preload_acpi_dsdt(void); -unsigned long write_acpi_tables(unsigned long addr); +unsigned long write_acpi_tables(const unsigned long addr); unsigned long acpi_fill_madt(unsigned long current); void acpi_fill_fadt(acpi_fadt_t *fadt); -- To view, visit https://review.coreboot.org/c/coreboot/+/75902?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3084e43ccbe9749bc726af3120decfe8b52e1709 Gerrit-Change-Number: 75902 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/hp: Add new port for compaq_8300_elite_usdt
by Riku Viitanen (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Kyösti Mälkki. Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906?usp=email ) Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ...................................................................... Patch Set 5: (2 comments) File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74906/comment/827834f5_c6811381 : PS1, Line 9: register "gen2_dec" = "0x00fc0801" > The latter seems like reasonable I/O decode for 0x800. […] I have no idea. These magic numbers were decided by autoport. Can you help me figure out if they need changing? https://review.coreboot.org/c/coreboot/+/74906/comment/8418aa26_d4ae4c7a : PS1, Line 80: io 0x60 = 0x600 > LPC decode required from 0x600 How would I go about adding that? I'm a complete n00b. -- To view, visit https://review.coreboot.org/c/coreboot/+/74906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3 Gerrit-Change-Number: 74906 Gerrit-PatchSet: 5 Gerrit-Owner: Riku Viitanen Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 12:40:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023