coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value.
by Erin Park (Code Review) 18 Jun '23

18 Jun '23

Erin Park has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75907?usp=email ) Change subject: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. ...................................................................... soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. Based on meteorlake PnP analysis, ENERGY_POLICY_BALANCE_POWERSAVE is recommended in order to achieve best PnP user experience. Change-Id: Ib716584f516a538251c022e15b3193359b794366 --- M src/include/cpu/x86/msr.h M src/soc/intel/meteorlake/cpu.c 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/75907/1 diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h index d369972..e398bea 100644 --- a/src/include/cpu/x86/msr.h +++ b/src/include/cpu/x86/msr.h @@ -51,7 +51,9 @@ #define SPEED_STEP_ENABLE_BIT (1 << 16) #define IA32_ENERGY_PERF_BIAS 0x1b0 #define ENERGY_POLICY_PERFORMANCE 0 +#define ENERGY_POLICY_BALANCE_PERFORMANCE 4 #define ENERGY_POLICY_NORMAL 6 +#define ENERGY_POLICY_BALANCE_POWERSAVE 8 #define ENERGY_POLICY_POWERSAVE 15 #define ENERGY_POLICY_MASK 0xf #define IA32_PACKAGE_THERM_INTERRUPT 0x1b2 diff --git a/src/soc/intel/meteorlake/cpu.c b/src/soc/intel/meteorlake/cpu.c index 5177c4d..ae082f0 100644 --- a/src/soc/intel/meteorlake/cpu.c +++ b/src/soc/intel/meteorlake/cpu.c @@ -123,7 +123,7 @@ configure_dca_cap(); /* Set energy policy */ - set_energy_perf_bias(ENERGY_POLICY_NORMAL); + set_energy_perf_bias(ENERGY_POLICY_BALANCE_POWERSAVE); const config_t *conf = config_of_soc(); /* Set energy-performance preference */ -- To view, visit https://review.coreboot.org/c/coreboot/+/75907?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib716584f516a538251c022e15b3193359b794366 Gerrit-Change-Number: 75907 Gerrit-PatchSet: 1 Gerrit-Owner: Erin Park <erin.park(a)intel.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/hp: Add new port for compaq_8300_elite_usdt
by Riku Viitanen (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Kyösti Mälkki, Nicholas Chin. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74906?usp=email to look at the new patch set (#6). Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ...................................................................... mb/hp: Add new port for compaq_8300_elite_usdt New port based on autoport. This board has NPCD379 SuperIO, which seems similar to NPCD378. So I added the SuperIO code from hp8200sff. Seems to work fine. Fan speeds stay low when idling. (Without this, they went 100%) The following is tested and is working: * Native raminit with both DIMMs * Libgfxinit textmode and framebuffer on both DisplayPorts and VGA * External USB2 and USB3 ports: they all work * USB 3.0 SuperSpeed on Linux-libre (rear, 4 ports) * Ethernet * Mini-PCIe WLAN * SATA: 2.5" SSD and optical drive bay * Booting Live Linuxes from DVD and USB with SeaBIOS 1.16.1 * PS/2 keyboard and mouse * S3 suspend and resume, wake using USB keyboard * Headphone output, line out, internal speaker * Wake on LAN * Rebooting * CMOS options & nvramcui Untested: * mSATA slot. The SATA port needs to be enabled on devicetree too, but I'm unable to test due to lack of hardware * Line in, mic input * MXM graphics card * EHCI debug Not working: * Mini-PCIe USB: I couldn't get it working on vendor BIOS either, so maybe it just isn't present * PS/2 keyboard wake from S3 Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- A Documentation/mainboard/hp/compaq_8300_usdt.md A Documentation/mainboard/hp/compaq_8300_usdt_rom_header.jpg A src/mainboard/hp/compaq_elite_8300_usdt/Kconfig A src/mainboard/hp/compaq_elite_8300_usdt/Kconfig.name A src/mainboard/hp/compaq_elite_8300_usdt/Makefile.inc A src/mainboard/hp/compaq_elite_8300_usdt/acpi/ec.asl A src/mainboard/hp/compaq_elite_8300_usdt/acpi/platform.asl A src/mainboard/hp/compaq_elite_8300_usdt/acpi/superio.asl A src/mainboard/hp/compaq_elite_8300_usdt/acpi_tables.c A src/mainboard/hp/compaq_elite_8300_usdt/board_info.txt A src/mainboard/hp/compaq_elite_8300_usdt/cmos.default A src/mainboard/hp/compaq_elite_8300_usdt/cmos.layout A src/mainboard/hp/compaq_elite_8300_usdt/devicetree.cb A src/mainboard/hp/compaq_elite_8300_usdt/dsdt.asl A src/mainboard/hp/compaq_elite_8300_usdt/early_init.c A src/mainboard/hp/compaq_elite_8300_usdt/gma-mainboard.ads A src/mainboard/hp/compaq_elite_8300_usdt/gpio.c A src/mainboard/hp/compaq_elite_8300_usdt/hda_verb.c A src/mainboard/hp/compaq_elite_8300_usdt/mainboard.c 19 files changed, 753 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/74906/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/74906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3 Gerrit-Change-Number: 74906 Gerrit-PatchSet: 6 Gerrit-Owner: Riku Viitanen Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/hp: Add new port for compaq_8300_elite_usdt
by Riku Viitanen (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Kyösti Mälkki, Nicholas Chin. Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906?usp=email ) Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ...................................................................... Patch Set 5: (1 comment) File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74906/comment/afeeae57_e319dcab : PS1, Line 9: register "gen2_dec" = "0x00fc0801" > Autoport seems to copy these from what the vendor firmware sets so they are probably correct. […] SuperIO (and other) logs can be downloaded here: https://viitanen.xyz/8300usdt_autoport_logs.tar.gz But it seems like superiotool falsely detected this as AST2400. -- To view, visit https://review.coreboot.org/c/coreboot/+/74906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3 Gerrit-Change-Number: 74906 Gerrit-PatchSet: 5 Gerrit-Owner: Riku Viitanen Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 17:02:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Riku Viitanen Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per specs
by Sergii Dmytruk (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Himanshu Sahdev, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Paul Menzel. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749?usp=email ) Change subject: util/cbmem: add parsing of TPM logs per specs ...................................................................... Patch Set 19: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68749/comment/c3b5c816_a27c3ced : PS19, Line 9: coreboot is made to export the range allocated for the log. > Sorry, I do not understand this sentence. […] Thanks, the commit message and code have diverged. Fixed. https://review.coreboot.org/c/coreboot/+/68749/comment/a4582e26_3934183b : PS19, Line 12: > 1. Could you please give some more background on the implementation. […] Added more details and after juxtaposing outputs dropped debug print and fixed a discrepancy with formatting, thanks. File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/68749/comment/f9882403_8b589df3 : PS19, Line 899: printf("\tEvent type: Unknown (0x%x)\n", event_type); > `ARRAY_SIZE(tpm_event_types)` could also be printed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Gerrit-Change-Number: 68749 Gerrit-PatchSet: 19 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 16:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per specs
by Sergii Dmytruk (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Himanshu Sahdev, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Paul Menzel, Sergii Dmytruk. Hello Angel Pons, Benjamin Doron, Christian Walter, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68749?usp=email to look at the new patch set (#20). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Code-Review+2 by Krystian Hebel, Verified+1 by build bot (Jenkins) Change subject: util/cbmem: add parsing of TPM logs per specs ...................................................................... util/cbmem: add parsing of TPM logs per specs CBMEM can contain log in different forms (at most one is present): - coreboot-specific format (CBMEM_ID_TPM_CB_LOG exported as LB_TAG_TPM_CB_LOG) - TPM1.2 format (CBMEM_ID_TCPA_TCG_LOG) - TPM2 format (CBMEM_ID_TPM2_TCG_LOG) The last two follow specifications by Trusted Computing Group, but until now cbmem couldn't print them (they were added not so long ago). These changes make cbmem utility check for existence of TPM1.2/TPM2 logs in CBMEM and add code necessary for parsing and printing of their entries. TEST=`cbmem -L` for CONFIG_TPM1=y case TCPA log: Specification: 1.21 Platform class: PC Client TCPA log entry 1: PCR: 2 Event type: Action Digest: 5622416ea417186aa1ac32b32c527ac09009fb5e Event data: FMAP: FMAP TEST=`cbmem -L` for CONFIG_TPM2=y case (wrapped digest here manually) TPM2 log: Specification: 2.00 Platform class: PC Client TPM2 log entry 1: PCR: 2 Event type: Action Digests: SHA256: 68d27f08cb261463a6d004524333ac5d b1a3c2166721785a6061327b6538657c Event data: FMAP: FMAP Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Ticket: https://ticket.coreboot.org/issues/425 Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M src/commonlib/bsd/include/commonlib/bsd/tpm_log_defs.h M util/cbmem/cbmem.c 2 files changed, 300 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/68749/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/68749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Gerrit-Change-Number: 68749 Gerrit-PatchSet: 20 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: device/resource_allocator_v4: Remove "ERROR: " from log message
by Elyes Haouas (Code Review) 17 Jun '23

17 Jun '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75876?usp=email ) Change subject: device/resource_allocator_v4: Remove "ERROR: " from log message ...................................................................... device/resource_allocator_v4: Remove "ERROR: " from log message It is no longer necessary to explicitly add "ERROR: " in front of BIOS_ERR message. Change-Id: I3ff2081d38f94556481efa02f242795bbfc77517 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/resource_allocator_v4.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/75876/1 diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index 0a83d29..71a626a 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -405,7 +405,7 @@ if (memranges_steal(ranges, resource->limit, resource->size, resource->align, type_match, &resource->base, allocate_top_down) == false) { - printk(BIOS_ERR, " ERROR: Resource didn't fit!!! "); + printk(BIOS_ERR, " Resource didn't fit!!! "); printk(BIOS_DEBUG, " %s %02lx * size: 0x%llx limit: %llx %s\n", dev_path(dev), resource->index, resource->size, resource->limit, resource2str(resource)); -- To view, visit https://review.coreboot.org/c/coreboot/+/75876?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff2081d38f94556481efa02f242795bbfc77517 Gerrit-Change-Number: 75876 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/hp: Add new port for compaq_8300_elite_usdt
by Nicholas Chin (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Kyösti Mälkki, Riku Viitanen. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906?usp=email ) Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ...................................................................... Patch Set 5: (1 comment) File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74906/comment/f13fa83f_78f4f128 : PS1, Line 9: register "gen2_dec" = "0x00fc0801" > I have no idea. These magic numbers were decided by autoport. […] Autoport seems to copy these from what the vendor firmware sets so they are probably correct. So the ports that the devicetree says the SuperIO uses, which were copied from the 8200, are probably wrong. SuperIO tool dumps would indicate the proper settings, but it doesn't look like it supports the NPCD379. -- To view, visit https://review.coreboot.org/c/coreboot/+/74906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3 Gerrit-Change-Number: 74906 Gerrit-PatchSet: 5 Gerrit-Owner: Riku Viitanen Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Riku Viitanen Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Jun 2023 13:28:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Riku Viitanen Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: acpi/acpi.c: Return function argument when bailing out
by Lean Sheng Tan (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75903?usp=email ) Change subject: acpi/acpi.c: Return function argument when bailing out ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdf7acec38a7c958aac2cf1f3bbf16c27fa90b8c Gerrit-Change-Number: 75903 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 17 Jun 2023 13:18:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: acpi/acpi.c: Change signature of write_acpi_tables
by Lean Sheng Tan (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75902?usp=email ) Change subject: acpi/acpi.c: Change signature of write_acpi_tables ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75902?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3084e43ccbe9749bc726af3120decfe8b52e1709 Gerrit-Change-Number: 75902 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 17 Jun 2023 13:17:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi: Add SPCR table
by Lean Sheng Tan (Code Review) 17 Jun '23

17 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Lance Zhao, Nico Huber, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email ) Change subject: acpi: Add SPCR table ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: there’s merge conflict for this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/75685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64e624c17a27b9215a8ba83bd6cbb2c0a7aa1dfc Gerrit-Change-Number: 75685 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 17 Jun 2023 13:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023