coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: mb/intel/mtlrvp: disable acpi timer for xtal shutdown
by Sukumar Ghorai (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Nico Huber, Sukumar Ghorai. Hello Nico Huber, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75898?usp=email to look at the new patch set (#4). Change subject: mb/intel/mtlrvp: disable acpi timer for xtal shutdown ...................................................................... mb/intel/mtlrvp: disable acpi timer for xtal shutdown acpi timer needs to disabled for xtal shutdown, requirement for platform to enter deepest sleep state (s0i2.2). Change-Id: Ib87b7555217b6954fca98f95b86d03016cd9b783 Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/75898/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib87b7555217b6954fca98f95b86d03016cd9b783 Gerrit-Change-Number: 75898 Gerrit-PatchSet: 4 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: Print crashlog size info in hex
by Pratikkumar V Prajapati (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Subrata Banik, Tarun Tuli. Hello Subrata Banik, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75910?usp=email to look at the new patch set (#4). Change subject: soc/intel/common: Print crashlog size info in hex ...................................................................... soc/intel/common: Print crashlog size info in hex Print crashlog size information in hex to be consistent with other prints. Bug=b:262501347 TEST=values printed in hex Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> Change-Id: Ieb5498e702497bfbc2b4d5396d5b760a0010f5de --- M src/soc/intel/common/block/acpi/acpi_bert.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/75910/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb5498e702497bfbc2b4d5396d5b760a0010f5de Gerrit-Change-Number: 75910 Gerrit-PatchSet: 4 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: print crashlog size info in hex
by Pratikkumar V Prajapati (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Subrata Banik, Tarun Tuli. Hello Subrata Banik, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75910?usp=email to look at the new patch set (#3). Change subject: soc/intel/common: print crashlog size info in hex ...................................................................... soc/intel/common: print crashlog size info in hex Print crashlog size information in hex to be consistant with other prints. Bug=b:262501347 TEST=values printed in hex Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> Change-Id: Ieb5498e702497bfbc2b4d5396d5b760a0010f5de --- M src/soc/intel/common/block/acpi/acpi_bert.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/75910/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/75910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb5498e702497bfbc2b4d5396d5b760a0010f5de Gerrit-Change-Number: 75910 Gerrit-PatchSet: 3 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mainboard/intel/mtlrvp/Kconfig: disable acpi timer for xtal shutdown
by Paul Menzel (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Nico Huber, Sukumar Ghorai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75898?usp=email ) Change subject: mainboard/intel/mtlrvp/Kconfig: disable acpi timer for xtal shutdown ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75898/comment/eb0d1cf9_f2abfa87 : PS3, Line 7: mainboard mb -- To view, visit https://review.coreboot.org/c/coreboot/+/75898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib87b7555217b6954fca98f95b86d03016cd9b783 Gerrit-Change-Number: 75898 Gerrit-PatchSet: 3 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Sun, 18 Jun 2023 18:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per specs
by Sergii Dmytruk (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Himanshu Sahdev, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Hello Angel Pons, Benjamin Doron, Christian Walter, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68749?usp=email to look at the new patch set (#22). Change subject: util/cbmem: add parsing of TPM logs per specs ...................................................................... util/cbmem: add parsing of TPM logs per specs CBMEM can contain log in different forms (at most one is present): - coreboot-specific format (CBMEM_ID_TPM_CB_LOG exported as LB_TAG_TPM_CB_LOG) - TPM1.2 format (CBMEM_ID_TCPA_TCG_LOG) - TPM2 format (CBMEM_ID_TPM2_TCG_LOG) The last two follow specifications by Trusted Computing Group, but until now cbmem couldn't print them. These formats were added not so long ago in: - commit 4191dbf0c9a5 ("security/tpm: add TPM log format as per 1.2 spec") - commit 53db677586e3 ("security/tpm: add TPM log format as per 2.0 spec") These changes make cbmem utility check for existence of TPM1.2/TPM2 logs in CBMEM and add code necessary for parsing and printing of their entries. TEST=`cbmem -L` for CONFIG_TPM1=y case TCPA log: Specification: 1.21 Platform class: PC Client TCPA log entry 1: PCR: 2 Event type: Action Digest: 5622416ea417186aa1ac32b32c527ac09009fb5e Event data: FMAP: FMAP TEST=`cbmem -L` for CONFIG_TPM2=y case TPM2 log: Specification: 2.00 Platform class: PC Client TPM2 log entry 1: PCR: 2 Event type: Action Digests: SHA256: 68d27f08cb261463a6d004524333ac5db1a3c2166721785a6061327b6538657c Event data: FMAP: FMAP Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Ticket: https://ticket.coreboot.org/issues/425 Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M src/commonlib/bsd/include/commonlib/bsd/tpm_log_defs.h M util/cbmem/cbmem.c 2 files changed, 300 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/68749/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/68749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Gerrit-Change-Number: 68749 Gerrit-PatchSet: 22 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mainboard/intel/mtlrvp/Kconfig: disable acpi timer for xtal shutdown
by Subrata Banik (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Nico Huber, Sukumar Ghorai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75898?usp=email ) Change subject: mainboard/intel/mtlrvp/Kconfig: disable acpi timer for xtal shutdown ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib87b7555217b6954fca98f95b86d03016cd9b783 Gerrit-Change-Number: 75898 Gerrit-PatchSet: 3 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Sun, 18 Jun 2023 18:10:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/bytedance: Add 2 SPR sockets server board bd_egs
by Paul Menzel (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Felix Singer, Jonathan Zhang, Nill Ge, Patrick Rudolph, TangYiwei, niehaitao(a)bytedance.com. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email ) Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75722/comment/1d2f60e0_8d96e10f : PS5, Line 19: The board boots to Linux 5.10 with all 192 cores available. : All PCIe devices 64 and DIMMS are working. > Done Nice, it’d be great if you added (pasted) that to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/75722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d Gerrit-Change-Number: 75722 Gerrit-PatchSet: 7 Gerrit-Owner: TangYiwei Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: niehaitao(a)bytedance.com Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: niehaitao(a)bytedance.com Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: TangYiwei Gerrit-Comment-Date: Sun, 18 Jun 2023 18:09:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: TangYiwei Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per specs
by Paul Menzel (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Himanshu Sahdev, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749?usp=email ) Change subject: util/cbmem: add parsing of TPM logs per specs ...................................................................... Patch Set 21: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Gerrit-Change-Number: 68749 Gerrit-PatchSet: 21 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 18 Jun 2023 18:07:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per specs
by Sergii Dmytruk (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Himanshu Sahdev, Julius Werner, Krystian Hebel, Maximilian Brune, Michał Kopeć, Michał Żygowski, Paul Menzel. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749?usp=email ) Change subject: util/cbmem: add parsing of TPM logs per specs ...................................................................... Patch Set 21: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68749/comment/b3ac97ef_25c54f13 : PS20, Line 16: print them (they were added not so long ago). > Two dots/periods: … print them. (They were added not so long ago.) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Gerrit-Change-Number: 68749 Gerrit-PatchSet: 21 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Sun, 18 Jun 2023 18:07:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value.
by Paul Menzel (Code Review) 18 Jun '23

18 Jun '23

Attention is currently required from: Erin Park, Kapil Porwal, Subrata Banik, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75907?usp=email ) Change subject: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. ...................................................................... Patch Set 1: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75907/comment/13ac5c14_99947023 : PS1, Line 6: > Subject line should not end with a period. Please fix. (It’s the line below.) https://review.coreboot.org/c/coreboot/+/75907/comment/fd3de4ac_8e84fc54 : PS1, Line 7: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. Maybe: Default to Balance_Powersave policy (How is it spelled in the datasheet?) https://review.coreboot.org/c/coreboot/+/75907/comment/0aa3da38_13f9b590 : PS1, Line 9: meteorlake Meteor Lake https://review.coreboot.org/c/coreboot/+/75907/comment/73b2920d_14b53bc2 : PS1, Line 10: best PnP user experience How is that measured? Plug and Play? Doesn’t it depend on the board? https://review.coreboot.org/c/coreboot/+/75907/comment/3b44a0fc_7a795b24 : PS1, Line 13: Please add a Signed-off-by line. (`make gitconfig` should set everything up for you locally.) File src/include/cpu/x86/msr.h: https://review.coreboot.org/c/coreboot/+/75907/comment/b472dbcf_08876feb : PS1, Line 56: #define ENERGY_POLICY_BALANCE_POWERSAVE 8 Please make that a separate commit und use tabs for alignment. -- To view, visit https://review.coreboot.org/c/coreboot/+/75907?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib716584f516a538251c022e15b3193359b794366 Gerrit-Change-Number: 75907 Gerrit-PatchSet: 1 Gerrit-Owner: Erin Park <erin.park(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Erin Park <erin.park(a)intel.com> Gerrit-Comment-Date: Sun, 18 Jun 2023 18:07:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023