Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Raul Rangel, Yuchen He.
Hello Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75809?usp=email
to look at the new patch set (#3).
Change subject: soc/amd/common/psp_verstage: move post codes to own header
......................................................................
soc/amd/common/psp_verstage: move post codes to own header
In order to clean up the post code macros, move them to a separate
header away from unrelated code. The new header file is included in
the file where the post codes are moved out of, so that the current
state remains unchanged.
Change-Id: I28a932ce071488e90000e1bbd30b4d739a4bae43
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
A src/soc/amd/common/psp_verstage/include/psp_post_code.h
M src/soc/amd/common/psp_verstage/include/psp_verstage.h
2 files changed, 36 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/75809/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75809?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a932ce071488e90000e1bbd30b4d739a4bae43
Gerrit-Change-Number: 75809
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Dinesh Gehlot, Felix Held, Fred Reitberger, Jason Glenesk, Kapil Porwal, Matt DeVillier, Maulik Vaghela, Raul Rangel, Subrata Banik, Tarun Tuli, ron minnich.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70376?usp=email )
Change subject: cpu/x86: Support SMBASE relocation-only use-case
......................................................................
Patch Set 6:
(1 comment)
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/70376/comment/e4f6f1a4_d2063518 :
PS6, Line 139: COREBOOT
> we are in coreboot repo, don't know if there is any way to avoid `COREBOOT` from the Kconfig name?
Maybe call it "native?"
--
To view, visit https://review.coreboot.org/c/coreboot/+/70376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec96bab19cdcf80622756f02a3dae49b42036c8d
Gerrit-Change-Number: 70376
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Maulik Vaghela <maulikvaghela(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Maulik Vaghela <maulikvaghela(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Martin L Roth, Michał Żygowski, Patrick Rudolph.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70378?usp=email )
Change subject: drivers/smm_payload_interface: Add initial support for SMM payload
......................................................................
Patch Set 14:
(1 comment)
File src/drivers/smm_payload_interface/ramstage.c:
https://review.coreboot.org/c/coreboot/+/70378/comment/421c5024_a453a48a :
PS14, Line 114: static void perform_save(void *unused)
: {
: uint32_t reg32;
:
: // Payload does not enable sleep SMI
: reg32 = inl(ACPI_BASE_ADDRESS + SMI_EN);
: reg32 &= ~SLP_SMI_EN;
: outl(reg32, ACPI_BASE_ADDRESS + SMI_EN);
:
: // Enable SCI mode when there's no 'ACPI enable' SMI handler
: reg32 = inl(ACPI_BASE_ADDRESS + PM1_CNT);
: reg32 |= SCI_EN;
: outl(reg32, ACPI_BASE_ADDRESS + PM1_CNT);
:
: clear_s3_save_region();
: }
:
: static void perform_s3_restore(void *unused)
: {
: uint32_t reg32;
:
: // Payload does not enable sleep SMI
: reg32 = inl(ACPI_BASE_ADDRESS + SMI_EN);
: reg32 &= ~SLP_SMI_EN;
: outl(reg32, ACPI_BASE_ADDRESS + SMI_EN);
:
: // Enable SCI mode when there's no 'ACPI enable' SMI handler
: reg32 = inl(ACPI_BASE_ADDRESS + PM1_CNT);
: reg32 |= SCI_EN;
: outl(reg32, ACPI_BASE_ADDRESS + PM1_CNT);
:
: trigger_payload_swsmi();
: }
:
If we're already informing the payload where some registers are, maybe make it do this. Especially the "SLP_SMI_EN", that's highly implementation-specific. And creating these SMI handlers isn't a bad idea - depending on whether the payload can handle the interrupts as SMIs, or they should always go through ACPI instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70378?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dd505a154175b6da8929b1157723de1645ca8fa
Gerrit-Change-Number: 70378
Gerrit-PatchSet: 14
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Kyösti Mälkki, Nicholas Chin, Riku Viitanen.
Hello Felix Singer, Kyösti Mälkki, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74906?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Code-Review+1 by Felix Singer, Code-Review+1 by Kyösti Mälkki, Verified+1 by build bot (Jenkins)
Change subject: mb/hp: Add new port for compaq_8300_elite_usdt
......................................................................
mb/hp: Add new port for compaq_8300_elite_usdt
New port based on autoport.
Autoport worked with minor tweaks, but fan speeds went almost
immediately to the maximum. They are controlled by the NPCD379
Super I/O which isn't supported by coreboot.
But coreboot already has code for NPCD378,
which HP Compaq 8200 SFF makes use of.
So SuperIO configuration was copied from the 8200 SFF port.
It seems to work without any issues in "normal" use.
Most importantly, fan speed control seems to work correctly.
However this means that some of the SuperIO LDNs may be configured
incorrectly. See the comments on Gerrit for more information.
The following is tested and is working:
* Native raminit with both DIMMs
* Libgfxinit textmode and framebuffer on both DisplayPorts and VGA
* External USB2 and USB3 ports: they all work
* USB 3.0 SuperSpeed on Linux-libre (rear, 4 ports)
* Ethernet
* Mini-PCIe WLAN
* SATA: 2.5" SSD and optical drive bay
* Booting Live Linuxes from DVD and USB with SeaBIOS 1.16.1
* GRUB (with Libreboot config)
* PS/2 keyboard and mouse
* S3 suspend and resume, wake using USB keyboard
* Headphone output, line out, internal speaker
* Wake on LAN
* Rebooting
* CMOS options & nvramcui
Untested:
* mSATA slot. The SATA port needs to be enabled on devicetree
too, but I'm unable to test due to lack of hardware
* Line in, mic input
* MXM graphics card
* EHCI debug
Not working:
* Mini-PCIe USB: I couldn't get it working on vendor BIOS either, so
maybe it just isn't present
* PS/2 keyboard wake from S3
Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3
Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com>
---
A Documentation/mainboard/hp/compaq_8300_usdt.md
A Documentation/mainboard/hp/compaq_8300_usdt_rom_header.jpg
A src/mainboard/hp/compaq_elite_8300_usdt/Kconfig
A src/mainboard/hp/compaq_elite_8300_usdt/Kconfig.name
A src/mainboard/hp/compaq_elite_8300_usdt/Makefile.inc
A src/mainboard/hp/compaq_elite_8300_usdt/acpi/ec.asl
A src/mainboard/hp/compaq_elite_8300_usdt/acpi/platform.asl
A src/mainboard/hp/compaq_elite_8300_usdt/acpi/superio.asl
A src/mainboard/hp/compaq_elite_8300_usdt/acpi_tables.c
A src/mainboard/hp/compaq_elite_8300_usdt/board_info.txt
A src/mainboard/hp/compaq_elite_8300_usdt/cmos.default
A src/mainboard/hp/compaq_elite_8300_usdt/cmos.layout
A src/mainboard/hp/compaq_elite_8300_usdt/devicetree.cb
A src/mainboard/hp/compaq_elite_8300_usdt/dsdt.asl
A src/mainboard/hp/compaq_elite_8300_usdt/early_init.c
A src/mainboard/hp/compaq_elite_8300_usdt/gma-mainboard.ads
A src/mainboard/hp/compaq_elite_8300_usdt/gpio.c
A src/mainboard/hp/compaq_elite_8300_usdt/hda_verb.c
A src/mainboard/hp/compaq_elite_8300_usdt/mainboard.c
19 files changed, 719 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/74906/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/74906?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3
Gerrit-Change-Number: 74906
Gerrit-PatchSet: 9
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Raul Rangel, Yuchen He.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75809?usp=email )
Change subject: soc/amd/common/psp_verstage: move post codes to own header
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75809/comment/c7b2f60d_ed07ad19 :
PS2, Line 10: header away from unrelated code.
For completeness, please mention that the new header file is included in the other one so that the current state stays unchanged.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75809?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a932ce071488e90000e1bbd30b4d739a4bae43
Gerrit-Change-Number: 75809
Gerrit-PatchSet: 2
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75878?usp=email )
Change subject: security/tpm/tspi: Do TPM Restart if TPM Resume fails
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
For TPM2 logging, this should also record an `EV_SEPARATOR` event to indicate to the host an error occurred. (This is what edk2 does, so presumably all proprietary firmware as well.) I wasn't sure how to do that though.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75878?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3388007d4448c93bd0dda591c8ca7d1a8dc5306b
Gerrit-Change-Number: 75878
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Raul Rangel, Yuchen He.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75809?usp=email )
Change subject: soc/amd/common/psp_verstage: move post codes to own header
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/75809?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a932ce071488e90000e1bbd30b4d739a4bae43
Gerrit-Change-Number: 75809
Gerrit-PatchSet: 2
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:01:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75878?usp=email )
Change subject: security/tpm/tspi: Do TPM Restart if TPM Resume fails
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75878/comment/2e83cc55_ca9e225e :
PS1, Line 24:
> How much time does that add to the resume time?
I didn't measure it. I'd presume ~50ms like I see for normal TPM Startup.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75878?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3388007d4448c93bd0dda591c8ca7d1a8dc5306b
Gerrit-Change-Number: 75878
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:00:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Jeremy Soller, Michael Niewöhner, Michał Żygowski, Nico Huber, Patrick Rudolph, Piotr Król, Sean Rhodes, Tim Crawford, Yuchen He.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75972?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for PchHdaAudioLinkHda dt option
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75972?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2df7271bdc3d6c30bae75188e150fb348d872ab9
Gerrit-Change-Number: 75972
Gerrit-PatchSet: 4
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 20:00:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment