Attention is currently required from: Eric Lai, Felix Singer, Jonathon Hall.
Yuchen He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75959?usp=email )
Change subject: soc/intel/cannonlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/75959/comment/c24f9726_3256703f :
PS2, Line 444: bool cpu_ratio_override;
> This says the range is 0-63, should this stay uint8_t?
Yes, I think I made a mistake there. Thank you!
--
To view, visit https://review.coreboot.org/c/coreboot/+/75959?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9639bd1d0737f94931c28b0e12f214a5c1f87c0
Gerrit-Change-Number: 75959
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:14:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Felix Singer, Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75959?usp=email )
Change subject: soc/intel/cannonlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/75959?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9639bd1d0737f94931c28b0e12f214a5c1f87c0
Gerrit-Change-Number: 75959
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:13:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Felix Singer, Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75959?usp=email )
Change subject: soc/intel/cannonlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/75959/comment/2a552e9f_f817c3b2 :
PS2, Line 444: bool cpu_ratio_override;
> This says the range is 0-63, should this stay uint8_t?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/75959?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9639bd1d0737f94931c28b0e12f214a5c1f87c0
Gerrit-Change-Number: 75959
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Felix Singer, Yuchen He.
Hello Eric Lai, Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75959?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Eric Lai, Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/cannonlake/chip.h: Use boolean type where applicable
......................................................................
soc/intel/cannonlake/chip.h: Use boolean type where applicable
Change-Id: If9639bd1d0737f94931c28b0e12f214a5c1f87c0
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/soc/intel/cannonlake/chip.h
1 file changed, 64 insertions(+), 63 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/75959/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75959?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9639bd1d0737f94931c28b0e12f214a5c1f87c0
Gerrit-Change-Number: 75959
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Jeremy Soller, Michael Niewöhner, Nico Huber, Patrick Rudolph, Sean Rhodes, Tarun Tuli, Tim Crawford, Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75970?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for SataSalpSupport dt option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/75970?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I320a85d6e897ab9826a79c227c11f317fe1f49de
Gerrit-Change-Number: 75970
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:08:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Michael Niewöhner, Patrick Rudolph, Tarun Tuli, Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76027?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for satapwroptimize dt option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/76027?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9416ea63ed8bd13f8fbf669b3f5bb5da1b9b1c73
Gerrit-Change-Number: 76027
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:07:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76026?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableFivr dt option
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76026?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I453fe56a127d1c870dd0e24ed4cbd33c9f3a00a4
Gerrit-Change-Number: 76026
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:07:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76025?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableSa dt option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/76025?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I985de7c542dae51f01e661bbfb4b9cbb938b2c3a
Gerrit-Change-Number: 76025
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:07:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76024?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableGt dt option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/76024?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie56967088c1aa955008d61d162eaf1a5ae135860
Gerrit-Change-Number: 76024
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:06:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment