Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76038?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for LanWakeFromDeepSx dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for LanWakeFromDeepSx dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="LanWakeFromDeepSx" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: I218ca92e7ebdc1d87be4c243d5209bc9436fac01
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/76038/1
diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index 6133586..696d822 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -52,7 +52,7 @@
# Enable DDC for DDI port B
register DdiPortBDdc = true
- register "LanWakeFromDeepSx" = "0"
+ register LanWakeFromDeepSx = false
register "WolEnableOverride" = "0"
# VR Settings Configuration for 4 Domains
--
To view, visit https://review.coreboot.org/c/coreboot/+/76038?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I218ca92e7ebdc1d87be4c243d5209bc9436fac01
Gerrit-Change-Number: 76038
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newchange
Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76035?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortDDdc dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortDDdc dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="DdiPortDDdc" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: I73cf64609af626de421a2ae8253273d40d9d2faa
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/76035/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
index d8eb751..aaf0349 100644
--- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
+++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
@@ -12,7 +12,7 @@
# Enable DDC for DDI ports B/C
register DdiPortBDdc = true
register DdiPortCDdc = true
- register "DdiPortDDdc" = "1"
+ register DdiPortDDdc = true
register "DdiPortFDdc" = "1"
register "SerialIoDevMode" = "{
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
index e155bdd..eec7c79 100644
--- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
+++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
@@ -12,7 +12,7 @@
# Enable DDC for DDI ports B/C/D/F
register DdiPortBDdc = true
register DdiPortCDdc = true
- register "DdiPortDDdc" = "1"
+ register DdiPortDDdc = true
register "DdiPortFDdc" = "1"
register SataSalpSupport = true
--
To view, visit https://review.coreboot.org/c/coreboot/+/76035?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73cf64609af626de421a2ae8253273d40d9d2faa
Gerrit-Change-Number: 76035
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newchange
Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76034?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortCDdc dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortCDdc dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="DdiPortCDdc" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: I89cd35eb99b20b117ea4448dc7e36dfb3894245c
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/76034/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
index d4ceed2..d8eb751 100644
--- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
+++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
@@ -11,7 +11,7 @@
register DdiPortFHpd = true
# Enable DDC for DDI ports B/C
register DdiPortBDdc = true
- register "DdiPortCDdc" = "1"
+ register DdiPortCDdc = true
register "DdiPortDDdc" = "1"
register "DdiPortFDdc" = "1"
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
index db85fa3..e155bdd 100644
--- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
+++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
@@ -11,7 +11,7 @@
register DdiPortFHpd = true
# Enable DDC for DDI ports B/C/D/F
register DdiPortBDdc = true
- register "DdiPortCDdc" = "1"
+ register DdiPortCDdc = true
register "DdiPortDDdc" = "1"
register "DdiPortFDdc" = "1"
--
To view, visit https://review.coreboot.org/c/coreboot/+/76034?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89cd35eb99b20b117ea4448dc7e36dfb3894245c
Gerrit-Change-Number: 76034
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newchange