Attention is currently required from: Christian Walter, Felix Singer, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nico Huber, Patrick Rudolph, Piotr Król, Sean Rhodes, Tim Crawford.
Yuchen He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75972?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for PchHdaAudioLinkHda dt option
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/starlabs/starbook/variants/cml/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75972/comment/0af5a936_7ee65d3b :
PS1, Line 180: register PchHdaAudioLinkHda = true
> Still one tab missing
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/75972?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2df7271bdc3d6c30bae75188e150fb348d872ab9
Gerrit-Change-Number: 75972
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 17:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76016?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DisableHeciRetry dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DisableHeciRetry dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="DisableHeciRetry" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: I395b9cfe02fe1b98e3948e0a516341697f0bb51d
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/prodrive/hermes/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/76016/1
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb
index 8bf05d4..dd585cc 100644
--- a/src/mainboard/prodrive/hermes/devicetree.cb
+++ b/src/mainboard/prodrive/hermes/devicetree.cb
@@ -134,7 +134,7 @@
[PchSerialIoIndexUART2] = PchSerialIoPci,
}"
- register "DisableHeciRetry" = "1"
+ register DisableHeciRetry = true
device cpu_cluster 0 on end
--
To view, visit https://review.coreboot.org/c/coreboot/+/76016?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I395b9cfe02fe1b98e3948e0a516341697f0bb51d
Gerrit-Change-Number: 76016
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newchange
Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76015?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for ScsSdCardWpPinEnabled dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for ScsSdCardWpPinEnabled dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="ScsSdCardWpPinEnabled" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: Idd3731ab878c1023028c8a482b16583612e5aa84
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/google/hatch/variants/baseboard/devicetree.cb
M src/mainboard/google/puff/variants/baseboard/devicetree.cb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/76015/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
index 1866bd1..e77da3b 100644
--- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
@@ -45,7 +45,7 @@
# Unlock GPIO pads
register "PchUnlockGpioPads" = "1"
# SD card WP pin configuration
- register "ScsSdCardWpPinEnabled" = "0"
+ register ScsSdCardWpPinEnabled = false
# NOTE: if any variant wants to override this value, use the same format
# as register "common_soc_config.pch_thermal_trip" = "value", instead of
diff --git a/src/mainboard/google/puff/variants/baseboard/devicetree.cb b/src/mainboard/google/puff/variants/baseboard/devicetree.cb
index 7e9e2a6..3f7b503 100644
--- a/src/mainboard/google/puff/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/puff/variants/baseboard/devicetree.cb
@@ -45,7 +45,7 @@
# Unlock GPIO pads
register "PchUnlockGpioPads" = "1"
# SD card WP pin configuration
- register "ScsSdCardWpPinEnabled" = "0"
+ register ScsSdCardWpPinEnabled = false
# NOTE: if any variant wants to override this value, use the same format
# as register "common_soc_config.pch_thermal_trip" = "value", instead of
--
To view, visit https://review.coreboot.org/c/coreboot/+/76015?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd3731ab878c1023028c8a482b16583612e5aa84
Gerrit-Change-Number: 76015
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Christian Walter.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75997?usp=email )
Change subject: UNTESTED: security/crtm: Don't measure anything on S3 resume
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This is causing a full boot but still somehow reporting it as S3 Resume.
Here is the log from system76/oryp11: https://dpaste.org/NMYjV
Note: This is still on a 4.19 base.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75997?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4ed5a3ca8bb2f82931e08348754c173d7a78c53
Gerrit-Change-Number: 75997
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 21 Jun 2023 16:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Felix Singer, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nico Huber, Patrick Rudolph, Piotr Król, Sean Rhodes, Tim Crawford, Yuchen He.
Hello Christian Walter, Felix Singer, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nico Huber, Patrick Rudolph, Piotr Król, Sean Rhodes, Tim Crawford, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75972?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: mb/{cfl,cml,whl}: Use true/false macros for PchHdaAudioLinkHda dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for PchHdaAudioLinkHda dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="PchHdaAudioLinkHda" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: I2df7271bdc3d6c30bae75188e150fb348d872ab9
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb
M src/mainboard/google/drallion/variants/drallion/devicetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/overridetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/overridetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/cfl_u/overridetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb
M src/mainboard/prodrive/hermes/devicetree.cb
M src/mainboard/protectli/vault_cml/devicetree.cb
M src/mainboard/purism/librem_cnl/devicetree.cb
M src/mainboard/siemens/chili/variants/base/devicetree.cb
M src/mainboard/siemens/chili/variants/chili/devicetree.cb
M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
M src/mainboard/system76/addw1/devicetree.cb
M src/mainboard/system76/bonw14/devicetree.cb
M src/mainboard/system76/cml-u/devicetree.cb
M src/mainboard/system76/gaze15/devicetree.cb
M src/mainboard/system76/oryp5/devicetree.cb
M src/mainboard/system76/oryp6/devicetree.cb
M src/mainboard/system76/whl-u/devicetree.cb
21 files changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/75972/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75972?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2df7271bdc3d6c30bae75188e150fb348d872ab9
Gerrit-Change-Number: 75972
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Christian Walter, Jeremy Soller, Paul Menzel, Philipp Deppenwiese, Sergii Dmytruk.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73297?usp=email )
Change subject: security/tpm/tspi/log: Respect CBMEM TPM log size when copying preram entries
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73297/comment/a39f5247_f9a76a1f :
PS1, Line 13: Fixes performing multiple S3 suspends with TPM_MEASURED_BOOT enabled.
> > I have also not checked if/how changes in topic:tpm-std-logs affect this. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/73297?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If76299e68eb5ed2ed20c947be35cea46c51fcdec
Gerrit-Change-Number: 73297
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Attention: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 16:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-MessageType: comment