Attention is currently required from: Angel Pons, Branden Waldner, Christian Walter, Felix Held, Jakub Czapiga, Julius Werner, Keith Hui, Martin L Roth, Patrick Rudolph, Paul Menzel, Raul Rangel, Stefan Reinauer, ron minnich.
Hello Aaron Durbin, Andrey Petrov, Christian Walter, Erik van den Bogaert, Felix Held, Frans Hendriks, Furquan Shaikh, Jakub Czapiga, Jason Glenesk, Julius Werner, Marshall Dawson, Martin L Roth, Michał Żygowski, Patrick Rudolph, Philipp Hug, Piotr Król, Raul Rangel, Stefan Reinauer, Subrata Banik, Yu-Ping Wu, build bot (Jenkins), ron minnich, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55068?usp=email
to look at the new patch set (#39).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Allow to build romstage sources inside the bootblock
......................................................................
Allow to build romstage sources inside the bootblock
Having a separate romstage is only desirable:
- with advanced setups like vboot or normal/fallback
- boot medium is slow at startup (some ARM SOCs)
- bootblock is limited in size (Intel APL 32K)
When this is not the case there is no need for the extra complexity
that romstage brings. Including the romstage sources inside the
bootblock substantially reduces the total code footprint. Often the
resulting code is 10-20k smaller.
This is controlled via a Kconfig option.
TESTED: works on qemu x86, arm and aarch64 with and without VBOOT.
Change-Id: Id68390edc1ba228b121cca89b80c64a92553e284
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.inc
M src/Kconfig
M src/arch/arm64/romstage.c
M src/arch/x86/Makefile.inc
M src/arch/x86/assembly_entry.S
M src/arch/x86/car.ld
M src/arch/x86/memcpy.c
M src/arch/x86/memlayout.ld
M src/arch/x86/memmove_32.c
M src/arch/x86/memset.c
M src/commonlib/storage/sdhci.c
M src/console/Kconfig
M src/console/console.c
M src/console/init.c
M src/cpu/x86/cache/cache.c
M src/drivers/net/ne2k.c
M src/drivers/siemens/nc_fpga/nc_fpga_early.c
M src/drivers/usb/ehci_debug.c
M src/drivers/vpd/vpd.c
M src/include/cbmem.h
M src/include/console/cbmem_console.h
M src/include/console/console.h
M src/include/console/ne2k.h
M src/include/console/qemu_debugcon.h
M src/include/console/spkmodem.h
M src/include/console/system76_ec.h
M src/include/console/uart.h
M src/include/console/usb.h
M src/include/memlayout.h
M src/include/rules.h
M src/include/symbols.h
M src/include/timestamp.h
M src/lib/asan.c
M src/lib/cbfs.c
M src/lib/prog_loaders.c
M src/mainboard/emulation/qemu-armv7/romstage.c
M src/mainboard/emulation/qemu-riscv/memlayout.ld
M src/mainboard/google/butterfly/chromeos.c
M src/mainboard/google/daisy/romstage.c
M src/mainboard/google/peach_pit/romstage.c
M src/mainboard/google/poppy/variants/nautilus/sku.c
M src/mainboard/google/rambi/chromeos.c
M src/mainboard/google/veyron/romstage.c
M src/mainboard/google/veyron_mickey/romstage.c
M src/mainboard/google/veyron_rialto/romstage.c
M src/mainboard/ti/beaglebone/romstage.c
M src/security/tpm/tspi/crtm.c
M src/security/tpm/tspi/log-tpm1.c
M src/security/tpm/tspi/log-tpm2.c
M src/security/tpm/tspi/log.c
M src/security/vboot/Kconfig
M src/security/vboot/Makefile.inc
M src/security/vboot/common.c
M src/security/vboot/misc.h
M src/security/vboot/vboot_common.c
M src/soc/intel/common/block/pmc/pmclib.c
M src/soc/intel/common/block/systemagent/memmap.c
M src/vendorcode/eltan/security/verified_boot/vboot_check.c
M tests/lib/imd_cbmem-test.c
59 files changed, 137 insertions(+), 102 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/55068/39
--
To view, visit https://review.coreboot.org/c/coreboot/+/55068?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id68390edc1ba228b121cca89b80c64a92553e284
Gerrit-Change-Number: 55068
Gerrit-PatchSet: 39
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)chromium.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: ron minnich <rminnich(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75925?usp=email
to look at the new patch set (#9).
Change subject: mb/qemu/aarch64: Add PCI support
......................................................................
mb/qemu/aarch64: Add PCI support
Run with "-device pci-bridge,chassis_nr=1" argument to add a bridge and
see that it gets found and picked up by the resource allocator.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
---
M src/mainboard/emulation/qemu-aarch64/Kconfig
M src/mainboard/emulation/qemu-aarch64/bootblock.c
M src/mainboard/emulation/qemu-aarch64/devicetree.cb
M src/mainboard/emulation/qemu-aarch64/include/mainboard/addressmap.h
M src/mainboard/emulation/qemu-aarch64/mainboard.c
5 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/75925/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/75925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
Gerrit-Change-Number: 75925
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75925?usp=email )
Change subject: mb/qemu/aarch64: Add PCI support
......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/emulation/qemu-aarch64/mainboard.c:
https://review.coreboot.org/c/coreboot/+/75925/comment/b0528d8f_e5e84394 :
PS4, Line 36: IOINDEX_SUBTRACTIVE
> Not sure if it makes sense to call these subtractive.
Done.
https://review.coreboot.org/c/coreboot/+/75925/comment/4d4370c7_7eee6750 :
PS4, Line 38: res->limit = VIRT_PCIE_LOW_MMIO_LIMIT;
> coreboot uses inclusive limits. So I guess we should add a `- 1` here […]
Done
https://review.coreboot.org/c/coreboot/+/75925/comment/2a0ee1a8_8356c3e2 :
PS4, Line 42: 1
> Second parameter is `LINK`, I suppose to refer to an entry in the `link_list` […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/75925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
Gerrit-Change-Number: 75925
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Wed, 21 Jun 2023 14:16:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75925?usp=email
to look at the new patch set (#8).
Change subject: mb/qemu/aarch64: Add PCI support
......................................................................
mb/qemu/aarch64: Add PCI support
Run with "-device pci-bridge,chassis_nr=1" argument to add a bridge and
see that it gets found and picked up by the resource allocator.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
---
M src/mainboard/emulation/qemu-aarch64/Kconfig
M src/mainboard/emulation/qemu-aarch64/bootblock.c
M src/mainboard/emulation/qemu-aarch64/devicetree.cb
M src/mainboard/emulation/qemu-aarch64/include/mainboard/addressmap.h
M src/mainboard/emulation/qemu-aarch64/mainboard.c
5 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/75925/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/75925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
Gerrit-Change-Number: 75925
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75925?usp=email
to look at the new patch set (#7).
Change subject: mb/qemu/aarch64: Add PCI support
......................................................................
mb/qemu/aarch64: Add PCI support
Run with "-device pci-bridge,chassis_nr=1" argument to add a bridge and
see that it gets found and picked up by the resource allocator.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
---
M src/mainboard/emulation/qemu-aarch64/Kconfig
M src/mainboard/emulation/qemu-aarch64/bootblock.c
M src/mainboard/emulation/qemu-aarch64/devicetree.cb
M src/mainboard/emulation/qemu-aarch64/include/mainboard/addressmap.h
M src/mainboard/emulation/qemu-aarch64/mainboard.c
5 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/75925/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/75925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
Gerrit-Change-Number: 75925
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75925?usp=email
to look at the new patch set (#6).
Change subject: mb/qemu/aarch64: Add PCI support
......................................................................
mb/qemu/aarch64: Add PCI support
Run with "-device pci-bridge,chassis_nr=1" argument to add a bridge and
see that it gets found and picked up by the resource allocator.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
---
M src/mainboard/emulation/qemu-aarch64/Kconfig
M src/mainboard/emulation/qemu-aarch64/bootblock.c
M src/mainboard/emulation/qemu-aarch64/devicetree.cb
M src/mainboard/emulation/qemu-aarch64/include/mainboard/addressmap.h
M src/mainboard/emulation/qemu-aarch64/mainboard.c
5 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/75925/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/75925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
Gerrit-Change-Number: 75925
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75925?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/qemu/aarch64: Add PCI support
......................................................................
mb/qemu/aarch64: Add PCI support
Run with "-device pci-bridge,chassis_nr=1" argument to add a bridge and
see that it gets found and picked up by the resource allocator.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
---
M src/mainboard/emulation/qemu-aarch64/Kconfig
M src/mainboard/emulation/qemu-aarch64/bootblock.c
M src/mainboard/emulation/qemu-aarch64/devicetree.cb
M src/mainboard/emulation/qemu-aarch64/include/mainboard/addressmap.h
M src/mainboard/emulation/qemu-aarch64/mainboard.c
5 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/75925/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/75925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad5d87731066a4009d2c4930a01bc15543d9447a
Gerrit-Change-Number: 75925
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50598?usp=email )
Change subject: intel/block/pcie/rtd3: Also implement _PR3
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/50598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f4373989dffe8c3bc68a034f59a94d2160dd15
Gerrit-Change-Number: 50598
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jeremy Soller <jeremy(a)system76.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 21 Jun 2023 14:01:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment