Attention is currently required from: Andrey Petrov, Arthur Heymans, Frans Hendriks.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email )
Change subject: Kconfig: Set better defaults for building romstage
......................................................................
Patch Set 42:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/63419/comment/0f0b3b1a_eb6f4b03 :
PS42, Line 1471: default y if VBOOT_STARTS_IN_BOOTBLOCK || BOOTBLOCK_NORMAL || ASAN_IN_ROMSTAGE
VBOOT alread has a select on this and maybe the others should have one too?
What happens if the user decides to combine BOOTBLOCK_NORMAL or
ASAN_IN_ROMSTAGE with !SEPARATE_ROMSTAGE?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1
Gerrit-Change-Number: 63419
Gerrit-PatchSet: 42
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 17:25:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76026?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableFivr dt option
......................................................................
mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableFivr dt option
The true/false macros give the reader a better understanding about how
the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option
were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \
option="FastPkgCRampDisableFivr" && \
grep -r "${dt_line}" src/mainboard | \
cut -d ':' -f 1 | \
xargs sed -i'' -e "s/\"${option}\".*\=.*\"1\"/${option} \= true/g" -e "s/\"${option}\".*\=.*\"0\"/${option} \= false/g"
Change-Id: I453fe56a127d1c870dd0e24ed4cbd33c9f3a00a4
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
---
M src/mainboard/purism/librem_cnl/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/76026/1
diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb
index e3d93f4..b75b579 100644
--- a/src/mainboard/purism/librem_cnl/devicetree.cb
+++ b/src/mainboard/purism/librem_cnl/devicetree.cb
@@ -14,7 +14,7 @@
register FastPkgCRampDisableIa = true
register FastPkgCRampDisableGt = true
register FastPkgCRampDisableSa = true
- register "FastPkgCRampDisableFivr" = "1"
+ register FastPkgCRampDisableFivr = true
register "SlowSlewRateForIa" = "3" # fast/16
register "SlowSlewRateForGt" = "3" # fast/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/76026?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I453fe56a127d1c870dd0e24ed4cbd33c9f3a00a4
Gerrit-Change-Number: 76026
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-MessageType: newchange