coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: mb/google/rex/var/baseboard/rex: Set TCC to 90°C
by Sumeet R Pawnikar (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun Tuli. Hello Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76110?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rex/var/baseboard/rex: Set TCC to 90°C ...................................................................... mb/google/rex/var/baseboard/rex: Set TCC to 90°C Set tcc_offset value to 20 in devicetree for Thermal Control Circuit (TCC) activation feature for rex variants. BUG=b:270664854 BRANCH=None TEST=Build FW and test on rex board Change-Id: I0567b6240fcb53f38158c381b700169475cf3795 Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/76110/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0567b6240fcb53f38158c381b700169475cf3795 Gerrit-Change-Number: 76110 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Deepika Punyamurtula <deepika.punyamurtula(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: elog: Add PSR backup eventlog messages
by Krishna P Bhat D (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Anil Kumar K, Rizwan Qureshi. Hello Anil Kumar K, Rizwan Qureshi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75760?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: elog: Add PSR backup eventlog messages ...................................................................... elog: Add PSR backup eventlog messages This patch adds eventlog messages for the below scenarios: 1. To indicate success or failure of PSR data backup command 2. To indicate the loss PSR data when CSE update is corrupted and data clear command is issued to clear the data. Change-Id: I2459a2b941d28a87b6c78f75dbe8779d73328d7a Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com> --- M src/commonlib/bsd/include/commonlib/bsd/elog.h M src/soc/intel/common/block/cse/cse_lite.c 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/75760/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75760?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2459a2b941d28a87b6c78f75dbe8779d73328d7a Gerrit-Change-Number: 75760 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: lib: Support localized text of memory_training_desc in ux_locales.c
by Yu-Ping Wu (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Hsuan-ting Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75330?usp=email ) Change subject: lib: Support localized text of memory_training_desc in ux_locales.c ...................................................................... Patch Set 9: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75330/comment/7b22c9ce_0bbcf950 : PS9, Line 13: The preram_locales file follows the format: I have a few questions about the format. 1. From the parsing algorithm, there will be a problem if (a) `locale_id_1 == string_name_2`: Okay, this is prevented by an extra check in the bmpblk/build.py script (b) `localized_string_1 == string_name_2`: Do we want to prevent that? How? To make bmpblk/build.py simpler and the parsing more robust, I wonder if there can be a different delimiter between strings: ``` string_name_1 \x00 locale_id_1 \x00 localized_string_1 \x00 ... \x01 string_name_2 \x00 locale_id_2 \x00 localized_string_2 \x00 ... \x01 string_name_3 \x00 locale_id_3 \x00 localized_string_3 \x00 ... ``` 2. Since the file format is designed specifically for this use case, I wonder if we should add a version byte (or several bytes, or even a small header struct) in case there's a breaking change in the format in the future? File src/lib/ux_locales.c: https://review.coreboot.org/c/coreboot/+/75330/comment/24a16741_f7664c36 : PS9, Line 109: BIOS_INFO Shouldn't this be an error? https://review.coreboot.org/c/coreboot/+/75330/comment/bd8f044c_ee7ac1e1 : PS9, Line 118: BIOS_INFO BIOS_WARNING https://review.coreboot.org/c/coreboot/+/75330/comment/efd63c42_1ec3c073 : PS9, Line 128: offset Just pass 0 here (and remove the previous line)? https://review.coreboot.org/c/coreboot/+/75330/comment/7d5b64d8_c578480b : PS9, Line 130: BIOS_INFO BIOS_ERR. Same for 2 instances below. https://review.coreboot.org/c/coreboot/+/75330/comment/a783eb03_56359409 : PS9, Line 154: Extra space. -- To view, visit https://review.coreboot.org/c/coreboot/+/75330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e3c8d103c938a11b397c32c9228e44e31c3f01d Gerrit-Change-Number: 75330 Gerrit-PatchSet: 9 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 10:08:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: lib: Support localized text of memory_training_desc in ux_locales.c
by Yu-Ping Wu (Code Review) 26 Jun '23

26 Jun '23

1 0

[XS] Change in coreboot[master]: mb/google/rex: Avoid LPDDR5/x hang
by Lean Sheng Tan (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Felix Singer, Jakub Czapiga, Subrata Banik, Tarun Tuli. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76076?usp=email ) Change subject: mb/google/rex: Avoid LPDDR5/x hang ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02a9cadc075f396549703d7a008382e76268f865 Gerrit-Change-Number: 76076 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:48:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google: Move declaration of tis_plat_irq_status to cr50.h
by Yu-Ping Wu (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Christian Walter, Grzegorz Bernacki, Jason Nien, Martin Roth, Vadim Bendebury, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75917?usp=email ) Change subject: mb/google: Move declaration of tis_plat_irq_status to cr50.h ...................................................................... Patch Set 2: (1 comment) File src/drivers/tpm/cr50.h: https://review.coreboot.org/c/coreboot/+/75917/comment/783acfcd_7b82db52 : PS2, Line 28: tis_plat_irq_status > I will rename the funcion, but for now I will not move the weak implementation yet. […] Moving the declaration and moving the 2 weak implementations look like the same thing, so I think they should be done in the same patch. In fact, aren't these 2 weak functions almost identical? It should be pretty easy to merge them. If you care about different timeouts (10ms vs 20ms), a Kconfig option (similar to `GOOGLE_TPM_IRQ_TIMEOUT_MS`) can be added. However I doubt that the weak implementations are actually used for any board, because each `GOOGLE_BOARD_*` should have its own implementation of `tis_plat_irq_status`. If that's the case, always delaying 20ms should be good enough. -- To view, visit https://review.coreboot.org/c/coreboot/+/75917?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78dc39f2c7b44232b06947d3dfe6afa52807ced8 Gerrit-Change-Number: 75917 Gerrit-PatchSet: 2 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:39:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Grzegorz Bernacki Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: libpayload/arch/x86[INTERNAL]: Update GP register for API handling of...
by Saurabh Mishra (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Saurabh Mishra. Hello Saurabh Mishra, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/76111?usp=email to review the following change. Change subject: libpayload/arch/x86[INTERNAL]: Update GP register for API handling of CBTABLE handoff ...................................................................... libpayload/arch/x86[INTERNAL]: Update GP register for API handling of CBTABLE handoff Change-Id: Ib20d5f68ce60b58533bb048e5363c89a587a1b9b Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> --- M payloads/libpayload/arch/x86/head.S 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/76111/1 diff --git a/payloads/libpayload/arch/x86/head.S b/payloads/libpayload/arch/x86/head.S index 87d0037..6a1c43a 100644 --- a/payloads/libpayload/arch/x86/head.S +++ b/payloads/libpayload/arch/x86/head.S @@ -65,7 +65,7 @@ /* Store EAX and EBX */ movl %eax, loader_eax - movl %ebx, loader_ebx + movl %esi, loader_ebx /* save pointer to coreboot tables */ movl 4(%esp), %eax -- To view, visit https://review.coreboot.org/c/coreboot/+/76111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib20d5f68ce60b58533bb048e5363c89a587a1b9b Gerrit-Change-Number: 76111 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/rex: Avoid LPDDR5/x hang
by Kapil Porwal (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Felix Singer, Jakub Czapiga, Subrata Banik, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76076?usp=email ) Change subject: mb/google/rex: Avoid LPDDR5/x hang ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02a9cadc075f396549703d7a008382e76268f865 Gerrit-Change-Number: 76076 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 06:49:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: don't add fmap_config.h dependency twice
by Erik van den Bogaert (Code Review) 26 Jun '23

26 Jun '23

Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76002?usp=email ) Change subject: Makefile.inc: don't add fmap_config.h dependency twice ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76002?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b62917f32ae9f51f079b243a606e5db07ca9099 Gerrit-Change-Number: 76002 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 06:44:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/{skl,kbl}: Use true/false keywords for non-array dt options
by Erik van den Bogaert (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Angel Pons, Felix Singer, Frans Hendriks, Jeremy Soller, Michał Żygowski, Nico Huber, Piotr Król, Sean Rhodes, Tim Crawford. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75888?usp=email ) Change subject: mb/{skl,kbl}: Use true/false keywords for non-array dt options ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff063c37a093e597c6b73a583903ce5e4f698856 Gerrit-Change-Number: 75888 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 06:43:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023