coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[S] Change in coreboot[master]: mb/google/reef: Disable Intel Trace Hub PCI device
by Eric Lai (Code Review) 01 May '23

01 May '23

Attention is currently required from: Sean Rhodes, Matt DeVillier. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74890 ) Change subject: mb/google/reef: Disable Intel Trace Hub PCI device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8ec46e2e07b6635bfe9766812ce08b866c71d66 Gerrit-Change-Number: 74890 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 00:36:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block/lpc/lpc: report mapped SPI flash as MMIO range
by Eric Lai (Code Review) 01 May '23

01 May '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Fred Reitberger, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74839 ) Change subject: soc/amd/common/block/lpc/lpc: report mapped SPI flash as MMIO range ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib52df2b2d79a1e6213c3499984a5a1e0e25c058a Gerrit-Change-Number: 74839 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 May 2023 00:34:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/uldren:Fix Touch screen power sequence
by Ian Feng (Code Review) 01 May '23

01 May '23

Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74835 ) Change subject: mb/google/nissa/var/uldren:Fix Touch screen power sequence ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1b1ce80aa1dd8c312e3663fc50c9e9f53cc07fe Gerrit-Change-Number: 74835 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 02 May 2023 00:24:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/phoenix: Add default vBIOS ID and location
by Eric Lai (Code Review) 01 May '23

01 May '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74905 ) Change subject: soc/amd/phoenix: Add default vBIOS ID and location ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: do we need this for myst bring up? -- To view, visit https://review.coreboot.org/c/coreboot/+/74905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iadc32f4dbf8bd48d8666a213d7b5f3ba42175a90 Gerrit-Change-Number: 74905 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 May 2023 00:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/phoenix: Add default vBIOS ID and location
by Eric Lai (Code Review) 01 May '23

01 May '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74905 ) Change subject: soc/amd/phoenix: Add default vBIOS ID and location ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iadc32f4dbf8bd48d8666a213d7b5f3ba42175a90 Gerrit-Change-Number: 74905 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 May 2023 00:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/tutorial/part1.md: fix package name to install qemu on Debian
by Daniel Rosa Franzini (Code Review) 01 May '23

01 May '23

Attention is currently required from: Nico Huber, Paul Menzel. Daniel Rosa Franzini has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74894 ) Change subject: doc/tutorial/part1.md: fix package name to install qemu on Debian ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74894/comment/6901f0fc_a2840392 PS1, Line 6: > > Subject line should not end with a period. […] Done https://review.coreboot.org/c/coreboot/+/74894/comment/a007f223_8a793cb4 PS1, Line 7: Documentation/tutorial/part1.md > This prefix doesn't have to be a full path. It only should point into […] Done https://review.coreboot.org/c/coreboot/+/74894/comment/9e61789d_e2aa50a7 PS1, Line 9: Fix package name to install qemu on Debian. It used to be 'qemu' only but it is > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] Done Patchset: PS2: Suggestions implemented, guys! Please review! -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 May 2023 00:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Inject SPD binaries to APCB
by Eric Lai (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin Roth, Tim Van Patten, Karthik Ramasubramanian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74746 ) Change subject: mb/google/myst: Inject SPD binaries to APCB ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Will APCB include in the local build for factory? -- To view, visit https://review.coreboot.org/c/coreboot/+/74746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic511cdc4fe0989c9abc0cd0531cc0cae40f8dc34 Gerrit-Change-Number: 74746 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 May 2023 23:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/phoenix: Add default vBIOS ID and location
by Fred Reitberger (Code Review) 01 May '23

01 May '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74905 ) Change subject: soc/amd/phoenix: Add default vBIOS ID and location ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iadc32f4dbf8bd48d8666a213d7b5f3ba42175a90 Gerrit-Change-Number: 74905 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 01 May 2023 22:19:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: src/mb/google/rex/variants: Add directory for new variant rex0_ISH
by build bot (Jenkins) (Code Review) 01 May '23

01 May '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74875 ) Change subject: src/mb/google/rex/variants: Add directory for new variant rex0_ISH ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/rex/variants/rex0_ISH/memory/mem_parts_used.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175323): https://review.coreboot.org/c/coreboot/+/74875/comment/b4b9c72b_b8fdbc3e PS1, Line 9: # See util/spd_tools/README.md for more details and instructions. 'README' may be misspelled - perhaps 'README'? -- To view, visit https://review.coreboot.org/c/coreboot/+/74875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib94aae318822a29746678d6636f732045c2ff9b1 Gerrit-Change-Number: 74875 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 01 May 2023 22:10:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/google/rex/Kconfig: Add new variant rex0_ISH configs
by Jay Patel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Jay Patel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74878 ) Change subject: src/mb/google/rex/Kconfig: Add new variant rex0_ISH configs ...................................................................... src/mb/google/rex/Kconfig: Add new variant rex0_ISH configs Add configs related to new variant in "rex/Kconfig" and add new variant name to Kconfig.name BUG= TEST=When combined with other ebuild changes, new coreboot image created after emerge build by the name image-rex0_ISH.bin and similar for dev and serial images. Signed-off-by: Jay Patel <jay2.patel(a)intel.com> Change-Id: Iad2e33b190c691323f4f9868602dfbab9d72760a --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/Kconfig.name 2 files changed, 30 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/74878/1 diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 528a2dc..06a636a 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -43,6 +43,10 @@ select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 +config BOARD_GOOGLE_REX0_ISH + def_bool n + select DRIVERS_INTEL_ISH + if BOARD_GOOGLE_REX_COMMON config BASEBOARD_DIR @@ -80,12 +84,13 @@ default "Google_Rex" if BOARD_GOOGLE_BASEBOARD_REX config MAINBOARD_PART_NUMBER - default "Rex" if BOARD_GOOGLE_REX0 + default "Rex" if BOARD_GOOGLE_REX0 || BOARD_GOOGLE_REX0_ISH default "Screebo" if BOARD_GOOGLE_SCREEBO config VARIANT_DIR string default "rex0" if BOARD_GOOGLE_REX0 + default "rex0_ISH" if BOARD_GOOGLE_REX0_ISH default "screebo" if BOARD_GOOGLE_SCREEBO config DIMM_SPD_SIZE @@ -109,7 +114,7 @@ config DRIVER_TPM_I2C_BUS hex - default 0x4 if BOARD_GOOGLE_REX0 + default 0x4 if BOARD_GOOGLE_REX0 || BOARD_GOOGLE_REX0_ISH config DRIVER_TPM_I2C_ADDR hex diff --git a/src/mainboard/google/rex/Kconfig.name b/src/mainboard/google/rex/Kconfig.name index 886a2f0..8eb75ea 100644 --- a/src/mainboard/google/rex/Kconfig.name +++ b/src/mainboard/google/rex/Kconfig.name @@ -5,6 +5,11 @@ select BOARD_GOOGLE_BASEBOARD_REX select DRIVERS_GENESYSLOGIC_GL9755 +config BOARD_GOOGLE_REX0_ISH + bool "-> Rex 0 ISH" + select BOARD_GOOGLE_BASEBOARD_REX + select DRIVERS_GENESYSLOGIC_GL975 + config BOARD_GOOGLE_SCREEBO bool "-> Screebo" select BOARD_GOOGLE_BASEBOARD_REX -- To view, visit https://review.coreboot.org/c/coreboot/+/74878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2e33b190c691323f4f9868602dfbab9d72760a Gerrit-Change-Number: 74878 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023