coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Yidi Lin (Code Review) 01 May '23

01 May '23

Attention is currently required from: Ruihai Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74871/comment/cda34362_5f74fc4a PS3, Line 9: cbfs CBFS -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 04:45:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/mipi: Add support for STA_HIMAX83102_J02 panel
by Yidi Lin (Code Review) 01 May '23

01 May '23

Attention is currently required from: Paul Menzel, Ruihai Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74084 ) Change subject: drivers/mipi: Add support for STA_HIMAX83102_J02 panel ...................................................................... Patch Set 13: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74084/comment/da48a399_d5345cf0 PS13, Line 9: cbfs CBFS -- To view, visit https://review.coreboot.org/c/coreboot/+/74084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I382bdc89e5a217fd1c28e677938f454dc09725cc Gerrit-Change-Number: 74084 Gerrit-PatchSet: 13 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 04:44:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/pc80/rtc/option.c: Allow CMOS defaults to extend to bank 1
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Attention is currently required from: Paul Menzel, Angel Pons, Jonathon Hall, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74902 ) Change subject: drivers/pc80/rtc/option.c: Allow CMOS defaults to extend to bank 1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ee8364d01dd8520be101de3f83d2302d50c7283 Gerrit-Change-Number: 74902 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 May 2023 04:43:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/i82801ix: Drop __ASSEMBLER__ guard
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74910 ) Change subject: sb/intel/i82801ix: Drop __ASSEMBLER__ guard ...................................................................... sb/intel/i82801ix: Drop __ASSEMBLER__ guard No longer needed, this was used with old SMM relocate code. Change-Id: I7c913e10eb965419c7d2ddede744f8140a5b7976 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/southbridge/intel/i82801ix/i82801ix.h 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/74910/1 diff --git a/src/southbridge/intel/i82801ix/i82801ix.h b/src/southbridge/intel/i82801ix/i82801ix.h index 68b268b..2dffb61 100644 --- a/src/southbridge/intel/i82801ix/i82801ix.h +++ b/src/southbridge/intel/i82801ix/i82801ix.h @@ -144,7 +144,6 @@ #define FD_SAD1 (1 << 2) /* SATA #1 */ #ifndef __ACPI__ -#ifndef __ASSEMBLER__ #include <device/pci_ops.h> @@ -162,6 +161,5 @@ void i82801ix_dmi_poll_vc1(void); #endif -#endif #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/74910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c913e10eb965419c7d2ddede744f8140a5b7976 Gerrit-Change-Number: 74910 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: sb/intel: Drop redundant defines
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74909 ) Change subject: sb/intel: Drop redundant defines ...................................................................... sb/intel: Drop redundant defines Change-Id: I7655de5a8fcd5ac5c820938059bbb8b1ad877db7 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/southbridge/intel/i82801dx/i82801dx.h M src/southbridge/intel/i82801ix/i82801ix.h M src/southbridge/intel/i82801jx/i82801jx.h 3 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/74909/1 diff --git a/src/southbridge/intel/i82801dx/i82801dx.h b/src/southbridge/intel/i82801dx/i82801dx.h index 99f3af3..4eb7357 100644 --- a/src/southbridge/intel/i82801dx/i82801dx.h +++ b/src/southbridge/intel/i82801dx/i82801dx.h @@ -10,8 +10,6 @@ void i82801dx_early_init(void); void i82801dx_lpc_setup(void); -#define DEBUG_PERIODIC_SMIS 0 - #define MAINBOARD_POWER_OFF 0 #define MAINBOARD_POWER_ON 1 #define MAINBOARD_POWER_KEEP 2 diff --git a/src/southbridge/intel/i82801ix/i82801ix.h b/src/southbridge/intel/i82801ix/i82801ix.h index f0b60f6..68b268b 100644 --- a/src/southbridge/intel/i82801ix/i82801ix.h +++ b/src/southbridge/intel/i82801ix/i82801ix.h @@ -20,8 +20,6 @@ #define DEFAULT_TCOBASE (DEFAULT_PMBASE + 0x60) #define DEFAULT_GPIOBASE 0x00000580 -#define APM_CNT 0xb2 - #define GP_IO_USE_SEL 0x00 #define GP_IO_SEL 0x04 #define GP_LVL 0x0c @@ -31,8 +29,6 @@ #define GP_IO_SEL2 0x34 #define GP_LVL2 0x38 -#define DEBUG_PERIODIC_SMIS 0 - #define MAINBOARD_POWER_OFF 0 #define MAINBOARD_POWER_ON 1 #define MAINBOARD_POWER_KEEP 2 diff --git a/src/southbridge/intel/i82801jx/i82801jx.h b/src/southbridge/intel/i82801jx/i82801jx.h index 33386f5..dc1130b 100644 --- a/src/southbridge/intel/i82801jx/i82801jx.h +++ b/src/southbridge/intel/i82801jx/i82801jx.h @@ -11,8 +11,6 @@ #define DEFAULT_TCOBASE (DEFAULT_PMBASE + 0x60) #define DEFAULT_GPIOBASE 0x00000580 -#define APM_CNT 0xb2 - #define GP_IO_USE_SEL 0x00 #define GP_IO_SEL 0x04 #define GP_LVL 0x0c @@ -22,8 +20,6 @@ #define GP_IO_SEL2 0x34 #define GP_LVL2 0x38 -#define DEBUG_PERIODIC_SMIS 0 - #define MAINBOARD_POWER_OFF 0 #define MAINBOARD_POWER_ON 1 #define MAINBOARD_POWER_KEEP 2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7655de5a8fcd5ac5c820938059bbb8b1ad877db7 Gerrit-Change-Number: 74909 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: sb/intel/common: Fix corner-case with Kconfig
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74908 ) Change subject: sb/intel/common: Fix corner-case with Kconfig ...................................................................... sb/intel/common: Fix corner-case with Kconfig To select COMMON_SMM should not imply COMMON_PMBASE, it's really a depencency. Select them both explicitly for i82801dx. Change-Id: I387ade9cfd38b6555ed9e37c1b9178a6da2d7260 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/southbridge/intel/common/Kconfig.common M src/southbridge/intel/i82801dx/Kconfig 2 files changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74908/1 diff --git a/src/southbridge/intel/common/Kconfig.common b/src/southbridge/intel/common/Kconfig.common index 2da6971..e138f5e 100644 --- a/src/southbridge/intel/common/Kconfig.common +++ b/src/southbridge/intel/common/Kconfig.common @@ -59,7 +59,7 @@ def_bool n select HAVE_POWER_STATE_AFTER_FAILURE select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE - select SOUTHBRIDGE_INTEL_COMMON_PMBASE + depends on SOUTHBRIDGE_INTEL_COMMON_PMBASE config SOUTHBRIDGE_INTEL_COMMON_FINALIZE bool diff --git a/src/southbridge/intel/i82801dx/Kconfig b/src/southbridge/intel/i82801dx/Kconfig index 8393f38..20a56e7 100644 --- a/src/southbridge/intel/i82801dx/Kconfig +++ b/src/southbridge/intel/i82801dx/Kconfig @@ -6,11 +6,12 @@ select ACPI_COMMON_MADT_LAPIC select ACPI_INTEL_HARDWARE_SLEEP_VALUES select HAVE_SMI_HANDLER - select SOUTHBRIDGE_INTEL_COMMON_SMBUS - select SOUTHBRIDGE_INTEL_COMMON_SMM select SOUTHBRIDGE_INTEL_COMMON_EARLY_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_PMBASE select SOUTHBRIDGE_INTEL_COMMON_RTC select SOUTHBRIDGE_INTEL_COMMON_RESET + select SOUTHBRIDGE_INTEL_COMMON_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_SMM select SOUTHBRIDGE_INTEL_COMMON_USB_DEBUG select HAVE_POWER_STATE_AFTER_FAILURE select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE -- To view, visit https://review.coreboot.org/c/coreboot/+/74908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I387ade9cfd38b6555ed9e37c1b9178a6da2d7260 Gerrit-Change-Number: 74908 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Convert literal uses of CONFIG_MAINBOARD_{VENDOR,PART_NUMBER}
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Attention is currently required from: Hung-Te Lin, Michał Żygowski, Michał Kopeć, Yu-Ping Wu, Yidi Lin, Piotr Król. Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74907 ) Change subject: Convert literal uses of CONFIG_MAINBOARD_{VENDOR,PART_NUMBER} ...................................................................... Convert literal uses of CONFIG_MAINBOARD_{VENDOR,PART_NUMBER} Only expand these strings in lib/identity.o. Change-Id: I8732bbeff8cf8a757bf32fdb615b1d0f97584585 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/arch/x86/mpspec.c M src/drivers/i2c/max98390/max98390.c M src/lib/fit.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/msi/ms7d25/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c 7 files changed, 36 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/74907/1 diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index cbf6743..64712c7 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -9,6 +9,7 @@ #include <device/device.h> #include <device/path.h> #include <device/pci_ids.h> +#include <identity.h> #include <stdint.h> #include <string.h> @@ -33,16 +34,16 @@ mc->mpe_checksum = 0; mc->reserved = 0; - strncpy(mc->mpc_oem, CONFIG_MAINBOARD_VENDOR, 8); - strncpy(mc->mpc_productid, CONFIG_MAINBOARD_PART_NUMBER, 12); + strncpy(mc->mpc_oem, mainboard_vendor, 8); + strncpy(mc->mpc_productid, mainboard_part_number, 12); /* * The oem/productid fields are exactly 8/12 bytes long. If the resp. * entry is shorter, the remaining bytes are filled with spaces. */ - for (i = MIN(strlen(CONFIG_MAINBOARD_VENDOR), 8); i < 8; i++) + for (i = MIN(strlen(mainboard_vendor), 8); i < 8; i++) mc->mpc_oem[i] = ' '; - for (i = MIN(strlen(CONFIG_MAINBOARD_PART_NUMBER), 12); i < 12; i++) + for (i = MIN(strlen(mainboard_part_number), 12); i < 12; i++) mc->mpc_productid[i] = ' '; } diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index 12c8c9d..9786e2b 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -6,6 +6,7 @@ #include <device/i2c.h> #include <device/device.h> #include <device/path.h> +#include <identity.h> #include <stdint.h> #include <vendorcode/google/chromeos/chromeos.h> #include "chip.h" @@ -68,8 +69,8 @@ dp = acpi_dp_new_table("_DSD"); size_t chars = snprintf(dsm_name, sizeof(dsm_name), "%s_%s_%s.bin", - config->dsm_param_file_name, CONFIG_MAINBOARD_VENDOR, - CONFIG_MAINBOARD_PART_NUMBER); + config->dsm_param_file_name, mainboard_vendor, + mainboard_part_number); if (chars >= sizeof(dsm_name)) printk(BIOS_ERR, "String too long in %s\n", __func__); diff --git a/src/lib/fit.c b/src/lib/fit.c index 0513950..9db083e 100644 --- a/src/lib/fit.c +++ b/src/lib/fit.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <ctype.h> #include <endian.h> +#include <identity.h> #include <bootmem.h> #include <string.h> #include <program_loading.h> @@ -42,30 +43,28 @@ if ((board_id() != UNDEFINED_STRAPPING_ID) && (sku_id() != UNDEFINED_STRAPPING_ID)) { snprintf(compat_string, sizeof(compat_string), - "%s,%s-rev%u-sku%u", CONFIG_MAINBOARD_VENDOR, - CONFIG_MAINBOARD_PART_NUMBER, board_id(), sku_id()); + "%s,%s-rev%u-sku%u", mainboard_vendor, mainboard_part_number, + board_id(), sku_id()); fit_add_compat_string(compat_string); } if (board_id() != UNDEFINED_STRAPPING_ID) { snprintf(compat_string, sizeof(compat_string), "%s,%s-rev%u", - CONFIG_MAINBOARD_VENDOR, CONFIG_MAINBOARD_PART_NUMBER, - board_id()); + mainboard_vendor, mainboard_part_number, board_id()); fit_add_compat_string(compat_string); } if (sku_id() != UNDEFINED_STRAPPING_ID) { snprintf(compat_string, sizeof(compat_string), "%s,%s-sku%u", - CONFIG_MAINBOARD_VENDOR, CONFIG_MAINBOARD_PART_NUMBER, - sku_id()); + mainboard_vendor, mainboard_part_number, sku_id()); fit_add_compat_string(compat_string); } snprintf(compat_string, sizeof(compat_string), "%s,%s", - CONFIG_MAINBOARD_VENDOR, CONFIG_MAINBOARD_PART_NUMBER); + mainboard_vendor, mainboard_part_number); fit_add_compat_string(compat_string); } diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 56693c3..5d24c5b 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -1,14 +1,15 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <arch/io.h> +#include <arch/ioapic.h> #include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/lapic_def.h> #include <cpu/x86/mp.h> -#include <arch/io.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <arch/ioapic.h> #include <device/device.h> +#include <identity.h> #include <stdlib.h> #include <smbios.h> #include <types.h> @@ -191,7 +192,7 @@ t->type_detail = MEMORY_TYPE_DETAIL_SYNCHRONOUS; t->speed = 200; t->clock_speed = 200; - t->manufacturer = smbios_add_string(t->eos, CONFIG_MAINBOARD_VENDOR); + t->manufacturer = smbios_add_string(t->eos, mainboard_vendor); const int len = smbios_full_table_len(&t->header, t->eos); *current += len; diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index e1c50f4..69047fa 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -11,6 +11,7 @@ #include <edid.h> #include <framebuffer_info.h> #include <gpio.h> +#include <identity.h> #include <soc/bl31.h> #include <soc/ddp.h> #include <soc/dsi.h> @@ -65,7 +66,7 @@ struct panel_description __weak *get_panel_description(int panel_id) { printk(BIOS_ERR, "%s: ERROR: No panels defined for board: %s.\n", - __func__, CONFIG_MAINBOARD_PART_NUMBER); + __func__, mainboard_part_number); return NULL; } diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index 539f897e..ee781d5 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -2,6 +2,7 @@ #include <acpi/acpi.h> #include <device/device.h> +#include <identity.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <smbios.h> @@ -49,7 +50,7 @@ return "PRO Z690-A (MS-7D25)"; } - return CONFIG_MAINBOARD_PART_NUMBER; + return mainboard_part_number; } /* Only baseboard serial number is populated */ diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index 9371ee9..ab9156f 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <gpio.h> +#include <identity.h> #include <southbridge/amd/pi/hudson/hudson.h> #include <southbridge/amd/pi/hudson/pci_devs.h> #include <southbridge/amd/pi/hudson/amd_pci_int_defs.h> @@ -226,7 +227,7 @@ static void mainboard_enable(struct device *dev) { /* Maintain this text unchanged for manufacture process. */ - printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); + printk(BIOS_INFO, "Mainboard %s Enable.\n", mainboard_part_number); config_gpio_mux(); -- To view, visit https://review.coreboot.org/c/coreboot/+/74907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8732bbeff8cf8a757bf32fdb615b1d0f97584585 Gerrit-Change-Number: 74907 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Drop many cases of CONFIG_MAINBOARD_PART_NUMBER
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Attention is currently required from: Hung-Te Lin, Michał Żygowski, Jason Nien, Michał Kopeć, Martin Roth, Yidi Lin, Yu-Ping Wu, Piotr Król. Hello Hung-Te Lin, build bot (Jenkins), Michał Żygowski, Jason Nien, Michał Kopeć, Martin Roth, Yidi Lin, Yu-Ping Wu, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74450 to look at the new patch set (#2). Change subject: Drop many cases of CONFIG_MAINBOARD_PART_NUMBER ...................................................................... Drop many cases of CONFIG_MAINBOARD_PART_NUMBER We have largely dropped from filling in mainboard_ops.name as unnecessary. A common place should be decided where or if this information is added in the console log. Change-Id: I917222922560c6273b4be91cd7d99ce2ff8e4231 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/cherry/mainboard.c M src/mainboard/google/corsola/mainboard.c M src/mainboard/google/geralt/mainboard.c M src/mainboard/google/guybrush/mainboard.c M src/mainboard/google/herobrine/mainboard.c M src/mainboard/google/myst/mainboard.c M src/mainboard/google/skyrim/mainboard.c 7 files changed, 14 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/74450/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I917222922560c6273b4be91cd7d99ce2ff8e4231 Gerrit-Change-Number: 74450 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/hp: Add new port for compaq_8300_elite_usdt
by Kyösti Mälkki (Code Review) 01 May '23

01 May '23

Attention is currently required from: Riku Viitanen. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906 ) Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ...................................................................... Patch Set 1: (5 comments) File src/mainboard/hp/compaq_8300_elite_usdt/board_info.txt: https://review.coreboot.org/c/coreboot/+/74906/comment/e16206fb_e68170ba PS1, Line 5: Flashrom support: n Why not ? File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74906/comment/bb891224_65fc2bb9 PS1, Line 9: register "gen2_dec" = "0x00fc0801" The latter seems like reasonable I/O decode for 0x800. But is 0xa00 wrong and 0x600 missing? https://review.coreboot.org/c/coreboot/+/74906/comment/da497359_e30cc10b PS1, Line 80: io 0x60 = 0x600 LPC decode required from 0x600 https://review.coreboot.org/c/coreboot/+/74906/comment/e8aa970a_5b05a62f PS1, Line 128: io 0x62 = 0x0690 IO decode would probably end at 0x700, and 256 bytes maybe the only choice for the range. File src/mainboard/hp/compaq_8300_elite_usdt/gpio.c: https://review.coreboot.org/c/coreboot/+/74906/comment/635e3fae_d4e27439 PS1, Line 5: static const struct pch_gpio_set1 pch_gpio_set1_mode = { Did you capture these tables with inteltool booting with OEM? -- To view, visit https://review.coreboot.org/c/coreboot/+/74906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dc31778c2aa1987d5acdf355973a203dd0bb3a3 Gerrit-Change-Number: 74906 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Riku Viitanen Gerrit-Comment-Date: Tue, 02 May 2023 04:32:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Disable C1E on RPL CPUs
by Eric Lai (Code Review) 01 May '23

01 May '23

Attention is currently required from: YH Lin, Tarun Tuli, Joey Peng, Paul Menzel, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74727 ) Change subject: soc/intel/alderlake: Disable C1E on RPL CPUs ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74727/comment/ea6423a5_4d7f1292 PS9, Line 9: Disable C1E on RPL CPUs Could you add more description for what the reason to do it? Enable C1E will cause what issue etc.. -- To view, visit https://review.coreboot.org/c/coreboot/+/74727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2d2d5d6075de25141c1d08ec18838731c63a342 Gerrit-Change-Number: 74727 Gerrit-PatchSet: 9 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 02:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023