coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Angel Pons (Code Review) 03 May '23

03 May '23

Attention is currently required from: Sean Rhodes, Nico Huber, Angel Pons, Maximilian Brune, Lean Sheng Tan. Hello build bot (Jenkins), Benjamin Doron, Maximilian Brune, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74121 to look at the new patch set (#5). Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... [RFC] drivers/option: Add option list in cbtable TODO: rewrite commit msg, add proper documentation. Maybe add tests. Introduce a mechanism so that coreboot can provide a list of options to post-coreboot code. This can be used to let payloads know which options should be displayed in a setup menu, for instance. Although this system was written to be used with edk2, it has been designed with flexibility in mind so that other payloads can also make use of this mechanism. The data structures follow a hitherto undefined specification, known as CFR. This acronym could mean "coreboot forms representation" or "cursed forms representation"; whether the former or the latter is the intended expansion is left as an exercise for the reviewer. It should be possible to extend these structures in the future, in case additional functionality is needed. Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/commonlib/include/commonlib/coreboot_tables.h A src/drivers/option/Kconfig A src/drivers/option/Makefile.inc A src/drivers/option/cfr.c A src/drivers/option/cfr.h 5 files changed, 474 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/74121/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/brya: Implement touchscreen power sequencing
by Tarun Tuli (Code Review) 03 May '23

03 May '23

Attention is currently required from: Eran Mitrani, Matt DeVillier. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74928 ) Change subject: mb/google/brya: Implement touchscreen power sequencing ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Hi Matt. We'll quickly do some sanity test on this on a few of our devices. (didn't mean to resolve yet) -- To view, visit https://review.coreboot.org/c/coreboot/+/74928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e56ac4834ce69de18bef2d34f5c361a7fda1aab Gerrit-Change-Number: 74928 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 03 May 2023 17:38:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Implement touchscreen power sequencing
by Tarun Tuli (Code Review) 03 May '23

03 May '23

Attention is currently required from: Eran Mitrani, Matt DeVillier. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74928 ) Change subject: mb/google/brya: Implement touchscreen power sequencing ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Matt. We'll quickly do some sanity test on this on a few of our devices. -- To view, visit https://review.coreboot.org/c/coreboot/+/74928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e56ac4834ce69de18bef2d34f5c361a7fda1aab Gerrit-Change-Number: 74928 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 03 May 2023 17:38:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/amdfwtool: Consolidate entry line regex pattern
by Karthik Ramasubramanian (Code Review) 03 May '23

03 May '23

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74950 ) Change subject: util/amdfwtool: Consolidate entry line regex pattern ...................................................................... util/amdfwtool: Consolidate entry line regex pattern There are 2 regex patterns defined to process the lines from *fw.cfg: 1) for lines with mandatory entries 2) for lines with mandatory + optional entries Consolidate the regex pattern. Add enums for matching regex caller groups so that the human readable group IDs can be used instead of magic numbers. BUG=None TEST=Build Skyrim BIOS which only have mandatory entries. Build Guybrush BIOS image which have both mandatory and optional entries. Confirm that the amdfw.rom built before and after this change are of same size in both Skyrim and Guybrush images. This ensures that the optional level entries in Guybrush are handled as expected. Boot to OS in Skyrim. Change-Id: I7289ddbbec4d5daefe64f59b687ba3a4af46d052 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M util/amdfwtool/data_parse.c 1 file changed, 55 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/74950/1 diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c index 50f844f..b94e46f 100644 --- a/util/amdfwtool/data_parse.c +++ b/util/amdfwtool/data_parse.c @@ -29,22 +29,7 @@ "[[:space:]]+" /* followed by a chunk of nonwhitespace for filename field */ "([^[:space:]]+)" - /* followed by optional whitespace */ - "[[:space:]]*$"; -static regex_t entries_line_expr; - -static const char entries_lvl_line_regex[] = - /* optional whitespace */ - "^[[:space:]]*" - /* followed by a chunk of nonwhitespace for macro field */ - "([^[:space:]]+)" - /* followed by one or more whitespace characters */ - "[[:space:]]+" - /* followed by a chunk of nonwhitespace for filename field */ - "([^[:space:]]+)" - /* followed by one or more whitespace characters */ - "[[:space:]]+" - /* followed by a chunk of nonwhitespace for level field + /* followed by an optional whitespace + chunk of nonwhitespace for level field 1st char L: Indicator of field "level" 2nd char: Directory level to be dropped in. @@ -60,10 +45,18 @@ L12: Level 1 for normal mode, level 2 for A/B mode Lx1: Use default value for normal mode, level 1 for A/B mode */ - "([Ll][12bxBX]{1,2})" + "([[:space:]]+([Ll][12bxBX]{1,2}))?" /* followed by optional whitespace */ "[[:space:]]*$"; -static regex_t entries_lvl_line_expr; +static regex_t entries_line_expr; + +enum match_id { + FW_TYPE = 1, + FW_FILE, + OPT_SPACE1, + OPT_LEVEL, + N_MATCHES, +}; void compile_reg_expr(int cflags, const char *expr, regex_t *reg) { @@ -579,7 +572,6 @@ return OK; } -#define N_MATCHES 4 static int is_valid_entry(char *oneline, regmatch_t match[N_MATCHES]) { int retval, index; @@ -588,18 +580,14 @@ match[index].rm_so = -1; match[index].rm_eo = -1; } - if (regexec(&entries_line_expr, oneline, 3, match, 0) == 0) { - oneline[match[1].rm_eo] = '\0'; - oneline[match[2].rm_eo] = '\0'; - retval = 1; - } else if (regexec(&entries_lvl_line_expr, oneline, 4, match, 0) == 0) { + if (regexec(&entries_line_expr, oneline, N_MATCHES, match, 0) == 0) { /* match[1]: FW type match[2]: FW filename - match[3]: Directory level to be dropped + match[4]: Optional directory level to be dropped */ - oneline[match[1].rm_eo] = '\0'; - oneline[match[2].rm_eo] = '\0'; - oneline[match[3].rm_eo] = '\0'; + oneline[match[FW_TYPE].rm_eo] = '\0'; + oneline[match[FW_FILE].rm_eo] = '\0'; + oneline[match[OPT_LEVEL].rm_eo] = '\0'; retval = 1; } else { retval = 0; @@ -645,10 +633,11 @@ static uint8_t process_one_line(char *oneline, regmatch_t *match, char *dir, amd_cb_config *cb_config) { - char *path_filename, *fn = &(oneline[match[2].rm_so]); - char *fw_type_str = &(oneline[match[1].rm_so]); + char *path_filename, *fn = &(oneline[match[FW_FILE].rm_so]); + char *fw_type_str = &(oneline[match[FW_TYPE].rm_so]); char ch_lvl = 'x'; - regoff_t ch_lvl_index = match[3].rm_so; + regoff_t ch_lvl_index = match[OPT_LEVEL].rm_so == match[OPT_LEVEL].rm_eo ? + -1 : match[OPT_LEVEL].rm_so; /* If the optional level field is present, extract the level char. */ @@ -703,6 +692,8 @@ } } +#define FW_LOCATION "FIRMWARE_LOCATION" +#define SOC_NAME "SOC_NAME" /* return value: 0: The config file can not be parsed correctly. @@ -725,8 +716,6 @@ blank_or_comment_regex, &blank_or_comment_expr); compile_reg_expr(REG_EXTENDED | REG_NEWLINE, entries_line_regex, &entries_line_expr); - compile_reg_expr(REG_EXTENDED | REG_NEWLINE, - entries_lvl_line_regex, &entries_lvl_line_expr); /* Get a line */ /* Get FIRMWARE_LOCATION in the first loop */ @@ -735,14 +724,14 @@ if (skip_comment_blank_line(oneline)) continue; if (is_valid_entry(oneline, match)) { - if (strcmp(&(oneline[match[1].rm_so]), "FIRMWARE_LOCATION") == 0) { - dir_len = match[2].rm_eo - match[2].rm_so; + if (strcmp(&(oneline[match[FW_TYPE].rm_so]), FW_LOCATION) == 0) { + dir_len = match[FW_FILE].rm_eo - match[FW_FILE].rm_so; assert(dir_len < MAX_LINE_SIZE); snprintf(dir, MAX_LINE_SIZE, "%.*s", dir_len, - &(oneline[match[2].rm_so])); - } else if (strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) { - cb_config->soc_id = - identify_platform(&(oneline[match[2].rm_so])); + &(oneline[match[FW_FILE].rm_so])); + } else if (strcmp(&(oneline[match[FW_TYPE].rm_so]), SOC_NAME) == 0) { + cb_config->soc_id = identify_platform( + &(oneline[match[FW_FILE].rm_so])); } } } @@ -770,8 +759,8 @@ if (skip_comment_blank_line(oneline)) continue; if (is_valid_entry(oneline, match)) { - if (strcmp(&(oneline[match[1].rm_so]), "FIRMWARE_LOCATION") == 0 || - strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) { + if (strcmp(&(oneline[match[FW_TYPE].rm_so]), FW_LOCATION) == 0 || + strcmp(&(oneline[match[FW_TYPE].rm_so]), SOC_NAME) == 0) { continue; } else { if (process_one_line(oneline, match, dir, -- To view, visit https://review.coreboot.org/c/coreboot/+/74950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7289ddbbec4d5daefe64f59b687ba3a4af46d052 Gerrit-Change-Number: 74950 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
by Angel Pons (Code Review) 03 May '23

03 May '23

Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 ) Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable ...................................................................... Patch Set 4: (2 comments) File src/mainboard/prodrive/atlas/cfr.c: https://review.coreboot.org/c/coreboot/+/74122/comment/3c917f37_6480493e PS4, Line 247: SM_DECLARE_BOOL(pcie_sris), missing terminator. let's be explicit about array lengths instead... https://review.coreboot.org/c/coreboot/+/74122/comment/0bcd4eb0_ab1a3966 PS4, Line 257: SM_DECLARE_FORM(main_form), missing terminator -- To view, visit https://review.coreboot.org/c/coreboot/+/74122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231 Gerrit-Change-Number: 74122 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 03 May 2023 17:27:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
by Angel Pons (Code Review) 03 May '23

03 May '23

Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 ) Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable ...................................................................... Patch Set 4: (1 comment) File src/mainboard/prodrive/atlas/cfr.c: https://review.coreboot.org/c/coreboot/+/74122/comment/07a63c97_c1ead6ba PS4, Line 233: SM_DECLARE_NUMBER(profile), : SM_DECLARE_COMMENT(bad_profile), swap these two -- To view, visit https://review.coreboot.org/c/coreboot/+/74122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231 Gerrit-Change-Number: 74122 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 03 May 2023 17:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Benjamin Doron (Code Review) 03 May '23

03 May '23

Attention is currently required from: Sean Rhodes, Nico Huber, Angel Pons, Maximilian Brune, Lean Sheng Tan. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Forms have a start and end, but so long as I can write them as a structure and copy them in as raw H […] Ah, forms aren't normally nested. It's the `goto` statements that we see nested. -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 03 May 2023 17:11:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Benjamin Doron (Code Review) 03 May '23

03 May '23

Attention is currently required from: Sean Rhodes, Nico Huber, Angel Pons, Maximilian Brune, Lean Sheng Tan. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 4: (2 comments) Patchset: PS3: > Patchset 4 allows forms to be nested, which can be used to group settings like you mentioned. […] Forms have a start and end, but so long as I can write them as a structure and copy them in as raw HII, nested forms will work when I make the processing recursive. As we realised, it should probably update the outer form correctly, with all new forms. Except it's triggering an assert at the moment, we'll see. To my knowledge, formsets cannot be nested. Since we compile a small formset to insert items into, there already is one formset. So, the only way to do this, *if necessary*, is to build the entire VfrBin array at runtime. File src/drivers/option/cfr.c: https://review.coreboot.org/c/coreboot/+/74121/comment/f39e4ad4_3a688a05 PS3, Line 103: option_id > Done Oh, this is why it's in the frontend too. -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 03 May 2023 16:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: MAINTAINERS: Add Benjamin, Matt, Sean, Sheng for EDK2 payload
by Benjamin Doron (Code Review) 03 May '23

03 May '23

Attention is currently required from: Paul Menzel, Lean Sheng Tan. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74927 ) Change subject: MAINTAINERS: Add Benjamin, Matt, Sean, Sheng for EDK2 payload ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74927 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I914a7f665e246e7490c127078a5a9795c8334d92 Gerrit-Change-Number: 74927 Gerrit-PatchSet: 3 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 03 May 2023 16:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Hook up PCIe Resizable BARs flag
by Matt DeVillier (Code Review) 03 May '23

03 May '23

Attention is currently required from: Martin L Roth, Stefan Reinauer, Lean Sheng Tan. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74926 ) Change subject: payloads/edk2: Hook up PCIe Resizable BARs flag ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The code is generic enough, i think it should work. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cc12d32c5e132b9f99ec650377d7683377c2a9c Gerrit-Change-Number: 74926 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 03 May 2023 16:31:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023