coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mb/google/myst: Enable chromeOS EC
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 ) Change subject: mb/google/myst: Enable chromeOS EC ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/myst/dsdt.asl: https://review.coreboot.org/c/coreboot/+/74099/comment/14f55256_4a2c7963 PS3, Line 17: Name(LIDS, 0) > still bothering me for this. LIDS is in EC right? https://source.chromium. […] See https://review.coreboot.org/c/coreboot/+/72185 -- To view, visit https://review.coreboot.org/c/coreboot/+/74099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e Gerrit-Change-Number: 74099 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 17:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Declare CrOS GPIOs
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74096 ) Change subject: mb/google/myst: Declare CrOS GPIOs ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74096/comment/92be1f48_d14f76df PS3, Line 9: Declare CrOS GPIOs for Myst, add relevant defines > nit:fill 80 chars then warp line Done File src/mainboard/google/myst/chromeos.c: https://review.coreboot.org/c/coreboot/+/74096/comment/29389910_fcb65284 PS3, Line 6: static const struct cros_gpio cros_gpios[] = { > add this in gpio. […] This is specific to chromeOS and belongs here. The macro below `DECLARE_CROS_GPIOS` performs all of the registration and what's needed for these to be accessible. -- To view, visit https://review.coreboot.org/c/coreboot/+/74096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie876883d6ee2e3bc6324c038cefee12d99702dc9 Gerrit-Change-Number: 74096 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 16:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable chromeOS EC
by build bot (Jenkins) (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Jon Murphy. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 ) Change subject: mb/google/myst: Enable chromeOS EC ...................................................................... Patch Set 4: Verified+1 (2 comments) File src/mainboard/google/myst/variants/baseboard/include/baseboard/ec.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172953): https://review.coreboot.org/c/coreboot/+/74099/comment/a9159926_5daf8bfd PS4, Line 70: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172953): https://review.coreboot.org/c/coreboot/+/74099/comment/2a6ebc23_f00f3d04 PS4, Line 70: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/74099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e Gerrit-Change-Number: 74099 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 16:59:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Add new mainboard
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

1 0

[M] Change in coreboot[master]: mb/google/myst: Add new mainboard
by build bot (Jenkins) (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Raul Rangel, Eric Lai, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 ) Change subject: mb/google/myst: Add new mainboard ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/myst/port_descriptors.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172947): https://review.coreboot.org/c/coreboot/+/74093/comment/08e961b2_f2f28836 PS3, Line 7: const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num, need consistent spacing around '*' (ctx:WxO) -- To view, visit https://review.coreboot.org/c/coreboot/+/74093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d731ce4d6cb6d4e9041f46eb5a799865bb0b9a Gerrit-Change-Number: 74093 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 16:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Build for chromeOS
by build bot (Jenkins) (Code Review) 03 Apr '23

03 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74097 ) Change subject: mb/google/myst: Build for chromeOS ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/myst/chromeos.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172951): https://review.coreboot.org/c/coreboot/+/74097/comment/572d600a_c5abd5d6 PS4, Line 9: void fill_lb_gpios(struct lb_gpios *gpios){} space required before the open brace '{' -- To view, visit https://review.coreboot.org/c/coreboot/+/74097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b6917fe024067409bfbb3d2691c37759b5cace Gerrit-Change-Number: 74097 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Apr 2023 16:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Add new mainboard
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Raul Rangel, Eric Lai, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 ) Change subject: mb/google/myst: Add new mainboard ...................................................................... Patch Set 3: (8 comments) File src/mainboard/google/myst/Kconfig: https://review.coreboot.org/c/coreboot/+/74093/comment/928b63ad_cc6993c8 PS2, Line 12: TODO: might need to be adapted for better placement of files in cbfs > This is a copy-paste from Skyrim. We hopefully don't need a TODO here. Copy/Paste from Skyrim. Removed for now File src/mainboard/google/myst/bootblock.c: https://review.coreboot.org/c/coreboot/+/74093/comment/04fa26df_e268615e PS2, Line 8: /* TODO: Perform mainboard initialization */ > Please add a bug number to track this. Done File src/mainboard/google/myst/dsdt.asl: https://review.coreboot.org/c/coreboot/+/74093/comment/fb370a85_8f5db8d2 PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ > I think Jon did this for ease of review as well as avoid pitfalls with blind copy-paste. The entire process and stack of CL's is based on what has been done in previous programs. We build up the image in small incremental changes which allows us to review it and compare against the current code base. See https://docs.google.com/spreadsheets/d/1Do70XMx1_DdJbEvvAPc36tR8jgHChxnqVdL… and https://docs.google.com/document/d/1Qd7j9Aqk6U2zjPg25D1CA9srxWq3wpzQbwZ8f1O… https://review.coreboot.org/c/coreboot/+/74093/comment/5dfd926b_c18ffce8 PS2, Line 16: Name(LIDS, 0) > why need this here? See https://review.coreboot.org/c/coreboot/+/72185 File src/mainboard/google/myst/mainboard.c: https://review.coreboot.org/c/coreboot/+/74093/comment/e335d349_6e74ba77 PS2, Line 19: /* TODO: Perform mainboard initialization */ > Same. Add bug numbers. Done File src/mainboard/google/myst/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74093/comment/328e15aa_e28653b4 PS2, Line 10: /* TODO: Initialize DXIO and DDI descriptors */ > Bug number. Done File src/mainboard/google/myst/variants/baseboard/include/baseboard/baseboard.h: PS2: > I think this file name should be gpio. […] This file still exists in Skyrim, it looks like the original error was made there and carried forward here. Deleted and will push a CL to remove the file from skyrim as well. https://review.coreboot.org/c/coreboot/+/74093/comment/51c38b38_03f97007 PS2, Line 3: __BASEBOARD_GPIO_H__ > This guard name doesn't match the file name. This is by design, but probably a little confusing due to the bad naming. gpio.h is included from a number of nested directories, this guard is named for the baseboard copy. -- To view, visit https://review.coreboot.org/c/coreboot/+/74093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d731ce4d6cb6d4e9041f46eb5a799865bb0b9a Gerrit-Change-Number: 74093 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 16:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Add ACPI configuration for USB ports
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Jon Murphy. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74106 to look at the new patch set (#3). Change subject: mb/google/myst: Add ACPI configuration for USB ports ...................................................................... mb/google/myst: Add ACPI configuration for USB ports The USB port configuration was derived from the PPR and schematics. This board has N(some multi-purpose) ports. Primary functions are: Update me with list BUG=b:275905635 TEST=builds Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: Iecb256cad7b2daea1fddfc8323e88ff5c38d1e51 --- M src/mainboard/google/myst/variants/baseboard/devicetree.cb 1 file changed, 96 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/74106/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecb256cad7b2daea1fddfc8323e88ff5c38d1e51 Gerrit-Change-Number: 74106 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/myst: Add FW_CONFIG
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Jon Murphy. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74102 to look at the new patch set (#5). Change subject: mb/google/myst: Add FW_CONFIG ...................................................................... mb/google/myst: Add FW_CONFIG Add initial FW_CONFIG for the myst program. BUG=b: TEST=builds Cq-Depend: chrome-internal:5674351 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: If74c3649d4e8d174d9fe00a4b896c2351ee3ab19 --- M src/mainboard/google/myst/Kconfig M src/mainboard/google/myst/variants/myst/overridetree.cb 2 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74102/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If74c3649d4e8d174d9fe00a4b896c2351ee3ab19 Gerrit-Change-Number: 74102 Gerrit-PatchSet: 5 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/myst: Build for chromeOS
by Jon Murphy (Code Review) 03 Apr '23

03 Apr '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74097 to look at the new patch set (#4). Change subject: mb/google/myst: Build for chromeOS ...................................................................... mb/google/myst: Build for chromeOS Adjust build configs to build Myst for chromeOS. BUG=b:270618097 TEST=builds Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: If4b6917fe024067409bfbb3d2691c37759b5cace --- M src/mainboard/google/myst/Kconfig M src/mainboard/google/myst/Makefile.inc M src/mainboard/google/myst/chromeos.c 3 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/74097/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b6917fe024067409bfbb3d2691c37759b5cace Gerrit-Change-Number: 74097 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023