Attention is currently required from: Raul Rangel, Eric Lai, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 )
Change subject: mb/google/myst: Add new mainboard
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/myst/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/74093/comment/f25ec650_7a4b2e62
PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
> Is there a Myst version of this spreadsheet that we should be tracking these CLs with? […]
The Myst doc is meant to capture the entire process. I haven't added the Myst coreboot CL's yet, but the stack matches the Skyrim stack.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74093
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7d731ce4d6cb6d4e9041f46eb5a799865bb0b9a
Gerrit-Change-Number: 74093
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:21:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74197 )
Change subject: cpu/x86/64bit/Makefile: use all_x86 make target
......................................................................
cpu/x86/64bit/Makefile: use all_x86 make target
Use the newly introduced all_x86 make target to add the mode_switch.S
compilation unit to all stages that run on the x86 cores, but not to
verstage on PSP.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I8950375d31557d9a38169869c1d250417261c31c
---
M src/cpu/x86/64bit/Makefile.inc
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/74197/1
diff --git a/src/cpu/x86/64bit/Makefile.inc b/src/cpu/x86/64bit/Makefile.inc
index 526291a..36c69b9 100644
--- a/src/cpu/x86/64bit/Makefile.inc
+++ b/src/cpu/x86/64bit/Makefile.inc
@@ -1,8 +1,4 @@
-bootblock-y += mode_switch.S
-verstage_x86-y += mode_switch.S
-romstage-y += mode_switch.S
-postcar-y += mode_switch.S
-ramstage-y += mode_switch.S
+all_x86-y += mode_switch.S
# Add --defsym=_start=0 to suppress a linker warning.
$(objcbfs)/pt: $(dir)/pt.S $(obj)/config.h
--
To view, visit https://review.coreboot.org/c/coreboot/+/74197
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8950375d31557d9a38169869c1d250417261c31c
Gerrit-Change-Number: 74197
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74196 )
Change subject: cpu/x86/64bit/Makefile: use verstage_x86 make target
......................................................................
cpu/x86/64bit/Makefile: use verstage_x86 make target
Use the verstage_x86 make target for the mode_switch.S compilation unit
instead of making adding it to the verstage target depending on
VBOOT_STARTS_BEFORE_BOOTBLOCK not being selected. The only case where
VBOOT_STARTS_BEFORE_BOOTBLOCK is selected is the verstage on PSP case,
so I find using the verstage_x86 target here a bit easier to understand.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Iab618d4b9e325b07a648b91fcdce99c63644fbfc
---
M src/cpu/x86/64bit/Makefile.inc
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/74196/1
diff --git a/src/cpu/x86/64bit/Makefile.inc b/src/cpu/x86/64bit/Makefile.inc
index 48f56fc..526291a 100644
--- a/src/cpu/x86/64bit/Makefile.inc
+++ b/src/cpu/x86/64bit/Makefile.inc
@@ -1,7 +1,5 @@
bootblock-y += mode_switch.S
-ifneq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
-verstage-y += mode_switch.S
-endif
+verstage_x86-y += mode_switch.S
romstage-y += mode_switch.S
postcar-y += mode_switch.S
ramstage-y += mode_switch.S
--
To view, visit https://review.coreboot.org/c/coreboot/+/74196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab618d4b9e325b07a648b91fcdce99c63644fbfc
Gerrit-Change-Number: 74196
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74153 )
Change subject: drivers/pc80/pc/Makefile: use all_x86 make target
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74153/comment/b73f84ff_bc157e49
PS2, Line 9: all_x86
put in single quotes for clarity
--
To view, visit https://review.coreboot.org/c/coreboot/+/74153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23c6977ae8acebb8dcd546f86f7f7b677272a6cb
Gerrit-Change-Number: 74153
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:19:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74152 )
Change subject: cpu/x86/lapic,pae,tsc/Makefile: use all_x86 target
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74152/comment/38b1e677_46dd263f
PS2, Line 9: all_x86
put in single quotes for clarity
--
To view, visit https://review.coreboot.org/c/coreboot/+/74152
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I181c3207bb1ebe9c5080ef3a3cdda8146ed05822
Gerrit-Change-Number: 74152
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:19:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Fred Reitberger, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74151 )
Change subject: soc/amd/*/Makefile: use all_x86 target
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74151/comment/6683b2d6_7d138bdd
PS2, Line 9: all_x86
put in single quotes for clarity
--
To view, visit https://review.coreboot.org/c/coreboot/+/74151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94de6de5a4c7723065a4eb1b7149f9933ef134a1
Gerrit-Change-Number: 74151
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Bora Guvendik, Hannah Williams, Jakub Czapiga, Paul Menzel, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 )
Change subject: acpi/acpigen: Add print-like function for debug string
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73113/comment/58f051fc_6e6fc3f0
PS7, Line 7: acpi: Add print-like function for debug string
> `s/acpi/acpigen` and `s/print/printf`: […]
not sure how to have both. I will change to acpi/acpigen since no changes in printf.
https://review.coreboot.org/c/coreboot/+/73113/comment/ed0019c4_48f47e0f
PS7, Line 29:
> How can the debug strings be shown in Linux?
Ack
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/73113/comment/8d32ce6e_e767e9de
PS7, Line 1494: printk(BIOS_WARNING, "%s: ACPI Debug message exceeds buffer size!\n",
> Please print both values.
How a
--
To view, visit https://review.coreboot.org/c/coreboot/+/73113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba
Gerrit-Change-Number: 73113
Gerrit-PatchSet: 8
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Fred Reitberger, Kyösti Mälkki, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74150 )
Change subject: Makefile.inc: introduce all_x86 target
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74150/comment/3cc9fd4d_dd778a2a
PS2, Line 11: all
single-quote for clarity
https://review.coreboot.org/c/coreboot/+/74150/comment/fce2b217_63618ff7
PS2, Line 14: verstage_x88
_x86
https://review.coreboot.org/c/coreboot/+/74150/comment/cd817c57_1fe5658d
PS2, Line 14: omstage
oxford comma
--
To view, visit https://review.coreboot.org/c/coreboot/+/74150
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0184182b931185990094d0874b49c0b5cb9f7e
Gerrit-Change-Number: 74150
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Bora Guvendik, Hannah Williams, Cliff Huang, Jakub Czapiga, Tim Wawrzynczak, Nick Vaccaro.
Hello Bora Guvendik, Lance Zhao, build bot (Jenkins), Hannah Williams, Jérémy Compostella, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73113
to look at the new patch set (#8).
Change subject: acpi/acpigen: Add print-like function for debug string
......................................................................
acpi/acpigen: Add print-like function for debug string
Generate formatted string and generate code for printing this string
in ACPI.
ex: pcie_rp = 1
acpigen_write_debug_sprintf("calling _ON for RP: %u", pcie_rp);
will generate ACPI code:
Debug = "calling _ON for RP: 1"
With this new function, the following functions won't be needed and
therefore to be removed:
acpigen_concatenate_string_string()
acpigen_concatenate_string_int()
acpigen_write_debug_concatenate_string_string()
acpigen_write_debug_concatenate_string_int()
BRANCH=firmware-brya-14505.B
TEST=Add above functions in the acpigen code and check the generated
SSDT table after OS boot. Check the debug messages is in the kernel
log when /sys/modules/acpi/parameters/aml_debug_output is set to
'1'.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba
---
M src/acpi/acpigen.c
M src/include/acpi/acpigen.h
2 files changed, 51 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/73113/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/73113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba
Gerrit-Change-Number: 73113
Gerrit-PatchSet: 8
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset