coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD CnviWifiCore
by Kapil Porwal (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74306 ) Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74306/comment/441fbb0d_88d9c85d PS1, Line 7: Hook UPD CnviWifiCore > Hook UPD CnviWifiCore up or Hook up … Ack https://review.coreboot.org/c/coreboot/+/74306/comment/1b08ccb4_00f8299a PS1, Line 9: Hook the newly created/exposed CnviWifiCore UPD using chip driver. > Hook … up as a chip driver. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b4662c2a064f7c9074797c8a2541dcf1dd686fe Gerrit-Change-Number: 74306 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:54:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD CnviWifiCore
by Kapil Porwal (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74306 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore ...................................................................... soc/intel/meteorlake: Hook up UPD CnviWifiCore Hook the newly created/exposed CnviWifiCore UPD up as a chip driver. Enable this option by default to maintain the existing behavior. BUG=b:270985197 TEST=Verified by enabling/disabling the UPD on google/rex Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I5b4662c2a064f7c9074797c8a2541dcf1dd686fe --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/chipset.cb M src/soc/intel/meteorlake/fsp_params.c 3 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/74306/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b4662c2a064f7c9074797c8a2541dcf1dd686fe Gerrit-Change-Number: 74306 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: for test
by Robert Chen (Code Review) 12 Apr '23

12 Apr '23

Robert Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74307 ) Change subject: for test ...................................................................... for test Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd --- M src/mainboard/google/dedede/variants/kracko/overridetree.cb 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/74307/1 diff --git a/src/mainboard/google/dedede/variants/kracko/overridetree.cb b/src/mainboard/google/dedede/variants/kracko/overridetree.cb index e74464e..1ce3a8f 100644 --- a/src/mainboard/google/dedede/variants/kracko/overridetree.cb +++ b/src/mainboard/google/dedede/variants/kracko/overridetree.cb @@ -214,6 +214,20 @@ register "hid_desc_reg_offset" = "0x01" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" + register "generic.detect" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end + end # I2C 2 device pci 15.3 off end #I2C 3 device pci 19.0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/74307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd Gerrit-Change-Number: 74307 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/: Implement an API to get ISH version
by Sridhar Siricilla (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Paul Menzel. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 ) Change subject: soc/intel/: Implement an API to get ISH version ...................................................................... Patch Set 9: (3 comments) File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/74209/comment/252a61b4_41aa42c0 PS9, Line 1277: /* : * Initialize the CSE device with provided temporary BAR. If BAR is 0 use a : * default. This is intended for pre-mem usage only where BARs haven't been : * assigned yet and devices are not enabled. May I know how this comment is connected with get_ish_version()? https://review.coreboot.org/c/coreboot/+/74209/comment/7e28ada3_0461c93d PS9, Line 1282: bool please prefer enum cb_err. File src/soc/intel/common/block/include/intelblocks/cse.h: https://review.coreboot.org/c/coreboot/+/74209/comment/256291ea_c4788da1 PS9, Line 453: bool please prefer enum cb_err. -- To view, visit https://review.coreboot.org/c/coreboot/+/74209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 Gerrit-Change-Number: 74209 Gerrit-PatchSet: 9 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/: Store ISH firmware version into cbmem table
by Sridhar Siricilla (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 ) Change subject: soc/intel/: Store ISH firmware version into cbmem table ...................................................................... Patch Set 14: (5 comments) File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/74208/comment/98e06fad_17c7fe5d PS14, Line 1278: FSP-M memory? https://review.coreboot.org/c/coreboot/+/74208/comment/f2cf1a5b_cbf0335f PS14, Line 1279: CSE DRAM DRAM. CSE needs host memory access for ISH FW patching. Hence DRAM Init is prerequisite to get patched ISH firmware version. https://review.coreboot.org/c/coreboot/+/74208/comment/27587c62_dcb086d1 PS14, Line 1282: store_ish_version Can we move this definition to new file? https://review.coreboot.org/c/coreboot/+/74208/comment/0467ac30_eb6ad64d PS14, Line 1305: version->ish_partition_info.prev_cse_fw_version.major : = version->cur_cse_fw_version.major; : version->ish_partition_info.prev_cse_fw_version.minor : = version->cur_cse_fw_version.minor; : version->ish_partition_info.prev_cse_fw_version.hotfix : = version->cur_cse_fw_version.hotfix; : version->ish_partition_info.prev_cse_fw_version.build : = version->cur_cse_fw_version.build; : can you define generic function for copying the version from src to destination? cse_copy_fw_version(struct fw_version *src, struct fw_version *dst) https://review.coreboot.org/c/coreboot/+/74208/comment/2e7f8f16_00668a4e PS14, Line 1315: version->ish_partition_info.cur_ish_fw_version.major : = resp.manifest_data.version.major; : version->ish_partition_info.cur_ish_fw_version.minor : = resp.manifest_data.version.minor; : version->ish_partition_info.cur_ish_fw_version.hotfix : = resp.manifest_data.version.hotfix; : version->ish_partition_info.cur_ish_fw_version.build : = resp.manifest_data.version.build; You may use generic version copy function (cse_copy_fw_version) for this as described above? -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 14 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/: Store CSE firmware version into cbmem table
by Sridhar Siricilla (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 ) Change subject: soc/intel/: Store CSE firmware version into cbmem table ...................................................................... Patch Set 10: Code-Review+1 (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74256/comment/77b03387_6639e37d PS10, Line 1093: version->cur_cse_fw_version.major = cse_bp->fw_ver.major; : version->cur_cse_fw_version.minor = cse_bp->fw_ver.minor; : version->cur_cse_fw_version.hotfix = cse_bp->fw_ver.hotfix; : version->cur_cse_fw_version.build = cse_bp->fw_ver.build; : } You may use define and use generic function like cse_copy_fw_version() {https://review.coreboot.org/c/coreboot/+/74208/14/src/soc/intel/common/block/cse/cse.c#1313} -- To view, visit https://review.coreboot.org/c/coreboot/+/74256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8 Gerrit-Change-Number: 74256 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:30:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Dtrain Hsu, Subrata Banik, Reka Norman, Shou-Chieh Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74335 ) Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74335/comment/f5a91275_6de423fd PS4, Line 10: to achieve the better power savings. Drop *the*. https://review.coreboot.org/c/coreboot/+/74335/comment/99f9bb3f_aa55d7cb PS4, Line 11: * Enable the external V1p05, Vnn, VnnSx rails in S0i1, S0i2, S0i3, S3, Please add a blank line above. https://review.coreboot.org/c/coreboot/+/74335/comment/f79b4c85_49ee7540 PS4, Line 16: Please add the exact numbers of power savings to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/74335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919 Gerrit-Change-Number: 74335 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:28:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add VPU into the DMAR SATC table
by Kapil Porwal (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, John Zhao. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74221 ) Change subject: soc/intel/meteorlake: Add VPU into the DMAR SATC table ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/acpi.c: https://review.coreboot.org/c/coreboot/+/74221/comment/40e14119_9b0bdf13 PS1, Line 273: acpi_create_dmar_ds_pci You are not checking if the device is enabled or not. Is this ok? -- To view, visit https://review.coreboot.org/c/coreboot/+/74221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d4af7c9844e33483a1e616eaee061a90d0be6fc Gerrit-Change-Number: 74221 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:28:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Update Flash Layout to fit WP_RO within 4MB
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74229 ) Change subject: mb/google/rex: Update Flash Layout to fit WP_RO within 4MB ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74229/comment/a9795bed_d219f233 PS1, Line 9: This patch updates the Rex flash layout to optimize WP_RO to 4MB. > > > The board was apparently added with 8 MB, so why is it too big now? What optimization is done? […] Thank you for adding that paragraph. It helped me. https://review.coreboot.org/c/coreboot/+/74229/comment/3f973961_7ed1bda1 PS1, Line 9: This patch updates the Rex flash layout to optimize WP_RO to 4MB. : : Changes for chromeos.fmd: : : SI_BIOS: : RW_SECTION_A/B: Reduce to 7MB. : RW_LEGACY: Reduce to 1MB. : RW_MISC: Increased to 1MB. : RW_UNUSED: 3MB (reserved) : WP_RO: Reduce to 4MB : : Additionally, ensure RW_SECTION_B region starts at 16MB boundary in the : SPI Flash. > > > I am sorry you are feeling this way. […] A lot of my comments were ignorance and thinking errors on my part. Sorry about that. File src/mainboard/google/rex/chromeos.fmd: https://review.coreboot.org/c/coreboot/+/74229/comment/4b9e3d4b_3e2834c9 PS1, Line 7: 7M > > > Changing 7092K to 7M is cosmetic, isn’t it? […] I am sorry, I miscalculated 7 * 1024 and thought it’s 7092K instead of 7168K. So it’s not a cosmetic change. I am sorry for the noise. -- To view, visit https://review.coreboot.org/c/coreboot/+/74229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccf83b7bb66d0d5503e0ff9e9a819051296c6724 Gerrit-Change-Number: 74229 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:27:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/docker/jenkins-node: Clean up package installation
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74245 ) Change subject: util/docker/jenkins-node: Clean up package installation ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74245/comment/3f067a47_96e0fe99 PS2, Line 7: Clean up package installation Maybe: > Merge Python/Ruby package installation into first install step https://review.coreboot.org/c/coreboot/+/74245/comment/d8289247_871c1ef9 PS2, Line 11: It might be the container way, to have an image for each step, so you only need to update smaller layers. -- To view, visit https://review.coreboot.org/c/coreboot/+/74245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe620e5b20a5f1a5d4e1c4c98942c136f450f280 Gerrit-Change-Number: 74245 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023