coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: [WIP] ACPI MADT: Use common IOAPIC IRQ override entries
by Kyösti Mälkki (Code Review) 12 Apr '23

12 Apr '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69529 ) Change subject: [WIP] ACPI MADT: Use common IOAPIC IRQ override entries ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/69529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8bc51d91d0071eb03c50d57ef77d8c9b3d89d4b6 Gerrit-Change-Number: 69529 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilit...
by build bot (Jenkins) (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Jonathan Zhang, Simon Chou, Jingle Hsu, Nill Ge, TangYiwei, Anjaneya "Reddy" Chagam, David Hendricks, Naresh, Shuo Liu, Shuming Chu (Shuming), Srinidhi N Kaushik, Juan Sanchez, Shelly Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73622 ) Change subject: [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilitate SPR build ...................................................................... Patch Set 10: (2 comments) File restore-from-snapshot.sh: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174007): https://review.coreboot.org/c/coreboot/+/73622/comment/0c56cb5e_66987c08 PS10, Line 3: # cd coreboot project, for exmaple coreboot-spr-sp rebase/squash branch, 'exmaple' may be misspelled - perhaps 'example'? File snapshot.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174007): https://review.coreboot.org/c/coreboot/+/73622/comment/634d4594_8bacd1d8 PS10, Line 18: [upstream_20230412 e2e6942e05] arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Mon Jan 17 20:16:21 2022 +0100 2 files changed, 17 insertions(+) 'Accomodate' may be misspelled - perhaps 'Accommodate'? -- To view, visit https://review.coreboot.org/c/coreboot/+/73622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61afff221f33c8b16c2d3b6323e8c8cd5895e52 Gerrit-Change-Number: 73622 Gerrit-PatchSet: 10 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Juan Sanchez Gerrit-Reviewer: Naresh <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Naresh <naresh.solanki.2011(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Juan Sanchez Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 03:46:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilit...
by Shelly Chang (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Jonathan Zhang, Simon Chou, Jingle Hsu, Nill Ge, TangYiwei, Anjaneya "Reddy" Chagam, David Hendricks, Naresh, Shuo Liu, Shuming Chu (Shuming), Srinidhi N Kaushik, Juan Sanchez, Shelly Chang. Shelly Chang has uploaded a new patch set (#10) to the change originally created by Johnny Lin. ( https://review.coreboot.org/c/coreboot/+/73622 ) Change subject: [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilitate SPR build ...................................................................... [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilitate SPR build * Test date: Wed Apr 12 02:27:10 UTC 2023 * Based on upstream tip: 134566395f mb/google/myst: Add smihandler * Tested on SPR platforms: AC CRB and OCP Crater Lake, tested on CPX platform OCP Delta Lake to check there's no regression. The CB numbers in pick-upstream-spr-list.sh are changes under review, list1 are the changes that are defconfig for ArcherCity, list2 are the changes for 2S enabling changes. restore-from-snapshot.sh will restore a coreboot repo to a certain status according to snapshot.txt, usage: 1. git checkout the corresponding upstream tip, for this snapshot.txt it is 3b5d9ee516 drivers/spi/spi_flash.c: Prefer 'if' over '#if" 2. Run ./restore-from-snapshot.sh ./snapshot.txt pick-upstream-spr-list.sh will cherry-pick the latest open changes from public coreboot repo for SPR build, and generate a snapshot.txt. Please make sure you have the correct Intel binaries for your AC CRB and place them to the right location according to configs/builder/config.intel.crb.ac: CONFIG_FSP_T_FILE="site-local/archercity/Server_T.fd" CONFIG_FSP_M_FILE="site-local/archercity/Server_M.fd" CONFIG_FSP_S_FILE="site-local/archercity/Server_S.fd" CONFIG_IFD_BIN_PATH="site-local/archercity/descriptor.bin" CONFIG_ME_BIN_PATH="site-local/archercity/me.bin" CONFIG_CPU_UCODE_BINARIES="site-local/archercity/mbf806f8.mcb" The current merged FSP header files and Hob structures in CB:71948 is based on 2022 WW43 git tag EGLSTRM.0.RPB.0090.D.03, you need to make sure your FSP is compatible with it otherwise you need to adjust the FSP headers and Hob structures accordingly. Below is LinuxBoot payload, you need to build it by yourself CONFIG_PAYLOAD_FILE="site-local/archercity/linuxboot_bzImage" The x86_64 qemu example can build a working LinuxBoot payload: git clone https://github.com/linuxboot/osf-builder cd examples/qemu; make kernel Issues: OS free shows much smaller memory size comparing to the production private spr repo. Change-Id: Id61afff221f33c8b16c2d3b6323e8c8cd5895e52 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- A pick-upstream-spr-list.sh A restore-from-snapshot.sh A snapshot.txt 3 files changed, 234 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/73622/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/73622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61afff221f33c8b16c2d3b6323e8c8cd5895e52 Gerrit-Change-Number: 73622 Gerrit-PatchSet: 10 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Juan Sanchez Gerrit-Reviewer: Naresh <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Naresh <naresh.solanki.2011(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Juan Sanchez Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: [WIP] soc/intel/baytrail,braswell,common: Handle IOAPIC IRQ overrides
by Kyösti Mälkki (Code Review) 12 Apr '23

12 Apr '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69530 ) Change subject: [WIP] soc/intel/baytrail,braswell,common: Handle IOAPIC IRQ overrides ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/69530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I919433dfef907dd9008b79eaec5f53e824dcd292 Gerrit-Change-Number: 69530 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: [WIP] ACPI MADT: Iterate IOAPIC entries
by Kyösti Mälkki (Code Review) 12 Apr '23

12 Apr '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69531 ) Change subject: [WIP] ACPI MADT: Iterate IOAPIC entries ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/69531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3cf1841ae17c1fe91937eb85a98865892b992b7 Gerrit-Change-Number: 69531 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: [WIP] ACPI MADT: Drop acpi_fill_madt() under platforms
by Kyösti Mälkki (Code Review) 12 Apr '23

12 Apr '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69532 ) Change subject: [WIP] ACPI MADT: Drop acpi_fill_madt() under platforms ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/69532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0614d78da2ba6c1eba48e1877b50b45a5f3cb88 Gerrit-Change-Number: 69532 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla
by Derek Huang (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Shon Wang. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74264 ) Change subject: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I831b199055c931e7a4a393eeb9e75e83c8ae3c3a Gerrit-Change-Number: 74264 Gerrit-PatchSet: 13 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 03:29:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Johnny Lin (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Arthur Heymans, Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Patrick Rudolph, Felix Held, Tim Chu. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164 ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > if this requirement gets at least documented in the specification, i'd be ok with fixing it this way […] Sapphaire Rapids FSP is not published yet, but the spec version is v2.3. -- To view, visit https://review.coreboot.org/c/coreboot/+/61164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 03:28:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla
by Shon Wang (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Derek Huang. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74264 ) Change subject: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla ...................................................................... Patch Set 13: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74264/comment/e78e10ca_c62596d2 PS10, Line 9: an additional nissa reference board > a variant of yaviks Done File src/mainboard/google/brya/variants/yaviks/fw_config.c: https://review.coreboot.org/c/coreboot/+/74264/comment/14f9d9f9_798a1806 PS11, Line 62: gpio_configure_pads > why not gpio_padbased_override? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I831b199055c931e7a4a393eeb9e75e83c8ae3c3a Gerrit-Change-Number: 74264 Gerrit-PatchSet: 13 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 03:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla
by Shon Wang (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Shon Wang. Hello build bot (Jenkins), Tarun Tuli, Chen-Tsung Hsieh, Derek Huang, Shou-Chieh Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74264 to look at the new patch set (#12). Change subject: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla ...................................................................... mb/google/nissa/var/yaviks: Update GPIOs to support yavilla Yavilla is a variant of yaviks which is almost identical to yaviks, so is reusing the yaviks coreboot variant. so update the GPIO tables to handle these based on fw_config. BUG=b:277148122 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot Change-Id: I831b199055c931e7a4a393eeb9e75e83c8ae3c3a Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/yaviks/fw_config.c M src/mainboard/google/brya/variants/yaviks/gpio.c 2 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/74264/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/74264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I831b199055c931e7a4a393eeb9e75e83c8ae3c3a Gerrit-Change-Number: 74264 Gerrit-PatchSet: 12 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023