Attention is currently required from: Robert Chen, Shou-Chieh Hsu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 )
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74307/comment/0d3e0e89_9af92bf0
PS5, Line 7: for Kracko
Redundant as also present in prefix.
https://review.coreboot.org/c/coreboot/+/74307/comment/8ad6365e_1a3a9b65
PS5, Line 9: Add G2touch touchscreen support for kracko OOC panel.
What is OOC?
https://review.coreboot.org/c/coreboot/+/74307/comment/abbf56cb_cdf227cc
PS5, Line 10:
Please document the datasheet name and revision.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 08:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Reka Norman, Shou-Chieh Hsu.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74335 )
Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74335/comment/e7fdcf9f_b2e54262
PS4, Line 16:
> From above: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919
Gerrit-Change-Number: 74335
Gerrit-PatchSet: 7
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 08:00:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Dtrain Hsu, Subrata Banik, Reka Norman, Shou-Chieh Hsu.
Hello John Su, build bot (Jenkins), Tarun Tuli, Ian Feng, Subrata Banik, Derek Huang, Reka Norman, Eric Lai, Shou-Chieh Hsu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74335
to look at the new patch set (#7).
Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
......................................................................
mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
This patch configures external V1p05/Vnn/VnnSx rails for Uldren
to follow best practices for power savings – untested though.
* Enable the external V1p05, Vnn, VnnSx rails in S0i1, S0i2, S0i3, S3,
S4, S5 , S0 states.
* Set the supported voltage states.
* Set the voltage for v1p05 and vnn.
* Set the ICC max for v1p05 and vnn.
BUG=b:272829190
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot
Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919
Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/uldren/overridetree.cb
1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74335/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/74335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919
Gerrit-Change-Number: 74335
Gerrit-PatchSet: 7
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Robert Chen, Shou-Chieh Hsu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 )
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
W/O that will slightly affect the boot time but fine. Only increase 50ms.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:57:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Dtrain Hsu, Subrata Banik, Reka Norman, Shou-Chieh Hsu.
Hello John Su, build bot (Jenkins), Tarun Tuli, Ian Feng, Subrata Banik, Derek Huang, Reka Norman, Eric Lai, Shou-Chieh Hsu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74335
to look at the new patch set (#6).
Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
......................................................................
mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
This patch configures external V1p05/Vnn/VnnSx rails for Uldren
to to follow best practices for power savings – untested though.
* Enable the external V1p05, Vnn, VnnSx rails in S0i1, S0i2, S0i3, S3,
S4, S5 , S0 states.
* Set the supported voltage states.
* Set the voltage for v1p05 and vnn.
* Set the ICC max for v1p05 and vnn.
BUG=b:272829190
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot
Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919
Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/uldren/overridetree.cb
1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74335/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/74335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919
Gerrit-Change-Number: 74335
Gerrit-PatchSet: 6
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Robert Chen, Shou-Chieh Hsu.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 )
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:56:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Shou-Chieh Hsu.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 )
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74307/comment/54535198_13c26fc9
PS3, Line 13: BRANCH=firmware-dedede-13606.B
> btw, branch should above TEST.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Shou-Chieh Hsu.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 )
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74307/comment/3ebfa9ba_e4576448
PS3, Line 11: BUG=b:
> trackerID?
Done
Patchset:
PS3:
> Do you want add SSFC for FW config?
No, new panel with slave i2c address 0x40 different from old one. don't need SSFC.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Robert Chen, Shou-Chieh Hsu.
Hello build bot (Jenkins), Eric Lai, Shou-Chieh Hsu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74307
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
Add G2touch touchscreen support for kracko OOC panel.
BUG=b:277852921
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot & test on DUT
Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/kracko/overridetree.cb
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/74307/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Robert Chen, Shou-Chieh Hsu.
Hello build bot (Jenkins), Eric Lai, Shou-Chieh Hsu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74307
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
Add G2touch touchscreen support for kracko OOC panel.
BUG=b:277852921
TEST=emerge-dedede coreboot & test on DUT
BRANCH=firmware-dedede-13606.B
Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/kracko/overridetree.cb
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/74307/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset