coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/amd/mayan: Enable MXM PCIe slot
by Anand Vaikar (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Jason Glenesk, ritul guru, Fred Reitberger, Felix Held. Hello Jason Glenesk, ritul guru, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74308 to look at the new patch set (#3). Change subject: mb/amd/mayan: Enable MXM PCIe slot ...................................................................... mb/amd/mayan: Enable MXM PCIe slot Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- M src/mainboard/amd/mayan/devicetree_phoenix.cb M src/mainboard/amd/mayan/ec.c M src/mainboard/amd/mayan/port_descriptors.c 3 files changed, 41 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74308/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b Gerrit-Change-Number: 74308 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/amd/mayan: Enable MXM PCIe slot
by Anand Vaikar (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Jason Glenesk, ritul guru, Fred Reitberger, Felix Held. Hello Jason Glenesk, ritul guru, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74308 to look at the new patch set (#2). Change subject: mb/amd/mayan: Enable MXM PCIe slot ...................................................................... mb/amd/mayan: Enable MXM PCIe slot Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- M src/mainboard/amd/mayan/devicetree_phoenix.cb M src/mainboard/amd/mayan/ec.c M src/mainboard/amd/mayan/port_descriptors.c 3 files changed, 40 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74308/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b Gerrit-Change-Number: 74308 Gerrit-PatchSet: 2 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
by Dtrain Hsu (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Reka Norman, Shou-Chieh Hsu. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74335 ) Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74335/comment/a92a2304_eac8087f PS4, Line 16: > This is the first version. We have gotten board. This is the first version. We have not gotten board yet. -- To view, visit https://review.coreboot.org/c/coreboot/+/74335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919 Gerrit-Change-Number: 74335 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 06:48:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/mayan: Enable MXM PCIe slot
by Anand Vaikar (Code Review) 12 Apr '23

12 Apr '23

Anand Vaikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74308 ) Change subject: mb/amd/mayan: Enable MXM PCIe slot ...................................................................... mb/amd/mayan: Enable MXM PCIe slot Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- M src/mainboard/amd/mayan/devicetree_phoenix.cb M src/mainboard/amd/mayan/ec.c M src/mainboard/amd/mayan/port_descriptors.c 3 files changed, 40 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74308/1 diff --git a/src/mainboard/amd/mayan/devicetree_phoenix.cb b/src/mainboard/amd/mayan/devicetree_phoenix.cb index 9d1a4b3..1595987 100644 --- a/src/mainboard/amd/mayan/devicetree_phoenix.cb +++ b/src/mainboard/amd/mayan/devicetree_phoenix.cb @@ -158,6 +158,7 @@ device domain 0 on device ref iommu on end + device ref gpp_bridge_1_1 on end # MXM device ref gpp_bridge_2_1 on end # GBE device ref gpp_bridge_2_2 on end # WIFI device ref gpp_bridge_2_3 on end # NVMe SSD diff --git a/src/mainboard/amd/mayan/ec.c b/src/mainboard/amd/mayan/ec.c index 1b1d09b..e84cb8f 100644 --- a/src/mainboard/amd/mayan/ec.c +++ b/src/mainboard/amd/mayan/ec.c @@ -8,6 +8,12 @@ #define MAYAN_EC_CMD 0x666 #define MAYAN_EC_DATA 0x662 +#define EC_GPIO_1_ADDR 0xA1 +#define EC_GPIO_EVAL_PWREN BIT(1) + +#define EC_GPIO_2_ADDR 0xA2 +#define EC_GPIO_EVAL_SLOT_PWR BIT(5) + #define EC_GPIO_3_ADDR 0xA3 #define EC_GPIO_LOM_RESET_AUX BIT(1) @@ -35,8 +41,18 @@ { uint8_t tmp; + /*Enable MXM slot: set EC_GPIO_EVAL_PWREN, EC_GPIO_EVAL_SLOT_PWR + and EC_GPIO_EVAL_RST_AUX */ + tmp = ec_read(EC_GPIO_1_ADDR); + tmp |= EC_GPIO_EVAL_PWREN; + ec_write(EC_GPIO_1_ADDR, tmp); + + tmp = ec_read(EC_GPIO_2_ADDR); + tmp |= EC_GPIO_EVAL_SLOT_PWR; + ec_write(EC_GPIO_2_ADDR, tmp); + tmp = ec_read(EC_GPIO_3_ADDR); - tmp |= EC_GPIO_LOM_RESET_AUX; + tmp |= EC_GPIO_LOM_RESET_AUX | EC_GPIO_EVAL_RST_AUX; ec_write(EC_GPIO_3_ADDR, tmp); tmp = ec_read(EC_GPIO_7_ADDR); diff --git a/src/mainboard/amd/mayan/port_descriptors.c b/src/mainboard/amd/mayan/port_descriptors.c index f52abcd..67cc538 100644 --- a/src/mainboard/amd/mayan/port_descriptors.c +++ b/src/mainboard/amd/mayan/port_descriptors.c @@ -10,17 +10,24 @@ static const fsp_dxio_descriptor mayan_dxio_descriptors[] = { { + // MXM .engine_type = PCIE_ENGINE, .port_present = true, .start_logical_lane = 0, - .end_logical_lane = 0, - .device_number = 2, + .end_logical_lane = 3, + .device_number = 1, .function_number = 1, - .link_speed_capability = GEN3, + .link_speed_capability = GEN_MAX, .turn_off_unused_lanes = true, .link_aspm = 2, - .link_hotplug = 3, - .clk_req = CLK_REQ3, + .link_aspm_L1_1 = 1, + .link_aspm_L1_2 = 1, + .link_hotplug = 0, + .gpio_group_id = 4, + .clk_pm_support = 1, + .clk_req = CLK_REQ0, + .eq_preset = 3, + .port_params = {PP_PSPP_AC, 0x144, PP_PSPP_DC, 0x133} }, { .engine_type = PCIE_ENGINE, -- To view, visit https://review.coreboot.org/c/coreboot/+/74308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75d7ac488bb005751e6f674ab9a2fd99baad571b Gerrit-Change-Number: 74308 Gerrit-PatchSet: 1 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilit...
by Johnny Lin (Code Review) 12 Apr '23

12 Apr '23

Johnny Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/73622 ) Change subject: [DEBUG ONLY for weekly check] Add scripts and snapshot.txt to facilitate SPR build ...................................................................... Abandoned The SPR upstreaming process is looking good and important changes are mostly merged now, abandon this debug change, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/73622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61afff221f33c8b16c2d3b6323e8c8cd5895e52 Gerrit-Change-Number: 73622 Gerrit-PatchSet: 11 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Juan Sanchez Gerrit-Reviewer: Naresh <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Patrick Rudolph (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Arthur Heymans, Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Patrick Rudolph, Felix Held, Tim Chu. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164 ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Sapphaire Rapids FSP is not published yet, but the spec version is v2.3. This issue affecting SPR was reported to Intel on 23.3.2022 -- To view, visit https://review.coreboot.org/c/coreboot/+/61164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 06:13:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD CnviWifiCore
by Subrata Banik (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Paul Menzel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74306 ) Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/meteorlake/chipset.cb: https://review.coreboot.org/c/coreboot/+/74306/comment/2fd3236f_b922d632 PS2, Line 20: drop one extra line -- To view, visit https://review.coreboot.org/c/coreboot/+/74306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b4662c2a064f7c9074797c8a2541dcf1dd686fe Gerrit-Change-Number: 74306 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 06:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD CnviWifiCore
by Eric Lai (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Paul Menzel. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74306 ) Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/meteorlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/74306/comment/b8cf32a1_646f203e PS2, Line 565: s_cfg->CnviWifiCore = config->cnvi_wifi_core; Do we need assert? Is CnviMode and CnviWifiCore have dependency? -- To view, visit https://review.coreboot.org/c/coreboot/+/74306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b4662c2a064f7c9074797c8a2541dcf1dd686fe Gerrit-Change-Number: 74306 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 06:05:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
by Dtrain Hsu (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Reka Norman, Shou-Chieh Hsu. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74335 ) Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74335/comment/a66f4248_07a0c3cc PS4, Line 10: to achieve the better power savings. > Drop *the*. Done https://review.coreboot.org/c/coreboot/+/74335/comment/96e763f5_bd1e2b9e PS4, Line 11: * Enable the external V1p05, Vnn, VnnSx rails in S0i1, S0i2, S0i3, S3, > Please add a blank line above. Done https://review.coreboot.org/c/coreboot/+/74335/comment/618a8ee1_0d00be25 PS4, Line 16: > Please add the exact numbers of power savings to the commit message. This is the first version. We have gotten board. -- To view, visit https://review.coreboot.org/c/coreboot/+/74335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919 Gerrit-Change-Number: 74335 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 05:57:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
by Dtrain Hsu (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Dtrain Hsu, Subrata Banik, Reka Norman, Shou-Chieh Hsu. Hello John Su, build bot (Jenkins), Tarun Tuli, Ian Feng, Subrata Banik, Derek Huang, Reka Norman, Eric Lai, Shou-Chieh Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74335 to look at the new patch set (#5). Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx ...................................................................... mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx This patch configures external V1p05/Vnn/VnnSx rails for Uldren to achieve better power savings. * Enable the external V1p05, Vnn, VnnSx rails in S0i1, S0i2, S0i3, S3, S4, S5 , S0 states. * Set the supported voltage states. * Set the voltage for v1p05 and vnn. * Set the ICC max for v1p05 and vnn. BUG=b:272829190 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919 Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldren/overridetree.cb 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74335/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919 Gerrit-Change-Number: 74335 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023