coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
by Eric Lai (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Robert Chen, Shou-Chieh Hsu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 ) Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74307/comment/5b42af9f_2ab5c1a1 PS3, Line 13: BRANCH=firmware-dedede-13606.B btw, branch should above TEST. -- To view, visit https://review.coreboot.org/c/coreboot/+/74307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd Gerrit-Change-Number: 74307 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/: Implement an API to get ISH version
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 ) Change subject: soc/intel/: Implement an API to get ISH version ...................................................................... Patch Set 9: (1 comment) File src/soc/intel/common/block/include/intelblocks/cse.h: https://review.coreboot.org/c/coreboot/+/74209/comment/132e8f73_2d51823f PS5, Line 547: if the latest ISH version is not updated in the CBMEM table Ah, you meant “not up to date”. Maybe: > … if the ISH version in CBMEM table outdated -- To view, visit https://review.coreboot.org/c/coreboot/+/74209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 Gerrit-Change-Number: 74209 Gerrit-PatchSet: 9 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:49:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
by Eric Lai (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Robert Chen, Shou-Chieh Hsu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 ) Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Do you want add SSFC for FW config? -- To view, visit https://review.coreboot.org/c/coreboot/+/74307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd Gerrit-Change-Number: 74307 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx
by Paul Menzel (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Dtrain Hsu, Subrata Banik, Reka Norman, Shou-Chieh Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74335 ) Change subject: mb/google/nissa/uldren: Configure the external V1p05/Vnn/VnnSx ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74335/comment/753b4e3f_2254f725 PS4, Line 16: From above: > … to achieve better power savings It’d be great if you could clarify then. Maybe: > … to follow best practices for power savings – untested though. -- To view, visit https://review.coreboot.org/c/coreboot/+/74335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff8e7db33bfbe4048327825406462262e8d2919 Gerrit-Change-Number: 74335 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
by Kevin Chiu (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Edward Dai, Robert Chen, Shou-Chieh Hsu. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 ) Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74307/comment/750d9582_88b74d11 PS3, Line 11: BUG=b: trackerID? -- To view, visit https://review.coreboot.org/c/coreboot/+/74307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd Gerrit-Change-Number: 74307 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Edward Dai <edwarddai(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Edward Dai <edwarddai(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
by Robert Chen (Code Review) 12 Apr '23

12 Apr '23

Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 ) Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd Gerrit-Change-Number: 74307 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:31:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT"
by Michael Niewöhner (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Felix Singer, Sean Rhodes, Tarun Tuli, Subrata Banik, Christian Walter, Maximilian Brune, Angel Pons, Martin Roth, Lean Sheng Tan. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73902 ) Change subject: Revert "soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT" ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Your revert would be going back to: […] Well, the "end result" should be not having both Kconfig and devicetree for the same thing for both D3 and s0ix, as already mentioned on CB:72800, CB:73903. This should have been properly designed in the first place tbh, either by only using Kconfig (dropping dt) or by making use of the acpi gen. -- To view, visit https://review.coreboot.org/c/coreboot/+/73902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56bab4d85d04e90cacfe77db59d0cde6a8a75949 Gerrit-Change-Number: 73902 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/mtl: Add meteorlake B0 stepping CPU ID
by Subrata Banik (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Musse Abdullahi. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74300 ) Change subject: soc/intel/mtl: Add meteorlake B0 stepping CPU ID ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74300/comment/f3f45213_23c9cd75 PS1, Line 7: soc/intel/mtl: soc/intel/meteorlake: https://review.coreboot.org/c/coreboot/+/74300/comment/a324db31_7b32c20f PS1, Line 7: meteorlake drop this https://review.coreboot.org/c/coreboot/+/74300/comment/6adab657_d386138a PS1, Line 8: > If you have the source handy, please document it in the commit message. please mention the doc number and a test line -- To view, visit https://review.coreboot.org/c/coreboot/+/74300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b939ccc8b05e3648c55f8f2a0a391cb08f04184 Gerrit-Change-Number: 74300 Gerrit-PatchSet: 1 Gerrit-Owner: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Update Flash Layout to fit WP_RO within 4MB
by Subrata Banik (Code Review) 12 Apr '23

12 Apr '23

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74229 ) Change subject: mb/google/rex: Update Flash Layout to fit WP_RO within 4MB ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/rex/chromeos.fmd: https://review.coreboot.org/c/coreboot/+/74229/comment/c9fb835e_c1830d94 PS1, Line 7: 7M > I am sorry, I miscalculated 7 * 1024 and thought it’s 7092K instead of 7168K. […] no problem, appreciate ur time here -- To view, visit https://review.coreboot.org/c/coreboot/+/74229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccf83b7bb66d0d5503e0ff9e9a819051296c6724 Gerrit-Change-Number: 74229 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add VPU into the DMAR SATC table
by Subrata Banik (Code Review) 12 Apr '23

12 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, John Zhao. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74221 ) Change subject: soc/intel/meteorlake: Add VPU into the DMAR SATC table ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/acpi.c: https://review.coreboot.org/c/coreboot/+/74221/comment/1f21af72_a2d2152d PS1, Line 273: acpi_create_dmar_ds_pci > You are not checking if the device is enabled or not. […] valid point. -- To view, visit https://review.coreboot.org/c/coreboot/+/74221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d4af7c9844e33483a1e616eaee061a90d0be6fc Gerrit-Change-Number: 74221 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 07:20:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023