coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/cannonlake: Allow SoC to choose CAR mode (eNEM/NEM)
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74377 ) Change subject: soc/intel/cannonlake: Allow SoC to choose CAR mode (eNEM/NEM) ...................................................................... soc/intel/cannonlake: Allow SoC to choose CAR mode (eNEM/NEM) This patch avoids cannonlake base config to select eNEM for CAR by default. Rather allow other SoC config to choose the applicable CAR mode between eNEM and NEM. CML and WHL selects eNEM whereas CFL decided to use NEM for CAR setup. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ibeaa4d53279ff9cbcd0b2ac5f2ad71925872355b --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/74377/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index c4855da..33025eb 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -8,6 +8,7 @@ select HAVE_EXP_X86_64_SUPPORT select HAVE_INTEL_FSP_REPO select HECI_DISABLE_USING_SMM + select INTEL_CAR_NEM select SOC_INTEL_CONFIGURE_DDI_A_4_LANES config SOC_INTEL_WHISKEYLAKE @@ -16,6 +17,7 @@ select FSP_USES_CB_STACK select HAVE_INTEL_FSP_REPO select HECI_DISABLE_USING_SMM + select INTEL_CAR_NEM_ENHANCED select SOC_INTEL_CONFIGURE_DDI_A_4_LANES config SOC_INTEL_COMETLAKE @@ -23,6 +25,7 @@ select SOC_INTEL_CANNONLAKE_BASE select FSP_USES_CB_STACK select HAVE_INTEL_FSP_REPO + select INTEL_CAR_NEM_ENHANCED select PMC_IPC_ACPI_INTERFACE if DISABLE_HECI1_AT_PRE_BOOT select SOC_INTEL_CONFIGURE_DDI_A_4_LANES select SOC_INTEL_COMMON_BLOCK_HECI1_DISABLE_USING_PMC_IPC @@ -71,7 +74,6 @@ select HAVE_HYPERTHREADING select HAVE_SMI_HANDLER select IDT_IN_EVERY_STAGE - select INTEL_CAR_NEM_ENHANCED select INTEL_DESCRIPTOR_MODE_CAPABLE select INTEL_GMA_ACPI select INTEL_GMA_ADD_VBT if RUN_FSP_GOP -- To view, visit https://review.coreboot.org/c/coreboot/+/74377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeaa4d53279ff9cbcd0b2ac5f2ad71925872355b Gerrit-Change-Number: 74377 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/purism/librem_cnl: Provide CBFS setting for Mini auto power on
by Jonathon Hall (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74363 ) Change subject: mb/purism/librem_cnl: Provide CBFS setting for Mini auto power on ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > I only found the general `Documentation/lib/option.md`. Otherwise, `cmos.layout` and `cmos. […] Looks like if I enable HAVE_OPTION_TABLE, USE_OPTION_TABLE, and STATIC_OPTION_TABLE it is quite close to what I want - then I could inject a cmos.default into CBFS and it is always applied on boot, otherwise it doesn't touch CMOS. Which would be great to avoid inventing some board-specific thing! However, it currently always writes to BRAM bank 0 starting from offset 14. The Mini's EC firmware has this setting in bank 1 at offset 41 and I don't currently know what the other offsets do, if anything. Do you think it'd be reasonable to add Kconfigs to specify the BRAM bank BAR (so you could point it to bank 1, or nondefault address for bank 0 if some device required it) and the start offset? -- To view, visit https://review.coreboot.org/c/coreboot/+/74363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0a4ea02d71f6f99e344484726a629e0552e4941 Gerrit-Change-Number: 74363 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/acpi: Add support for GPS_REQUESTDXSTATE
by Felix Held (Code Review) 13 Apr '23

13 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73890 ) Change subject: mb/google/brya/acpi: Add support for GPS_REQUESTDXSTATE ...................................................................... mb/google/brya/acpi: Add support for GPS_REQUESTDXSTATE Implement the GPS_REQUESTDXSTATE function which forces the current D notifier state to re-report. TEST=verified that notifications are forced out when invoked using acpiexec BUG=b:271938907 Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: I6dab9b793fe1d0b1c875eddbe6ae324d2894efe6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73890 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/acpi/gps.asl 1 file changed, 30 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/acpi/gps.asl b/src/mainboard/google/brya/acpi/gps.asl index 36bccc1..f201037 100644 --- a/src/mainboard/google/brya/acpi/gps.asl +++ b/src/mainboard/google/brya/acpi/gps.asl @@ -4,11 +4,14 @@ #define GPS_FUNC_GETCALLBACKS 0x13 #define GPS_FUNC_PSHARESTATUS 0x20 #define GPS_FUNC_PSHAREPARAMS 0x2a +#define GPS_FUNC_REQUESTDXSTATE 0x12 #define QUERY_GET_STATUS 0 #define QUERY_GET_SUPPORTED_FIELDS 1 #define QUERY_GET_CURRENT_LIMITS 2 +#define EC_D_NOTIFY_MASK 0x7 + /* GPS return Package */ Name (GPSP, Buffer (0x28) {0x0}) CreateDWordField (GPSP, 0, RETN) @@ -31,7 +34,8 @@ (1 << GPS_FUNC_SUPPORT) | (1 << GPS_FUNC_GETCALLBACKS) | (1 << GPS_FUNC_PSHARESTATUS) | - (1 << GPS_FUNC_PSHAREPARAMS))) + (1 << GPS_FUNC_PSHAREPARAMS) | + (1 << GPS_FUNC_REQUESTDXSTATE))) } Case (GPS_FUNC_GETCALLBACKS) { @@ -88,6 +92,12 @@ } } } + Case (GPS_FUNC_REQUESTDXSTATE) + { + Local0 = ToInteger(\_SB.PCI0.LPCB.EC0.GPUD) & EC_D_NOTIFY_MASK + \_SB.PCI0.PEG0.PEGP.DNOT (Local0, 1) + Return (NV_ERROR_SUCCESS) + } } Return (NV_ERROR_UNSUPPORTED) -- To view, visit https://review.coreboot.org/c/coreboot/+/73890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dab9b793fe1d0b1c875eddbe6ae324d2894efe6 Gerrit-Change-Number: 73890 Gerrit-PatchSet: 15 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: util/cbfstool: Correct the definition of struct e820entry
by Arthur Heymans (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Bill XIE. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74270 ) Change subject: util/cbfstool: Correct the definition of struct e820entry ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09955c90e4eec337adca383e628a8821075381d6 Gerrit-Change-Number: 74270 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/acpi: Add support for forcing notifications in DNOT func
by Felix Held (Code Review) 13 Apr '23

13 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73900 ) Change subject: mb/google/brya/acpi: Add support for forcing notifications in DNOT func ...................................................................... mb/google/brya/acpi: Add support for forcing notifications in DNOT func Currently the DNOT function first checks to see if the current DNOT value has already been reported. Add support to allow forcing regardless if it had been sent already. TEST=confirmed that when enabled, all events notify. When disabled, only events on value change are notified. BUG=b:271938907 Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: I7a93cca6a8f922574dd46b46572b230755db9aa7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73900 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/acpi/gpu_ec.asl M src/mainboard/google/brya/acpi/gpu_top.asl 2 files changed, 27 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/acpi/gpu_ec.asl b/src/mainboard/google/brya/acpi/gpu_ec.asl index 998d9c0..59875ad 100644 --- a/src/mainboard/google/brya/acpi/gpu_ec.asl +++ b/src/mainboard/google/brya/acpi/gpu_ec.asl @@ -8,6 +8,6 @@ Method (_Q0C, 0, Serialized) { Local0 = ToInteger(GPUD) & EC_D_NOTIFY_MASK - \_SB.PCI0.PEG0.PEGP.DNOT (Local0) + \_SB.PCI0.PEG0.PEGP.DNOT (Local0, 0) } } diff --git a/src/mainboard/google/brya/acpi/gpu_top.asl b/src/mainboard/google/brya/acpi/gpu_top.asl index e23e3cf..492502c 100644 --- a/src/mainboard/google/brya/acpi/gpu_top.asl +++ b/src/mainboard/google/brya/acpi/gpu_top.asl @@ -40,12 +40,15 @@ } } - /* Current D Notify Value, defaults to D1 */ + /* Current D Notify Value, defaults to D1 + * Arg0 == Shared value + * Arg1 == force notification if no change (0 or 1) + */ Name (CDNV, D1_EC) - Method (DNOT, 1, Serialized) + Method (DNOT, 2, Serialized) { Printf ("EC: GPU D-Notify, %o", Arg0) - If (Arg0 != CDNV) + If ((Arg0 != CDNV) || (Arg1 == 1)) { CDNV = Arg0 Local0 = CNVD (Arg0) -- To view, visit https://review.coreboot.org/c/coreboot/+/73900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a93cca6a8f922574dd46b46572b230755db9aa7 Gerrit-Change-Number: 73900 Gerrit-PatchSet: 6 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: payloads/edk2: Remove ABOVE_4G_MEMORY option
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Sean Rhodes, Martin L Roth, Benjamin Doron, Stefan Reinauer, Paul Menzel. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74336 ) Change subject: payloads/edk2: Remove ABOVE_4G_MEMORY option ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d5ee79ef3f7ecfcd1463c612aad2e3d629df22a Gerrit-Change-Number: 74336 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:36:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/acpi: Pass GPS_FUNC_SUPPORT as 8 byte buffer
by Felix Held (Code Review) 13 Apr '23

13 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73899 ) Change subject: mb/google/brya/acpi: Pass GPS_FUNC_SUPPORT as 8 byte buffer ...................................................................... mb/google/brya/acpi: Pass GPS_FUNC_SUPPORT as 8 byte buffer Currently the value was being truncated to 4 bytes. Change so that the full 8 byte value is passed. TEST=verified function returns expected value using acpiexec BUG=b:271938907 Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: Icfc775de680e328a2b240595223d7098fee3dc3b Reviewed-on: https://review.coreboot.org/c/coreboot/+/73899 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/acpi/gps.asl 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/acpi/gps.asl b/src/mainboard/google/brya/acpi/gps.asl index 2e07a67..36bccc1 100644 --- a/src/mainboard/google/brya/acpi/gps.asl +++ b/src/mainboard/google/brya/acpi/gps.asl @@ -27,7 +27,7 @@ { Case (GPS_FUNC_SUPPORT) { - Return (ITOB( + Return (LTOB( (1 << GPS_FUNC_SUPPORT) | (1 << GPS_FUNC_GETCALLBACKS) | (1 << GPS_FUNC_PSHARESTATUS) | -- To view, visit https://review.coreboot.org/c/coreboot/+/73899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icfc775de680e328a2b240595223d7098fee3dc3b Gerrit-Change-Number: 73899 Gerrit-PatchSet: 9 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: payloads/edk2: Remove ABOVE_4G_MEMORY option
by Sean Rhodes (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Martin L Roth, Benjamin Doron, Stefan Reinauer, Paul Menzel, Lean Sheng Tan. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74336 ) Change subject: payloads/edk2: Remove ABOVE_4G_MEMORY option ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74336/comment/f935e449_9f415094 PS1, Line 9: as since > One of the two? Or the comma before *since*? Done https://review.coreboot.org/c/coreboot/+/74336/comment/807cfe8b_c1d8161c PS1, Line 9: commit > coreboot commit? Done https://review.coreboot.org/c/coreboot/+/74336/comment/d036dc0e_a653fd4d PS1, Line 9: Remove the ABOVE_4G_MEMORY option as since, commit : 59ca9605c39a45740de1fb64ea5b8dbd02f4724e, it no : longer exists. > Please make use of 72 characters per line. Done Patchset: PS2: I think all addressed.. -- To view, visit https://review.coreboot.org/c/coreboot/+/74336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d5ee79ef3f7ecfcd1463c612aad2e3d629df22a Gerrit-Change-Number: 74336 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:35:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/acpi: LTOB - Add support for a 8 byte integer to buffer
by Felix Held (Code Review) 13 Apr '23

13 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73898 ) Change subject: mb/google/brya/acpi: LTOB - Add support for a 8 byte integer to buffer ...................................................................... mb/google/brya/acpi: LTOB - Add support for a 8 byte integer to buffer This function adds support to convert a integer into a 8 byte buffer TEST=verified returned buffer is as expected using acpiexec BUG=b:271938907 Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: I89eb50f1452657c26b97eb5609ed956fa8ee8117 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73898 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/acpi/utility.asl 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/acpi/utility.asl b/src/mainboard/google/brya/acpi/utility.asl index 9cdfb49..49f3dca 100644 --- a/src/mainboard/google/brya/acpi/utility.asl +++ b/src/mainboard/google/brya/acpi/utility.asl @@ -37,3 +37,18 @@ Local0[3] = (Arg0 >> 24) & 0xFF Return (Local0) } + +/* Convert from 64-bit integer to 8-byte buffer (little-endian) */ +Method (LTOB, 1) +{ + Local0 = Buffer(8) { 0, 0, 0, 0, 0, 0, 0, 0 } + Local0[0] = Arg0 & 0xFF + Local0[1] = (Arg0 >> 8) & 0xFF + Local0[2] = (Arg0 >> 16) & 0xFF + Local0[3] = (Arg0 >> 24) & 0xFF + Local0[4] = (Arg0 >> 32) & 0xFF + Local0[5] = (Arg0 >> 40) & 0xFF + Local0[6] = (Arg0 >> 48) & 0xFF + Local0[7] = (Arg0 >> 56) & 0xFF + Return (Local0) +} -- To view, visit https://review.coreboot.org/c/coreboot/+/73898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89eb50f1452657c26b97eb5609ed956fa8ee8117 Gerrit-Change-Number: 73898 Gerrit-PatchSet: 8 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: payloads/edk2: Remove ABOVE_4G_MEMORY option
by Sean Rhodes (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Benjamin Doron, Paul Menzel, Lean Sheng Tan. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74336 ) Change subject: payloads/edk2: Remove ABOVE_4G_MEMORY option ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/74336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d5ee79ef3f7ecfcd1463c612aad2e3d629df22a Gerrit-Change-Number: 74336 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:34:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023