coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > seems like MSR IA32_PQR_ASSOC still exists? or could be wrong? sorry, i mean on all CFL we got 0, but on most CFL cpu the MSR IA32_PQR_ASSOC still exists, by right it should return 1. -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:52:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > However when we used IOtool on the CPU this was the result: […] seems like MSR IA32_PQR_ASSOC still exists? or could be wrong? -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Per Intel Software Developer Manual 18.18. […] However when we used IOtool on the CPU this was the result: sudo ./iotools cpuid 0 0x10 3 0x00000000 0x00000000 0x00000000 0x00000000 ubuntu@ubuntu:~/iotools$ sudo ./iotools cpuid 0 0x10 2 0x00000000 0x00000000 0x00000000 0x00000000 ubuntu@ubuntu:~/iotools$ sudo ./iotools cpuid 0 0x10 0 0x00000000 0x00000000 0x00000000 0x00000000 ubuntu@ubuntu:~/iotools$ sudo ./iotools cpuid 0 0x10 1 0x00000000 0x00000000 0x00000000 0x00000000 -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:44:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Still not sure if the SmartCache is related, but the CPU works again when eNEM is disabled. Per Intel Software Developer Manual 18.18.3 (Enumeration and Detecting Support of Cache Monitoring Technology and Memory Bandwidth Monitoring), Software can query processor support of shared resource monitoring features capabilities by executing CPUIDinstruction with EAX = 07H, ECX = 0H as input. If CPUID.(EAX=07H, ECX=0):EBX.PQM[bit 12] reports 1, the processor provides the following programming interfaces for shared resource monitoring, including Cache Monitoring Technology. -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:43:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This is i3-9100E Processor* 6+2 U-0 0x906EA, we checked, it is the only CPU without Intel SmartCac […] Still not sure if the SmartCache is related, but the CPU works again when eNEM is disabled. -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:42:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Lean Sheng Tan (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > can you please check what type of CPU is this ? if this is any specific desktop sku where eNEM was n […] This is i3-9100E Processor* 6+2 U-0 0x906EA, we checked, it is the only CPU without Intel SmartCache -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:41:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Rizwan Qureshi, Arthur Heymans. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: we shoudn't blindly check NEM over eNEM -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:37:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Rizwan Qureshi, Arthur Heymans. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: can you please check what type of CPU is this ? if this is any specific desktop sku where eNEM was not enabled. this observation make sense. -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Nico Huber (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Rizwan Qureshi, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Maybe there's something else we could use to filter the working CPUs, e.g. stepping ID? -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 13 Apr 2023 12:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
by Arthur Heymans (Code Review) 13 Apr '23

13 Apr '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74376 ) Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR ...................................................................... [RFC]soc/intel/cannonlake: Use regular NEM for CAR It was found that some coffeelake CPUs like Intel i3 9100E fail to enter CAR mode because some MSR used by NEM enhanced are lacking. According to the Intel SDM CPUID.EAX=07h.ECX=0 reg EBX[12 or 15] should indicate the presence of IA32_PAR_ASSOC and CPUID.EAX=10h.ECX[1 or 2] reg ECX[2] should indicate IA32_L3_QOS_CFG and IA32_L2_QOS_CFG respectively but even on a Intel coffeelake CPU that works with the NEM_ENHANCED these CPUID bits are all 0 so there is no way of knowing whether NEM_ENHANCED will work at runtime. Instead just always use regular NEM. Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/74376/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index c4855da..1919442 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -71,7 +71,7 @@ select HAVE_HYPERTHREADING select HAVE_SMI_HANDLER select IDT_IN_EVERY_STAGE - select INTEL_CAR_NEM_ENHANCED + select INTEL_CAR_NEM select INTEL_DESCRIPTOR_MODE_CAPABLE select INTEL_GMA_ACPI select INTEL_GMA_ADD_VBT if RUN_FSP_GOP -- To view, visit https://review.coreboot.org/c/coreboot/+/74376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865 Gerrit-Change-Number: 74376 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023