coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c
by Kangheui Won (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Subrata Banik, Dinesh Gehlot, Kapil Porwal. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74382 ) Change subject: soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49ffaec467f6fb24327de3b2882e37bf31eeb7cf Gerrit-Change-Number: 74382 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 23:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add B0 stepping CPU ID
by Musse Abdullahi (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Paul Menzel, Kapil Porwal, Musse Abdullahi. Musse Abdullahi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74300 ) Change subject: soc/intel/meteorlake: Add B0 stepping CPU ID ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74300/comment/6c46633f_c7d21b09 PS1, Line 7: meteorlake > drop this Done https://review.coreboot.org/c/coreboot/+/74300/comment/7ae7dd7e_1b0b9b79 PS1, Line 7: meteorlake > drop this Done https://review.coreboot.org/c/coreboot/+/74300/comment/c83e5857_8c4c2bd2 PS1, Line 7: soc/intel/mtl: > soc/intel/meteorlake: Done https://review.coreboot.org/c/coreboot/+/74300/comment/020059b6_a7f74af7 PS1, Line 7: meteorlake > Meteor Lake Done https://review.coreboot.org/c/coreboot/+/74300/comment/42a701f1_d3933fea PS1, Line 8: > > If you have the source handy, please document it in the commit message. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b939ccc8b05e3648c55f8f2a0a391cb08f04184 Gerrit-Change-Number: 74300 Gerrit-PatchSet: 2 Gerrit-Owner: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Musse Abdullahi <musse.abdullahi(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 23:06:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Print CPU frequency info in log
by Wonkyu Kim (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74410 ) Change subject: soc/intel/meteorlake: Print CPU frequency info in log ...................................................................... soc/intel/meteorlake: Print CPU frequency info in log Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Change-Id: I8f41b4204bfda7f4318642c01527e243d887fdd2 --- M src/soc/intel/meteorlake/bootblock/report_platform.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/74410/1 diff --git a/src/soc/intel/meteorlake/bootblock/report_platform.c b/src/soc/intel/meteorlake/bootblock/report_platform.c index a5d32f3..733634c 100644 --- a/src/soc/intel/meteorlake/bootblock/report_platform.c +++ b/src/soc/intel/meteorlake/bootblock/report_platform.c @@ -106,6 +106,11 @@ printk(BIOS_DEBUG, "CPU: ID %x, %s, ucode: %08x\n", cpu_id, cpu_type, get_current_microcode_rev()); + printk(BIOS_DEBUG, "CPU: base %dMHz current:%dMHz\n", + cpu_get_base_freq(), cpu_get_current_freq()); + printk(BIOS_DEBUG, "CPU: TurboMax:%dMHz NonTurboMax:%dMHz\n", + cpu_get_max_turbo_freq(), cpu_get_max_non_turbo_freq()); + cpu_feature_flag = cpu_get_feature_flags_ecx(); aes = !!(cpu_feature_flag & CPUID_AES); txt = !!(cpu_feature_flag & CPUID_SMX); -- To view, visit https://review.coreboot.org/c/coreboot/+/74410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f41b4204bfda7f4318642c01527e243d887fdd2 Gerrit-Change-Number: 74410 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: src/arch/x86 Add CPU frequency APIs
by Wonkyu Kim (Code Review) 13 Apr '23

13 Apr '23

Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74389 ) Change subject: src/arch/x86 Add CPU frequency APIs ...................................................................... src/arch/x86 Add CPU frequency APIs Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Change-Id: I8eb4397b4a8d4058af1b5c67716ee625261c4e2a --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/74389/1 diff --git a/src/arch/x86/cpu_common.c b/src/arch/x86/cpu_common.c index e674afa..58eb57b 100644 --- a/src/arch/x86/cpu_common.c +++ b/src/arch/x86/cpu_common.c @@ -2,6 +2,8 @@ #include <cpu/cpu.h> #include <types.h> +#include <cpu/x86/msr.h> +#include <intelblocks/msr.h> #if ENV_X86_32 /* Standard macro to see if a specific flag is changeable */ @@ -212,3 +214,38 @@ return true; } + +uint32_t cpu_get_current_freq(void) +{ + msr_t msr; + uint32_t ratio, freq; + msr = rdmsr(IA32_PERF_CTL); + ratio = (msr.lo >> 8) & 0xff; + freq = ratio * CONFIG_CPU_BCLK_MHZ; + return freq; +} + +uint32_t cpu_get_max_turbo_freq(void) +{ + msr_t msr; + uint32_t ratio, freq; + msr = rdmsr(MSR_TURBO_RATIO_LIMIT); + ratio = msr.lo & 0xff; + freq = ratio * CONFIG_CPU_BCLK_MHZ; + return freq; +} + +uint32_t cpu_get_max_non_turbo_freq(void) +{ + msr_t msr; + uint32_t ratio, freq; + msr = rdmsr(MSR_PLATFORM_INFO); + ratio = (msr.lo >> 8) & 0xff; + freq = ratio * CONFIG_CPU_BCLK_MHZ; + return freq; +} + +uint32_t cpu_get_base_freq(void) +{ + return cpuid_eax(0x16); +} diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index b8c990e..3819f44 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -313,4 +313,9 @@ */ bool fill_cpu_cache_info(uint8_t level, struct cpu_cache_info *info); +uint32_t cpu_get_current_freq(void); +uint32_t cpu_get_max_turbo_freq(void); +uint32_t cpu_get_max_non_turbo_freq(void); +uint32_t cpu_get_base_freq(void); + #endif /* ARCH_CPU_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8eb4397b4a8d4058af1b5c67716ee625261c4e2a Gerrit-Change-Number: 74389 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Kangheui Won, Dinesh Gehlot, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, SRIDHAR SIRICILLA, Kangheui Won, Dinesh Gehlot, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74382 to look at the new patch set (#2). Change subject: soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c ...................................................................... soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c The patch moves API that gets the CSE FW partition information into CSE Lite specific file aka cse_lite.c because the consumer of this API is the cse_lite specific ChromeOS devices hence, it's meaningful to move the cse lite specific implementation inside cse_lite.c file. BUG=b:273661726 TEST=Able to build and boot google/marasov with this code change. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I49ffaec467f6fb24327de3b2882e37bf31eeb7cf --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_lite.c 2 files changed, 75 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/74382/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49ffaec467f6fb24327de3b2882e37bf31eeb7cf Gerrit-Change-Number: 74382 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Kangheui Won, Kapil Porwal, Dinesh Gehlot. Hello Tarun Tuli, SRIDHAR SIRICILLA, Kangheui Won, Kapil Porwal, Dinesh Gehlot, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74388 to look at the new patch set (#2). Change subject: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static ...................................................................... soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static The patch makes `cse_get_fpt_partition_info()` AP local/static as all the references to this function are in local to the cse_lite.c file. BUG=b:273661726 TEST=Able to build and boot google/marasov with this code change. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac --- M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74388/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac Gerrit-Change-Number: 74388 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74388 ) Change subject: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static ...................................................................... soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static The patch makes `cse_get_fpt_partition_info()` AP local/static as all the references to this function are in local to the cse_lite.c file. BUGb:273661726 TEST=Able to build and boot google/marasov with this code change. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac --- M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74388/1 diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 77b4559..e51f3e4 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -1228,7 +1228,8 @@ return CB_SUCCESS; } -enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp) +static enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, + struct fw_version_resp *resp) { if (vboot_recovery_mode_enabled()) { printk(BIOS_WARNING, diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index be455c1..1b7e372 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -541,13 +541,6 @@ enum cb_err cse_get_fw_feature_state(uint32_t *feature_state); /* - * The function sends a HECI command to get the partition information of the shared ID. - * The retrieved partition is stored in the memory pointed to by the resp pointer. - * The function returns 0 on success and < 0 on failure. - */ -enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp); - -/* * This function updates the user-provided memory pointer 'resp_version' with the * current ISH version. User must allocate memory for resp_version. * -- To view, visit https://review.coreboot.org/c/coreboot/+/74388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac Gerrit-Change-Number: 74388 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable CSE FPT Info config for Marasov, Nissa, Omnigul
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74387 ) Change subject: mb/google/brya: Enable CSE FPT Info config for Marasov, Nissa, Omnigul ...................................................................... mb/google/brya: Enable CSE FPT Info config for Marasov, Nissa, Omnigul Google Brya variants like Nissa family and Marasov, Omnigul selects `SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION` to store CSE FPT information. BUG=b:273661726 TEST=Able to build and boot google/marasov. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I234b5d272077de9a6f0a9ba69fa015cda7ebd56c --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/74387/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index e588524..942e8b7 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -84,6 +84,7 @@ select SOC_INTEL_ALDERLAKE_PCH_N select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW select SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE + select SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 select SOC_INTEL_COMMON_MMC_OVERRIDE diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 0cb71d4..1cebd91 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -332,6 +332,7 @@ select BOARD_GOOGLE_BASEBOARD_BRYA select SOC_INTEL_RAPTORLAKE select DRIVERS_INTEL_ISH + select SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS config BOARD_GOOGLE_OMNIGUL @@ -340,6 +341,7 @@ select SOC_INTEL_RAPTORLAKE select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS select DRIVERS_INTEL_ISH + select SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION select CHROMEOS_WIFI_SAR if CHROMEOS config BOARD_GOOGLE_CONSTITUTION -- To view, visit https://review.coreboot.org/c/coreboot/+/74387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I234b5d272077de9a6f0a9ba69fa015cda7ebd56c Gerrit-Change-Number: 74387 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Implement an API to get ISH version
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Sridhar Siricilla. Subrata Banik has uploaded a new patch set (#14) to the change originally created by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/74209 ) Change subject: soc/intel/cmn/cse: Implement an API to get ISH version ...................................................................... soc/intel/cmn/cse: Implement an API to get ISH version This patch adds an API that will fetch the current ISH version from CBMEM. BUG=b:273661726 TEST=The ISHC version, 5.4.2.7779, was retrieved on the google/nivviks. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 --- M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/74209/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/74209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 Gerrit-Change-Number: 74209 Gerrit-PatchSet: 14 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Store ISH firmware version into CBMEM
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Sridhar Siricilla. Subrata Banik has uploaded a new patch set (#17) to the change originally created by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/74208 ) Change subject: soc/intel/cmn/cse: Store ISH firmware version into CBMEM ...................................................................... soc/intel/cmn/cse: Store ISH firmware version into CBMEM The patch stores the ISH in the CBMEM table. It verifies CSE has been updated by comparing previous and current CSE versions. If it has, the patch updates the previous CSE version with the current CSE version. It then updates the CBMEM table with the current ISH version. BUG=b:273661726 TEST=The current and old CSE and ISH versions are verified on the google/nissa during cold and warm reboots. Additionally, version updates are verified by a debug patch that purposely updated the stored cse version. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 67 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74208/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 17 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023