coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically
by Subrata Banik (Code Review) 14 Apr '23

14 Apr '23

1 0

[M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically
by Subrata Banik (Code Review) 14 Apr '23

14 Apr '23

1 0

[M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically
by Subrata Banik (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Sumeet R Pawnikar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 ) Change subject: soc/intel/meteoerlake: set power limits dynamically ...................................................................... Patch Set 1: (7 comments) File src/soc/intel/meteorlake/chip.h: https://review.coreboot.org/c/coreboot/+/74380/comment/a747c71a_0c5f6627 PS1, Line 23: MTL_P_682_45W_CORE, this is not POR for us, I would avoid adding it now to avoid the maintenance https://review.coreboot.org/c/coreboot/+/74380/comment/1d7d4a6b_5ca04876 PS1, Line 26: MTL_P_682_28W_CORE, same https://review.coreboot.org/c/coreboot/+/74380/comment/e26d2f22_f008c1bc PS1, Line 33: TDP_28W = 28, same https://review.coreboot.org/c/coreboot/+/74380/comment/baa779cf_e010fa16 PS1, Line 34: TDP_45W = 45 same https://review.coreboot.org/c/coreboot/+/74380/comment/44b55502_bfa11103 PS1, Line 43: { PCI_DID_INTEL_MTL_P_ID_1, MTL_P_682_45W_CORE, TDP_45W }, same https://review.coreboot.org/c/coreboot/+/74380/comment/23838bef_b54a22de PS1, Line 45: { PCI_DID_INTEL_MTL_P_ID_3, MTL_P_482_CORE, TDP_28W }, : { PCI_DID_INTEL_MTL_P_ID_4, MTL_P_682_28W_CORE, TDP_28W }, same File src/soc/intel/meteorlake/chipset.cb: https://review.coreboot.org/c/coreboot/+/74380/comment/88ad671a_836ea2ca PS1, Line 12: register "power_limits_config[MTL_P_682_45W_CORE]" = "{ : .tdp_pl1_override = 45, : .tdp_pl2_override = 115, : .tdp_pl4 = 197, : }" i don't even know if anyone is/will be using 45W part. lets add when it requires -- To view, visit https://review.coreboot.org/c/coreboot/+/74380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20c9bc21dfa79696b07c460dbcedb4fa51838bdb Gerrit-Change-Number: 74380 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 05:31:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically
by Eric Lai (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Sumeet R Pawnikar. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 ) Change subject: soc/intel/meteoerlake: set power limits dynamically ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/systemagent.c: https://review.coreboot.org/c/coreboot/+/74380/comment/e420a379_076181b0 PS1, Line 174: for (i = 0; i < ARRAY_SIZE(cpuid_to_mtl); i++) { > I also think we can make this section more common, it's just different naming compare to ADL. […] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… We can see only struct different which can be common too. -- To view, visit https://review.coreboot.org/c/coreboot/+/74380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20c9bc21dfa79696b07c460dbcedb4fa51838bdb Gerrit-Change-Number: 74380 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 05:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Enable all DDI lanes
by Anil Kumar K (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74413 to look at the new patch set (#4). Change subject: mb/google/rex: Enable all DDI lanes ...................................................................... mb/google/rex: Enable all DDI lanes This patch enables all DDI ports on Rex board to support tunneled display and dual display on TBT dock. Branch=None Test=Boot rex and connect two displays over a TBT dock and check the display functionality Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/74413/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 Gerrit-Change-Number: 74413 Gerrit-PatchSet: 4 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: srinivas.kulkarni(a)intel.com Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Enable all DDI lanes
by Anil Kumar K (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74413 to look at the new patch set (#3). Change subject: mb/google/rex: Enable all DDI lanes ...................................................................... mb/google/rex: Enable all DDI lanes This patch enables all DDI ports on Rex board to support tunnelled display and dual display on TBT dock. Branch=None Test=Boot rex and connect two displays over a TBT dock and check the display functionality Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/74413/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 Gerrit-Change-Number: 74413 Gerrit-PatchSet: 3 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: srinivas.kulkarni(a)intel.com Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically
by Eric Lai (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Sumeet R Pawnikar. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 ) Change subject: soc/intel/meteoerlake: set power limits dynamically ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/systemagent.c: https://review.coreboot.org/c/coreboot/+/74380/comment/97443bfe_e2310a20 PS1, Line 174: for (i = 0; i < ARRAY_SIZE(cpuid_to_mtl); i++) { I also think we can make this section more common, it's just different naming compare to ADL. but can do it later on. -- To view, visit https://review.coreboot.org/c/coreboot/+/74380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20c9bc21dfa79696b07c460dbcedb4fa51838bdb Gerrit-Change-Number: 74380 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 05:08:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically
by Kapil Porwal (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Sumeet R Pawnikar. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 ) Change subject: soc/intel/meteoerlake: set power limits dynamically ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20c9bc21dfa79696b07c460dbcedb4fa51838bdb Gerrit-Change-Number: 74380 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 04:57:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Enable all DDI lanes
by Anil Kumar K (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Anil Kumar K has uploaded a new patch set (#2) to the change originally created by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/74413 ) Change subject: mb/google/rex: Enable all DDI lanes ...................................................................... mb/google/rex: Enable all DDI lanes This patch enables all DDI ports on Rex board to support tunnelled display on TBT dock. Branch=None Test=Boot rex and connect two displays over a TBT dock and check the display functionality Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/74413/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 Gerrit-Change-Number: 74413 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: src/mb/rex: Enable all DDI lanes
by Anil Kumar K (Code Review) 14 Apr '23

14 Apr '23

Anil Kumar K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74413 ) Change subject: src/mb/rex: Enable all DDI lanes ...................................................................... src/mb/rex: Enable all DDI lanes This patch enables all DDI ports on Rex board to support tunnelled display on TBT dock. Branch=None Test=Boot rex and connect two displays over a TBT dock and check the display functionality Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/74413/1 diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 17e4c3e..ebe1428 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -67,6 +67,10 @@ register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD, + [DDI_PORT_2] = DDI_ENABLE_HPD, + [DDI_PORT_3] = DDI_ENABLE_HPD, + [DDI_PORT_4] = DDI_ENABLE_HPD, }" register "serial_io_gspi_mode" = "{ -- To view, visit https://review.coreboot.org/c/coreboot/+/74413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ee5334fbb877bd58912c8d24920037f155dc42 Gerrit-Change-Number: 74413 Gerrit-PatchSet: 1 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023