Attention is currently required from: YH Lin, Tarun Tuli, Kapil Porwal, Eric Lai, Simon Zhou.
Hello YH Lin, Tarun Tuli, Subrata Banik, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74391
to look at the new patch set (#4).
Change subject: mb/google/rex: Create screebo variant
......................................................................
mb/google/rex: Create screebo variant
Create the screebo variant of the rex0 reference board by copying
the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:276814951
BRANCH=None
TEST=util/abuild/abuild -p none -t google/rex -x -a
make sure the build includes GOOGLE_SCREEBO
Change-Id: I8d05ca7c0fe596378ca15d0734d46ad1dc63a1f9
Signed-off-by: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/Kconfig
M src/mainboard/google/rex/Kconfig.name
A src/mainboard/google/rex/variants/screebo/Makefile.inc
A src/mainboard/google/rex/variants/screebo/gpio.c
A src/mainboard/google/rex/variants/screebo/include/variant/ec.h
A src/mainboard/google/rex/variants/screebo/include/variant/gpio.h
A src/mainboard/google/rex/variants/screebo/memory/Makefile.inc
A src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt
A src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt
A src/mainboard/google/rex/variants/screebo/overridetree.cb
10 files changed, 100 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/74391/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/74391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d05ca7c0fe596378ca15d0734d46ad1dc63a1f9
Gerrit-Change-Number: 74391
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74398 )
Change subject: cpu/intel/speedstep: Refactor P-state coordination
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/c/coreboot/+/74398/comment/f86d0bb1_e9dbff87
PS1, Line 66: ((cpuid_eax(1) >> 4) & 0xffff) == 0x1067
> sidenote: get_fms() might be nice.
This code should be checked for validity. Is it really about the model or hyperthreading?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12462f271821d3d8fe3324d84a65c2341729591e
Gerrit-Change-Number: 74398
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 14 Apr 2023 06:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74416 )
Change subject: mb/google/dedede/var/boten: Generate SPD ID for supported memory part
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174159):
https://review.coreboot.org/c/coreboot/+/74416/comment/b4765dc0_f70e0ec2
PS1, Line 19: Signed-off-by: kevin3.yang <kevin3.yang(a)lcfc.corp-partner.google.com>
Duplicate signature
--
To view, visit https://review.coreboot.org/c/coreboot/+/74416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f910393847c6494f77c009cb11f50b31bebffb6
Gerrit-Change-Number: 74416
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 14 Apr 2023 06:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Tarun Tuli, Kapil Porwal, Eric Lai, Simon Zhou.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74391 )
Change subject: mb/google/rex: Create screebo variant
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174158):
https://review.coreboot.org/c/coreboot/+/74391/comment/e1a2f54b_78ee2c7a
PS3, Line 9: # See util/spd_tools/README.md for more details and instructions.
'README' may be misspelled - perhaps 'README'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d05ca7c0fe596378ca15d0734d46ad1dc63a1f9
Gerrit-Change-Number: 74391
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 06:33:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Tarun Tuli, Kapil Porwal, Eric Lai, Simon Zhou.
Hello YH Lin, Tarun Tuli, Subrata Banik, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74391
to look at the new patch set (#3).
Change subject: mb/google/rex: Create screebo variant
......................................................................
mb/google/rex: Create screebo variant
Create the screebo variant of the rex0 reference board by copying
the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=BUG=b:276814951
BRANCH=None
TEST=util/abuild/abuild -p none -t google/rex -x -a
make sure the build includes GOOGLE_SCREEBO
Change-Id: I8d05ca7c0fe596378ca15d0734d46ad1dc63a1f9
Signed-off-by: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/Kconfig
M src/mainboard/google/rex/Kconfig.name
A src/mainboard/google/rex/variants/screebo/Makefile.inc
A src/mainboard/google/rex/variants/screebo/gpio.c
A src/mainboard/google/rex/variants/screebo/include/variant/ec.h
A src/mainboard/google/rex/variants/screebo/include/variant/gpio.h
A src/mainboard/google/rex/variants/screebo/memory/Makefile.inc
A src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt
A src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt
A src/mainboard/google/rex/variants/screebo/overridetree.cb
10 files changed, 100 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/74391/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/74391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d05ca7c0fe596378ca15d0734d46ad1dc63a1f9
Gerrit-Change-Number: 74391
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74270 )
Change subject: util/cbfstool: Qualify struct e820entry as packed
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74270/comment/0e7c1a66_b62b8c83
PS5, Line 7: Correct the definition of struct e820entry
> Maybe more specific – no idea if correct: Qualify struct e820entry as packed
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09955c90e4eec337adca383e628a8821075381d6
Gerrit-Change-Number: 74270
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 14 Apr 2023 06:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Kevin3 Yang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74415 )
Change subject: mb/google/dedede/var/boten: Generate SPD ID for supported memory part
......................................................................
mb/google/dedede/var/boten: Generate SPD ID for supported memory part
Add boten supported memory parts in mem_parts_used.txt, generate
SPD id for this part.
1. Samsung K4U6E3S4AB-MGCL
BUG=b:278138388
TEST=Use part_id_gen to generate related settings
Signed-off-by: kevin3.yang <kevin3.yang(a)lcfc.corp-partner.google.com>
Change-Id: I5f910393847c6494f77c009cb11f50b31bebffb6
---
M src/mainboard/google/dedede/variants/boten/memory/Makefile.inc
M src/mainboard/google/dedede/variants/boten/memory/dram_id.generated.txt
M src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
3 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/74415/1
diff --git a/src/mainboard/google/dedede/variants/boten/memory/Makefile.inc b/src/mainboard/google/dedede/variants/boten/memory/Makefile.inc
index dfc1efa..b04a663 100644
--- a/src/mainboard/google/dedede/variants/boten/memory/Makefile.inc
+++ b/src/mainboard/google/dedede/variants/boten/memory/Makefile.inc
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/boten/memory src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
+# ./util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/boten/memory src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
SPD_SOURCES =
SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE, MT53E512M32D1NP-046 WT:B
diff --git a/src/mainboard/google/dedede/variants/boten/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/boten/memory/dram_id.generated.txt
index 6403a2b..6e56f87 100644
--- a/src/mainboard/google/dedede/variants/boten/memory/dram_id.generated.txt
+++ b/src/mainboard/google/dedede/variants/boten/memory/dram_id.generated.txt
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/boten/memory src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
+# ./util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/boten/memory src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
DRAM Part Name ID to assign
MT53E512M32D2NP-046 WT:E 0 (0000)
diff --git a/src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
index 04f01b3..403a697 100644
--- a/src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
+++ b/src/mainboard/google/dedede/variants/boten/memory/mem_parts_used.txt
@@ -2,3 +2,4 @@
K4U6E3S4AA-MGCR
H9HCNNNBKMMLXR-NEE
MT53E512M32D1NP-046 WT:B
+
--
To view, visit https://review.coreboot.org/c/coreboot/+/74415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f910393847c6494f77c009cb11f50b31bebffb6
Gerrit-Change-Number: 74415
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Bill XIE.
Hello build bot (Jenkins), Paul Menzel, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74270
to look at the new patch set (#6).
Change subject: util/cbfstool: Qualify struct e820entry as packed
......................................................................
util/cbfstool: Qualify struct e820entry as packed
In order to accord with grub (see include/grub/i386/linux.h) and
comments for offsets of members of struct linux_params,
struct e820entry should be defined as __packed, otherwise,
sizeof(struct linux_params) will become 4224 (0x1080).
Fortunately, the affected area is usually not occupied.
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
Change-Id: I09955c90e4eec337adca383e628a8821075381d6
---
M util/cbfstool/linux.h
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/74270/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/74270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09955c90e4eec337adca383e628a8821075381d6
Gerrit-Change-Number: 74270
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Dinesh Gehlot.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74255 )
Change subject: soc/intel/cmd/block/cse: Add config option for storing fw version info
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/74255/comment/e96a3f80_ef3c849f
PS9, Line 56:
> > … from payload or OS, as that information can only be retrieved in the firmware stage(?) due to security measures(?).
>
> I don't think so, cbmem id can be retrieve from os (in read-only format)
>
> cbmem -r <cbmem_id>
marking this resolve now. please feel free share the thoughts otherwise.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74255
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78fef45fd2940536b3e91cfd4d184b7635238499
Gerrit-Change-Number: 74255
Gerrit-PatchSet: 12
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 06:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment