coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel/cmd/block/cse: Add config option for storing fw version info
by Subrata Banik (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Paul Menzel, Dinesh Gehlot. Subrata Banik has uploaded a new patch set (#14) to the change originally created by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/74255 ) Change subject: soc/intel/cmd/block/cse: Add config option for storing fw version info ...................................................................... soc/intel/cmd/block/cse: Add config option for storing fw version info This patch adds a configuration option, 'SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION', which enables the storage of firmware version information in CBMEM memory. This information can be used to identify the firmware version that is currently installed on the system. The option depends on the `DRIVERS_INTEL_ISH` config and platform should be flexible enough to opt out from enabling this feature. The cost of sending HECI command to read the CSE FPT is significant (~200ms) hence, the idea is to read the CSE RW version on every cold reset (to cover the CSE update scenarios) and store into CBMEM to avoid the cost of resending the HECI command in all consecutive warm boots. Later boot stages can just read the CBMEM ID to retrieve the ISH version if required. Additionally, ensure this feature is platform specific hence, getting enabled for the platform that would like to store the ISH version into the CBMEM and parse to perform some additional work. BUG=b:273661726 TEST=Able to build and boot google/marasov. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I78fef45fd2940536b3e91cfd4d184b7635238499 --- M src/soc/intel/common/block/cse/Kconfig 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74255/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/74255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78fef45fd2940536b3e91cfd4d184b7635238499 Gerrit-Change-Number: 74255 Gerrit-PatchSet: 14 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmd/block/cse: Add config option for storing fw version info
by Subrata Banik (Code Review) 14 Apr '23

14 Apr '23

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Daniel Maslowski (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Angel Pons, Maximilian Brune. Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: signed up for notifications - this is so awesome to see 🥳 -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 20:19:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmd/block/cse: Add config option for storing fw version info
by Subrata Banik (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Paul Menzel, Dinesh Gehlot. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74255 ) Change subject: soc/intel/cmd/block/cse: Add config option for storing fw version info ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/74255/comment/366f9476_206a7c65 PS13, Line 48: config SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION : bool : default n : depends on DRIVERS_INTEL_ISH : help : This configuration option stores CSE FPT partitions' version in CBMEM memory. : This information can be used to identify the currently running firmware partition : version. > Sorry, for bringing this up again. No idea, if it was answered in another change-set comment, but I think, it should be clear from the Kconfig description. > > 1. Why does this need to be configurable, and cannot be enable unconditionally? I can't add the details in the code itself as it may not be appropriate. let me explain here, since CNL there are many devices that opt for ISH but starting with ADL devices, we are planning to enable ISH update feature hence, everytime, we would like to update the ISH, we need back the version to compare again the updated version. mostly it will be done as part of the automated script running at os level and the only input we need is to retrieve the ISH version. Hence, this feature should be applicable to the platforms those who would like to enable this feature and doesn't applicavle to add devices that choose ISH KCONFIG by default. > 2. Why does this information need to be stored in CBMEM? If the firmware is updated in coreboot, why can’t coreboot read the version information directly? Is it some boundaries between stages? I thought mainly CBMEM is used to pass information to later programs like payloads or the OS (CBMEM console). there is a cost to send HECI cmd on every boot like 200ms where else if we could be able to read the version and store into cbmem, we can reuse it in multiple warm reset. Thats the reason, we have opt for cbmem. most likely in future i will drop cbmem and get into some more persistent NVS memory to even avoid running the cmd on cold resets. -- To view, visit https://review.coreboot.org/c/coreboot/+/74255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78fef45fd2940536b3e91cfd4d184b7635238499 Gerrit-Change-Number: 74255 Gerrit-PatchSet: 13 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 20:01:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/variants/hades: Update GPIO configs
by Tarun Tuli (Code Review) 14 Apr '23

14 Apr '23

Tarun Tuli has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/73909 ) Change subject: mb/google/brya/variants/hades: Update GPIO configs ...................................................................... mb/google/brya/variants/hades: Update GPIO configs Update GPIO configs based on latest schematics (revision aabe36) Move GPP_D4->GPP_A13 (BT_DISABLE_L) Swap GPP_E3<>GPP_E8 (WIFI_DISABLE_L and PG_PPVAR_GPU_NVVDD_X_OD) Move GPP_A13->GPP_A20 (GSC_PCH_INT_ODL) BUG=b:269371363 TEST=builds Change-Id: I958e45156515cf4ce236084ec823f9329d7a063d Signed-off-by: Tarun Tuli <taruntuli(a)google.com> --- M src/mainboard/google/brya/variants/hades/gpio.c 1 file changed, 29 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/73909/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/73909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I958e45156515cf4ce236084ec823f9329d7a063d Gerrit-Change-Number: 73909 Gerrit-PatchSet: 4 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/variants/hades: Update GPIO configs
by Tarun Tuli (Code Review) 14 Apr '23

14 Apr '23

Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73909 ) Change subject: mb/google/brya/variants/hades: Update GPIO configs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/73909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I958e45156515cf4ce236084ec823f9329d7a063d Gerrit-Change-Number: 73909 Gerrit-PatchSet: 3 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 19:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/lenovo/x200: Configure ck505 clockgen
by Swift Geek (Sebastian Grzywna) (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Stefan Ott, Bill XIE, Arthur Heymans, Alexander Couzens. Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74418 ) Change subject: mb/lenovo/x200: Configure ck505 clockgen ...................................................................... Patch Set 5: (1 comment) File src/mainboard/lenovo/x200/mainboard.c: https://review.coreboot.org/c/coreboot/+/74418/comment/599ff14f_a45b0d4f PS5, Line 16: set_gpio(42, GPIO_LEVEL_LOW); Would it be feasible to restore here state captured in start of ck505_set_mux_enable(), instead of hardcoding it ? That i2c bus switch in thinkpad is already causing enough issues for memtest86+ and other users, so I think it would be better if code wouldn't depend on particular expectation there for default state of the switch, as it would make eventual switch a bit be easier perhaps. -- To view, visit https://review.coreboot.org/c/coreboot/+/74418 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec9bbbaed43b74e8782f6963e491dbfa3b8b5247 Gerrit-Change-Number: 74418 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 14 Apr 2023 19:20:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable Key Locker
by Pratikkumar V Prajapati (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Pratikkumar Prajapati, Subrata Banik, Kapil Porwal. Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71120 ) Change subject: soc/intel/meteorlake: Enable Key Locker ...................................................................... Patch Set 21: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71120/comment/6c6baab0_aef04227 PS15, Line 9: Test: > >>Please mention the tested platform like RVP or Rex? […] No S0ix issue, No impact on power just with this coreboot patch, No stability issue, No significant difference in boot time (less than 1ms) Total boot time (using cbmem -t): With Key Locker coreboot patch: 1,600,762 Without Key Locker coreboot patch: 1,599,860 -- To view, visit https://review.coreboot.org/c/coreboot/+/71120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9919f44623972d7bbae4a9b886e1da4ac7879c98 Gerrit-Change-Number: 71120 Gerrit-PatchSet: 21 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 19:12:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable Key Locker
by Pratikkumar V Prajapati (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Pratikkumar V Prajapati. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71120 to look at the new patch set (#21). Change subject: soc/intel/meteorlake: Enable Key Locker ...................................................................... soc/intel/meteorlake: Enable Key Locker BUG=b:276988831 Platform=Rex Test= inteltool -k ============= Dumping INTEL Key Locker status ============= Key Locker supported : YES AESKL instructions enabled : YES =========================================================== Also, No S0ix issue, No impact on power just with this coreboot patch, No stability issue, No significant difference in boot time (less than 1ms) Total boot time (using cbmem -t): With Key Locker coreboot patch: 1,600,762 Without Key Locker coreboot patch: 1,599,860 Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> Change-Id: I9919f44623972d7bbae4a9b886e1da4ac7879c98 --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/71120/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/71120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9919f44623972d7bbae4a9b886e1da4ac7879c98 Gerrit-Change-Number: 71120 Gerrit-PatchSet: 21 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/cbfstool: Qualify struct e820entry as packed
by Nico Huber (Code Review) 14 Apr '23

14 Apr '23

Attention is currently required from: Bill XIE. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74270 ) Change subject: util/cbfstool: Qualify struct e820entry as packed ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: Linux also packs the whole params struct. Didn't see anything where it would make a difference, though. -- To view, visit https://review.coreboot.org/c/coreboot/+/74270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09955c90e4eec337adca383e628a8821075381d6 Gerrit-Change-Number: 74270 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Comment-Date: Fri, 14 Apr 2023 18:15:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023