coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/amd/phoenix: Add note clarifying the eMMC controller
by Eric Lai (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Fred Reitberger. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74590 ) Change subject: soc/amd/phoenix: Add note clarifying the eMMC controller ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5ffd9792cbdc174d9eab7aa14d1bd6b89e1c817 Gerrit-Change-Number: 74590 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:38:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: vendorcode/mediatek/mt8192: Fix set but unused variables
by Rex-BC Chen (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Xi Chen, Arthur Heymans, Yu-Ping Wu, Yidi Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74543 ) Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74543 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic05a9819764c03184b54c4fc58dbe325fddeae10 Gerrit-Change-Number: 74543 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:38:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: vendorcode/mediatek/mt8192: Add or remove brackets
by Xixi Chen (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Xi Chen, Arthur Heymans. Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74545 ) Change subject: vendorcode/mediatek/mt8192: Add or remove brackets ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4333b834ee2afb3147edf4c223724a851f159ba Gerrit-Change-Number: 74545 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:36:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: vendorcode/mediatek/mt8192: Fix set but unused variables
by Xixi Chen (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Xi Chen, Rex-BC Chen, Arthur Heymans, Yu-Ping Wu, Yidi Lin. Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74543 ) Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74543 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic05a9819764c03184b54c4fc58dbe325fddeae10 Gerrit-Change-Number: 74543 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:36:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/dptx.c: Remove set but unused variables
by Rex-BC Chen (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Hung-Te Lin, Arthur Heymans, Yidi Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74547 ) Change subject: soc/mediatek/dptx.c: Remove set but unused variables ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a3345e33380862d6939b61485f6d1eefa3d1815 Gerrit-Change-Number: 74547 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:36:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/riscv: Fix compiler argument for clang
by Elyes Haouas (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Philipp Hug, Arthur Heymans, ron minnich. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74568 ) Change subject: arch/riscv: Fix compiler argument for clang ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75947f614c3600d5d9d461970159f0787fd6c3de Gerrit-Change-Number: 74568 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:08:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: samsung/lumpy: Use APMC defines
by Elyes Haouas (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74523 ) Change subject: samsung/lumpy: Use APMC defines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I658596da1d84b486126d751b6066c3efd3f65290 Gerrit-Change-Number: 74523 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 01:03:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google,intel: Use common ChromeEC code for SMI APMC
by Elyes Haouas (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74513 ) Change subject: mb/google,intel: Use common ChromeEC code for SMI APMC ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b7c2b94e0fec84831740336ccdbea0922ffbfe Gerrit-Change-Number: 74513 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 00:58:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/riscv/trap_handler.c: Use new names for CSR
by Elyes Haouas (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Philipp Hug, Arthur Heymans, ron minnich. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74569 ) Change subject: arch/riscv/trap_handler.c: Use new names for CSR ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: duplicated sée 63073 -- To view, visit https://review.coreboot.org/c/coreboot/+/74569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c8fa82b6131dec10f55e8ebcf36b34e30b57bad Gerrit-Change-Number: 74569 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 00:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Add Voltage Regulator ICC max and TDC settings
by Jérémy Compostella (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74574 ) Change subject: mb/google/rex: Add Voltage Regulator ICC max and TDC settings ...................................................................... mb/google/rex: Add Voltage Regulator ICC max and TDC settings This patch defines the Voltage Regular Icc max and TDC settings applicable to the rex board designs per document #640982 revision 1p1 and considering that Fast VMode is enabled. BRANCH=None BUG=b:262499722 TEST=Verify in FSP logs that IccMax, TdcTimewindow and TdcCurrentLimit are overriden on a rex 15W board. Change-Id: I97271358c42cb1a14beb6aad44d8d2138f5237c5 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/74574/1 diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb index 08e1c40..87b6cf2 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb @@ -7,6 +7,23 @@ .tdp_pl1_override = 45, .tdp_pl2_override = 115, .tdp_pl4 = 197 + }, + .vr = { + [VR_DOMAIN_IA] = { + .icc_max = 176 * 4, + .tdc_timewindow = 28 * 1000, + .tdc_currentlimit = 83 * 8 + }, + [VR_DOMAIN_GT] = { + .icc_max = 81 * 4, + .tdc_timewindow = 28 * 1000, + .tdc_currentlimit = 83 * 8 + }, + [VR_DOMAIN_SA] = { + .icc_max = 40 * 4, + .tdc_timewindow = 28 * 1000, + .tdc_currentlimit = 83 * 8 + } } }, { @@ -16,6 +33,23 @@ .tdp_pl1_override = 15, .tdp_pl2_override = 57, .tdp_pl4 = 101 + }, + .vr = { + [VR_DOMAIN_IA] = { + .icc_max = 94 * 4, + .tdc_timewindow = 28 * 1000, + .tdc_currentlimit = 48 * 8 + }, + [VR_DOMAIN_GT] = { + .icc_max = 38 * 4, + .tdc_timewindow = 28 * 1000, + .tdc_currentlimit = 48 * 8 + }, + [VR_DOMAIN_SA] = { + .icc_max = 35 * 4, + .tdc_timewindow = 28 * 1000, + .tdc_currentlimit = 48 * 8 + } } } }" -- To view, visit https://review.coreboot.org/c/coreboot/+/74574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97271358c42cb1a14beb6aad44d8d2138f5237c5 Gerrit-Change-Number: 74574 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023