coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation
by Matt DeVillier (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Stefan Reinauer, Maximilian Brune. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74735 ) Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 Gerrit-Change-Number: 74735 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 18:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/smmstore/ramstage.c: retry smmstore init up 5 times
by Krystian Hebel (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Sean Rhodes, Michał Żygowski, Patrick Rudolph, Paul Menzel, Michał Kopeć. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73981 ) Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/drivers/smmstore/ramstage.c: https://review.coreboot.org/c/coreboot/+/73981/comment/5f7aa62c_2758708a PS1, Line 64: * Retry 5 times in case the SMI isn't triggered immediately. I/O port write request is sent to northbridge/ICH/PCH part of SoC, from where it used to be driven as SMI# towards CPU. At some point it was replaced by Virtual Legacy Wire (VLW) transactions sent through QuickPath Interconnect (QPI). Both options may introduce delays longer than that time between completing `out` instruction and executing the next one. I can't find anything concrete in newer documentation, but ICH10 datasheet says this: > System Management Interrupt: SMI# is an active low output > synchronous to PCICLK. It is asserted by the ICH10 in response to > one of many enabled hardware or software events. https://review.coreboot.org/c/coreboot/+/73981/comment/c1e963d0_66459ef9 PS1, Line 79: } while (retry--); > Use `wait_ms` macro from `src/include/timer.h`? […] I'm afraid this can't be done, even `mdelay()` should be removed from the code. On x86, `eax` is used for function return values, it may also be used internally by `mdelay()`, especially if it uses TSC under the hood. If SMI arrives after it is compared with `SMMSTORE_RET_SUCCESS`, further invocations of `SMMSTORE_CMD_INIT` will fail due to `if (store_initialized)` check in store.c. It will be even worse if it's get overwritten after `mdelay()` or any function called by it tries to use it. -- To view, visit https://review.coreboot.org/c/coreboot/+/73981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab Gerrit-Change-Number: 73981 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 18:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation
by Maximilian Brune (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Matt DeVillier, Stefan Reinauer. Hello Matt DeVillier, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74735 to look at the new patch set (#3). Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation ...................................................................... util/ifdtool/ifdtool.c: Fix default FMAP generation According to SPI programming guide, a region limit of 0 as well as region base of 7FFFh indicates an unused/reserved region. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 --- M util/ifdtool/ifdtool.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74735/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 Gerrit-Change-Number: 74735 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation
by build bot (Jenkins) (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Matt DeVillier, Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74735 ) Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174852): https://review.coreboot.org/c/coreboot/+/74735/comment/11f029ba_c15a6143 PS2, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 Gerrit-Change-Number: 74735 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 24 Apr 2023 18:07:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation
by Maximilian Brune (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Matt DeVillier, Stefan Reinauer. Hello Matt DeVillier, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74735 to look at the new patch set (#2). Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation ...................................................................... util/ifdtool/ifdtool.c: Fix default FMAP generation According to SPI programming guide, a region limit of 0 as well as region base of 7FFFh indicates an unused/reserved region. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 --- M util/ifdtool/ifdtool.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74735/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 Gerrit-Change-Number: 74735 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Revert "util/ifdtool: Add option to create FMAP template"
by Nico Huber (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Matt DeVillier, Stefan Reinauer, Kapil Porwal, Maximilian Brune, Angel Pons, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 ) Change subject: Revert "util/ifdtool: Add option to create FMAP template" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74692/comment/002ef4cd_8064c06f PS2, Line 11: Above commit inserts multiple IFD regions not present into the default : FMAP template, some of which overlap, resulting in far less space : available for BIOS region / CBFS. > never mind. Can you try the following patch: […] It's reading empty flash space: FLREG10: 0xffffffff etc. The patch should work in this case, because the space is empty and all 1's. But it doesn't solve the actual problem that ifdtool assumes 16 regions for Skylake. Which seems to come from the v1/v2 idea (Intel never mentioned any versioning, IIRC it was just made up years ago as a workaround). -- To view, visit https://review.coreboot.org/c/coreboot/+/74692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7 Gerrit-Change-Number: 74692 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 18:00:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "util/ifdtool: Add option to create FMAP template"
by Maximilian Brune (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Matt DeVillier, Stefan Reinauer, Kapil Porwal, Angel Pons, Lean Sheng Tan. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 ) Change subject: Revert "util/ifdtool: Add option to create FMAP template" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74692/comment/bb995028_e37f9043 PS2, Line 11: Above commit inserts multiple IFD regions not present into the default : FMAP template, some of which overlap, resulting in far less space : available for BIOS region / CBFS. > Usually these regions should be marked as unused (size < 1) in the IFD like the others are. never mind. Can you try the following patch: CB:74735 -- To view, visit https://review.coreboot.org/c/coreboot/+/74692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7 Gerrit-Change-Number: 74692 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 17:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation
by Maximilian Brune (Code Review) 24 Apr '23

24 Apr '23

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74735 ) Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation ...................................................................... util/ifdtool/ifdtool.c: Fix default FMAP generation According to SPI programming guide, a region size of 0 as well as region base of 7FFFh indicates an unused/reserved region. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 --- M util/ifdtool/ifdtool.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74735/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 625b4cf..131daa8 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1027,8 +1027,11 @@ struct region sorted_regions[MAX_REGIONS] = { 0 }; for (unsigned int i = 0; i < max_regions; i++) { struct region region = get_region(frba, i); - /* is region invalid? */ - if (region.size < 1) + + /* A region size of 0 is an indicator of an unused region as well as a region + * base of 7FFFh (according to SPI programming guide) + */ + if (region.size < 1 || region.base == 0x07FFF000) continue; /* Here we decide to use the coreboot generated FMAP BIOS region, instead of -- To view, visit https://review.coreboot.org/c/coreboot/+/74735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 Gerrit-Change-Number: 74735 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util: Use common ARRAY_SIZE define
by Robert Zieba (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Konrad Adamczyk, Jakub Czapiga, Christian Walter, Felix Held. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74474 ) Change subject: util: Use common ARRAY_SIZE define ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29b776586b4f0548d4026b2ac77095791fc9f3a3 Gerrit-Change-Number: 74474 Gerrit-PatchSet: 2 Gerrit-Owner: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Grzegorz Bernacki Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 16:49:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/skyrim: rename baseboard gpios in gpio.c
by Martin L Roth (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 ) Change subject: mb/google/skyrim: rename baseboard gpios in gpio.c ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74592/comment/243a6401_4c4a6819 PS2, Line 10: SYS_RST_ODL > We moved netnames between build phases themselves - eg. GSC_SOC_INT moved from GPIO_X to GPIO_Y within guybrush phase1 and pahse2 itself. Not between guybrush and nipperkin. So phase specific overrides will have GPIO_NN still. I actually think this is an argument *for* using the net names. We can rename them from GSC_SOC_INT to GSC_SOC_INT_PHASE1 and GSC_SOC_INT_PHASE2 or something. That makes what's going on with this very clear. > One of the nice things about using the numbers is that we can quickly glance at the table to make sure we defined all the GPIOs in the ramstage table. I *still* feel that we need a runtime check to verify this - doing it manually is always going to be more error-prone. Doing something at runtime gives us a number of features. We can capture the time of the change, the IOMUX settings, what if anything got changed in the FSP calls, and allows us to verify that everything was set correctly. If something gets updated in bootblock, but we forget to update it in ramstage, that would be a lot more obvious in a diff between the two GPIO init logs than in the code. -- To view, visit https://review.coreboot.org/c/coreboot/+/74592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340 Gerrit-Change-Number: 74592 Gerrit-PatchSet: 10 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 16:39:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023