coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mb/google/myst: Enable PCIe devices in devicetree
by Eric Lai (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Jon Murphy, Martin Roth, Felix Held, Mark Hasemeyer. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74112 ) Change subject: mb/google/myst: Enable PCIe devices in devicetree ...................................................................... Patch Set 43: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdad785bcb90de036095bcc4219c15f55f4277fe Gerrit-Change-Number: 74112 Gerrit-PatchSet: 43 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 23:51:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/psp_verstage: Map/unmap boot device on need basis
by Karthik Ramasubramanian (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74606 ) Change subject: soc/amd/common/psp_verstage: Map/unmap boot device on need basis ...................................................................... Patch Set 1: (3 comments) File src/soc/amd/common/psp_verstage/boot_dev.c: https://review.coreboot.org/c/coreboot/+/74606/comment/62baa86c_df99393a PS1, Line 22: svc_map_spi_rom > Will this set mapping to NULL on failure? I expect SVC call to not touch mapping on failure. Do you think setting explicitly to NULL again might be safe? https://review.coreboot.org/c/coreboot/+/74606/comment/bdf51c9d_485785b0 PS1, Line 22: size > Does this have any alignment restrictions? Not that I am aware of. I can check with PSP team. File src/soc/amd/common/psp_verstage/fch.c: https://review.coreboot.org/c/coreboot/+/74606/comment/91e244b0_20a20219 PS1, Line 100: SpiBiosSmnBase > Is this really a `void *`? Atleast as per the command structure defined in bl_syscall_public.h - https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/he… -- To view, visit https://review.coreboot.org/c/coreboot/+/74606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd44ea7b2a366e9269debcab4186d1fc71651db2 Gerrit-Change-Number: 74606 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 23:07:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ACPI: Make FADT entries for RTC/CMOS architectural
by Kyösti Mälkki (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Matt DeVillier, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Arthur Heymans, Fred Reitberger, Tim Chu, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74601 ) Change subject: ACPI: Make FADT entries for RTC/CMOS architectural ...................................................................... Patch Set 1: (2 comments) File src/arch/x86/acpi.c: https://review.coreboot.org/c/coreboot/+/74601/comment/8d33621c_77b9853d PS1, Line 32: #define RTC_CENTURY 0x48 <drivers/pc80/mcXXX.h> File src/southbridge/amd/pi/hudson/fadt.c: https://review.coreboot.org/c/coreboot/+/74601/comment/87e5e47d_d135d46a PS1, Line 43: fadt->mon_alrm = 0; /* 0x7e added to cmos.layout */ need to check -- To view, visit https://review.coreboot.org/c/coreboot/+/74601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I965a83dc8daaa02ad0935bdde5ca50110adb014a Gerrit-Change-Number: 74601 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 21:55:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable PCIe devices in devicetree
by Tim Van Patten (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Jon Murphy, Martin Roth, Felix Held, Mark Hasemeyer. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74112 ) Change subject: mb/google/myst: Enable PCIe devices in devicetree ...................................................................... Patch Set 43: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdad785bcb90de036095bcc4219c15f55f4277fe Gerrit-Change-Number: 74112 Gerrit-PatchSet: 43 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 21:41:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common: Identify FSP HOB type GUIDs
by Martin L Roth (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74344 ) Change subject: soc/amd/common: Identify FSP HOB type GUIDs ...................................................................... Patch Set 1: (2 comments) File src/soc/amd/common/fsp/hob_display.c: PS1: > i personally would prefer to use the coreboot type guid_t and the macro GUID_INIT instead of the EFI […] The reason I chose this representation is because it allows us to more easily search for the guids in the AGESA FSP source. If the coreboot GUID_INIT function used a uint64_t for the last segment instead of 8 uint8_t values, I'd support it. That would match the standard GUID representation instead of doing our own thing. https://review.coreboot.org/c/coreboot/+/74344/comment/1868dff9_0afa36bf PS1, Line 5: #include <lib.h> > i don't see what this is needed for. you'll need to include types. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e0b4c3e3c7b6271ac64f9296c8a3f46d28e244d Gerrit-Change-Number: 74344 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 21:28:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common: Identify FSP HOB type GUIDs
by Martin L Roth (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74344 to look at the new patch set (#2). Change subject: soc/amd/common: Identify FSP HOB type GUIDs ...................................................................... soc/amd/common: Identify FSP HOB type GUIDs This identifies GUIDs used in the AMD FSP so they don't display as "Unknown GUID". Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I3e0b4c3e3c7b6271ac64f9296c8a3f46d28e244d --- M src/soc/amd/common/fsp/Makefile.inc A src/soc/amd/common/fsp/hob_display.c 2 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/74344/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e0b4c3e3c7b6271ac64f9296c8a3f46d28e244d Gerrit-Change-Number: 74344 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Disable unused SPI ROM types
by Tim Van Patten (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Martin Roth. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 ) Change subject: mb/google/skyrim: Disable unused SPI ROM types ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/skyrim/Kconfig: https://review.coreboot.org/c/coreboot/+/72769/comment/e235fdcd_073cdf26 PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond : config SPI_FLASH_GIGADEVICE : default y : : # XMC chips used on Markarth as an alternative to Winbond : # These chips identify as ST Micro (Manufacturer ID: 0x20) : config SPI_FLASH_STMICRO : default y > While it's possible, my personal preference is that the Kconfig. […] `skyrim/Kconfig.name` is already being used for device-specific values. For example: ``` config BOARD_GOOGLE_WINTERHOLD bool "-> Winterhold" select BOARD_GOOGLE_BASEBOARD_SKYRIM select SOC_AMD_COMMON_BLOCK_ACPI_DPTC select FEATURE_DYNAMIC_DPTC config BOARD_GOOGLE_FROSTFLOW bool "-> Frostflow" select BOARD_GOOGLE_BASEBOARD_SKYRIM select DRIVERS_GENESYSLOGIC_GL9755 select FEATURE_TABLET_MODE_DPTC select SOC_AMD_COMMON_BLOCK_ACPI_DPTC ``` I agree that it would be good to have a consensus on this, and cleanup whichever file we settle on. -- To view, visit https://review.coreboot.org/c/coreboot/+/72769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6e402269d1f2cac8256d478eb36743441497bdf Gerrit-Change-Number: 72769 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 21:19:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google,intel: Use common ChromeEC code for SMI APMC
by Kyösti Mälkki (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Subrata Banik, Matt DeVillier, Karthik Ramasubramanian, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74513 ) Change subject: mb/google,intel: Use common ChromeEC code for SMI APMC ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > would be good to test this one on hardware, since this will have google_chromeec_get_mkbp_event call […] Right, I missed the added MKBP here, but noticed in CB:74603 for the chromeec_smi_sleep() case and left it as [WIP] for this exact reason. Related: CB:15685 and CB:22005. Latter describes "adding EC debug logs" as a verification and test. So what would be the minimal required hardware testing for this? The first APMC that would reach the changed code is late ramstage, device init calls apm_control() with APM_CNT_ACPI_DISABLE or _ENABLE. Just getting past that with one of the boards without regression is enough? -- To view, visit https://review.coreboot.org/c/coreboot/+/74513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b7c2b94e0fec84831740336ccdbea0922ffbfe Gerrit-Change-Number: 74513 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 21:13:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Hide unused GPP port
by Martin L Roth (Code Review) 24 Apr '23

24 Apr '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/73862 ) Change subject: mb/google/skyrim: Hide unused GPP port ...................................................................... Abandoned The GPP ports are now marked as hidden in the chipset file. -- To view, visit https://review.coreboot.org/c/coreboot/+/73862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c1e4c21649610b856469b164ce5b0221f01b7f9 Gerrit-Change-Number: 73862 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Disable unused SPI ROM types
by Martin Roth (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Tim Van Patten. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 ) Change subject: mb/google/skyrim: Disable unused SPI ROM types ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/skyrim/Kconfig: https://review.coreboot.org/c/coreboot/+/72769/comment/b08d48f7_efeefc65 PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond : config SPI_FLASH_GIGADEVICE : default y : : # XMC chips used on Markarth as an alternative to Winbond : # These chips identify as ST Micro (Manufacturer ID: 0x20) : config SPI_FLASH_STMICRO : default y > Can these be moved to `skyrim/Kconfig. […] While it's possible, my personal preference is that the Kconfig.name file is used only for the actual name selection. If there's a strong preference in that direction for Google platforms, I can do it, but I dislike having the board configuration being split between two files. -- To view, visit https://review.coreboot.org/c/coreboot/+/72769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6e402269d1f2cac8256d478eb36743441497bdf Gerrit-Change-Number: 72769 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 21:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023