coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Stefan Reinauer, Maximilian Brune. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74735 ) Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation ...................................................................... Patch Set 3: (1 comment) File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/74735/comment/1d86734c_ed2f74dd PS3, Line 460: /* is region invalid? */ : if (region.size < 1) : continue; What about this one? Can the logic of loping over regions be deduplicated? -- To view, visit https://review.coreboot.org/c/coreboot/+/74735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72 Gerrit-Change-Number: 74735 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 07:04:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/omnigul: Disable PCH USB2 phy power gating
by Dtrain Hsu (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Tarun Tuli. Hello Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74737 to look at the new patch set (#2). Change subject: mb/google/brya/var/omnigul: Disable PCH USB2 phy power gating ...................................................................... mb/google/brya/var/omnigul: Disable PCH USB2 phy power gating The patch disables PCH USB2 Phy power gating to prevent possible display flicker issue for Omnigul board. Please refer Intel doc#723158 for more information. BUG=b: TEST=Verify the build for Omnigul board Change-Id: I04e54df5afe09c12e1cf774445d57e13ffd8819e Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/omnigul/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/74737/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04e54df5afe09c12e1cf774445d57e13ffd8819e Gerrit-Change-Number: 74737 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/siemens/mc_ehl4: Adjust GPIOs
by Mario Scheithauer (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Paul Menzel, Werner Zeh, Jan Samek. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 ) Change subject: mb/siemens/mc_ehl4: Adjust GPIOs ...................................................................... Patch Set 5: (1 comment) File src/mainboard/siemens/mc_ehl/variants/mc_ehl4/gpio.c: https://review.coreboot.org/c/coreboot/+/74628/comment/d74e2124_86be9efe PS4, Line 64: PAD_CFG_NF(GPP_H8, UP_20K, DEEP, NF1), /* SIO_I2C4_SDA */ : PAD_CFG_NF(GPP_H9, UP_20K, DEEP, NF1), /* SIO_I2C4_SCL */ > Please keep I2C4 in place as it will be used. I have included both GPIOs again. But in this case, FSP would also set them to NF1, since device 19.0 is now enabled again in devicetree. -- To view, visit https://review.coreboot.org/c/coreboot/+/74628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43 Gerrit-Change-Number: 74628 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 06:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/omnigul: Disable PCH USB2 phy power gating
by Dtrain Hsu (Code Review) 25 Apr '23

25 Apr '23

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74737 ) Change subject: mb/google/brya/var/omnigul: Disable PCH USB2 phy power gating ...................................................................... mb/google/brya/var/omnigul: Disable PCH USB2 phy power gating The patch disables PCH USB2 Phy power gating to prevent possible display flicker issue for Omnigul board. Please refer Intel doc#723158 for more information. BUG=b: TEST=Verify the build for Omnigul board Change-Id: I04e54df5afe09c12e1cf774445d57e13ffd8819e Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/omnigul/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/74737/1 diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb index 760ee82..4eed200 100644 --- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb +++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb @@ -10,6 +10,10 @@ register "sagv" = "SaGv_Enabled" + # As per Intel Advisory doc#723158, the change is required to prevent possible + # display flickering issue. + register "usb2_phy_sus_pg_disable" = "1" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | -- To view, visit https://review.coreboot.org/c/coreboot/+/74737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04e54df5afe09c12e1cf774445d57e13ffd8819e Gerrit-Change-Number: 74737 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/siemens/mc_ehl4: Adjust GPIOs
by Mario Scheithauer (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Paul Menzel, Mario Scheithauer, Jan Samek. Hello build bot (Jenkins), Werner Zeh, Jan Samek, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74628 to look at the new patch set (#5). Change subject: mb/siemens/mc_ehl4: Adjust GPIOs ...................................................................... mb/siemens/mc_ehl4: Adjust GPIOs Since mc_ehl4 was only a copy of mc_ehl1 in a first step, the GPIOs must be adjust according to the circuit diagram for this mainboard. Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_ehl/variants/mc_ehl4/gpio.c 1 file changed, 20 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/74628/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43 Gerrit-Change-Number: 74628 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/siemens/mc_ehl4: Adjust GPIOs
by Werner Zeh (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Paul Menzel, Mario Scheithauer, Jan Samek. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 ) Change subject: mb/siemens/mc_ehl4: Adjust GPIOs ...................................................................... Patch Set 4: (1 comment) File src/mainboard/siemens/mc_ehl/variants/mc_ehl4/gpio.c: https://review.coreboot.org/c/coreboot/+/74628/comment/eea034d6_39c101f5 PS4, Line 64: PAD_CFG_NF(GPP_H8, UP_20K, DEEP, NF1), /* SIO_I2C4_SDA */ : PAD_CFG_NF(GPP_H9, UP_20K, DEEP, NF1), /* SIO_I2C4_SCL */ Please keep I2C4 in place as it will be used. -- To view, visit https://review.coreboot.org/c/coreboot/+/74628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43 Gerrit-Change-Number: 74628 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 06:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/docker/jenkins-node: Drop Zephyr SDK
by Felix Singer (Code Review) 25 Apr '23

25 Apr '23

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73979 ) Change subject: util/docker/jenkins-node: Drop Zephyr SDK ...................................................................... Patch Set 5: (1 comment) Patchset: PS1: > Will reopen after submission. Reopened. -- To view, visit https://review.coreboot.org/c/coreboot/+/73979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie498d687e1566133adf650166117d8f68fcfdaf6 Gerrit-Change-Number: 73979 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Apr 2023 05:36:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/docker/jenkins-node: Drop Zephyr SDK
by Felix Singer (Code Review) 25 Apr '23

25 Apr '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73979 ) Change subject: util/docker/jenkins-node: Drop Zephyr SDK ...................................................................... util/docker/jenkins-node: Drop Zephyr SDK The version of the Zephyr SDK that is used is quite old and Zephyr hasn't been really used. Thus, drop it and also its dependencies from u-boot. Change-Id: Ie498d687e1566133adf650166117d8f68fcfdaf6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/73979 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Matt DeVillier: Looks good to me, but someone else must approve diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 7ab703c..37537cc 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -13,12 +13,6 @@ # Because we're piping the contents of the dockerfile into the # docker build command, the 'COPY' keyword isn't valid. -FROM coreboot/coreboot-sdk:{{SDK_VERSION}} AS zephyr-sdk -USER root -RUN wget -O zephyr.run https://github.com/zephyrproject-rtos/sdk-ng/releases/download/v0.11.3/zeph… -RUN chmod +x ./zephyr.run -RUN ./zephyr.run -- -d /opt/zephyr-sdk - FROM coreboot/coreboot-sdk:{{SDK_VERSION}} USER root @@ -83,18 +77,6 @@ chown root /usr/sbin/encapsulate && \ chmod +s /usr/sbin/encapsulate -COPY --from=zephyr-sdk /opt/zephyr-sdk /opt/zephyr-sdk - -# Build U-boot tools needed by zephyr -RUN mkdir /tmp/b && cd /tmp/b && \ - git clone https://git.kernel.org/pub/scm/utils/dtc/dtc.git dtc && \ - git clone https://chromium.googlesource.com/chromiumos/third_party/u-boot -b chromeos-v2020.10-rc1 u-boot && \ - (cd dtc && make install_pylibfdt PREFIX=/usr/local) && \ - (cd u-boot/tools/dtoc && python3 setup.py install) && \ - (cd u-boot/tools/patman && python3 setup.py install) && \ - (cd u-boot/tools/binman && python3 setup.py install) && \ - cd / && rm -rf /tmp/b - VOLUME /data/cache ENTRYPOINT mount /cb-build && \ mount /home/coreboot/node-root/workspace && \ -- To view, visit https://review.coreboot.org/c/coreboot/+/73979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie498d687e1566133adf650166117d8f68fcfdaf6 Gerrit-Change-Number: 73979 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: util/docker/jenkins-node: Allow pip to install packages system-wide
by Felix Singer (Code Review) 25 Apr '23

25 Apr '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74292 ) Change subject: util/docker/jenkins-node: Allow pip to install packages system-wide ...................................................................... util/docker/jenkins-node: Allow pip to install packages system-wide Call pip3 with `--break-system-packages` allowing it to install packages system-wide. This fixes building the Docker container. Change-Id: Id093f2c69fec43556c434fbca7b36095a7e6bd97 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74292 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Matt DeVillier: Looks good to me, but someone else must approve diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index b277efa..7ab703c 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -44,8 +44,8 @@ python3-pyrsistent \ swig \ && apt-get clean \ - && pip3 install --upgrade --no-cache-dir pip \ - && pip3 install --no-cache-dir \ + && pip3 install --upgrade --no-cache-dir --break-system-packages pip \ + && pip3 install --no-cache-dir --break-system-packages \ setuptools==58.2.0 \ jinja2==3.0.3 \ recommonmark===0.5.0 \ -- To view, visit https://review.coreboot.org/c/coreboot/+/74292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id093f2c69fec43556c434fbca7b36095a7e6bd97 Gerrit-Change-Number: 74292 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util/docker/jenkins-node: Merge package installations into first step
by Felix Singer (Code Review) 25 Apr '23

25 Apr '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74245 ) Change subject: util/docker/jenkins-node: Merge package installations into first step ...................................................................... util/docker/jenkins-node: Merge package installations into first step It's not necessary to have multiple steps for installing packages and requirements. Just merge the two install steps to one. Change-Id: Ibe620e5b20a5f1a5d4e1c4c98942c136f450f280 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74245 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 36 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Matt DeVillier: Looks good to me, but someone else must approve diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 2fc380d..b277efa 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -35,7 +35,25 @@ parallel \ ruby-full \ sdcc \ - && apt-get clean + python3-pip \ + pykwalify \ + python3-yaml \ + python3-pyelftools \ + python3-jsonschema \ + python3-colorama \ + python3-pyrsistent \ + swig \ + && apt-get clean \ + && pip3 install --upgrade --no-cache-dir pip \ + && pip3 install --no-cache-dir \ + setuptools==58.2.0 \ + jinja2==3.0.3 \ + recommonmark===0.5.0 \ + sphinx===1.8.3 \ + sphinxcontrib-ditaa===0.6 \ + sphinx_autobuild===0.7.1 \ + sphinx_rtd_theme===0.4.2 \ + && gem install mdl # Because of the way that the variables are being replaced, docker's 'COPY' # command does not work @@ -67,28 +85,6 @@ COPY --from=zephyr-sdk /opt/zephyr-sdk /opt/zephyr-sdk -RUN apt-get update && \ - apt-get install -y \ - python3-pip \ - pykwalify \ - python3-yaml \ - python3-pyelftools \ - python3-jsonschema \ - python3-colorama \ - python3-pyrsistent \ - swig \ - && apt-get clean \ - && pip3 install --upgrade --no-cache-dir pip \ - && pip3 install --no-cache-dir \ - setuptools==58.2.0 \ - jinja2==3.0.3 \ - recommonmark===0.5.0 \ - sphinx===1.8.3 \ - sphinxcontrib-ditaa===0.6 \ - sphinx_autobuild===0.7.1 \ - sphinx_rtd_theme===0.4.2 \ - && gem install mdl - # Build U-boot tools needed by zephyr RUN mkdir /tmp/b && cd /tmp/b && \ git clone https://git.kernel.org/pub/scm/utils/dtc/dtc.git dtc && \ -- To view, visit https://review.coreboot.org/c/coreboot/+/74245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe620e5b20a5f1a5d4e1c4c98942c136f450f280 Gerrit-Change-Number: 74245 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023